From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtpfb1-g21.free.fr (smtpfb1-g21.free.fr [212.27.42.9]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 79D1C8BF1 for ; Sat, 17 Dec 2022 21:05:06 +0000 (UTC) Received: from smtp5-g21.free.fr (smtp5-g21.free.fr [212.27.42.5]) by smtpfb1-g21.free.fr (Postfix) with ESMTP id A1C24DF94DD for ; Sat, 17 Dec 2022 21:57:24 +0100 (CET) Received: from SOPL295.local (unknown [IPv6:2a01:e0a:a6a:5f90:5db3:4ad4:9c19:1e87]) (Authenticated sender: robert.jarzmik@free.fr) by smtp5-g21.free.fr (Postfix) with ESMTPSA id 020015FF88; Sat, 17 Dec 2022 21:57:02 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=free.fr; s=smtp-20201208; t=1671310637; bh=OVeURlGUnn7ZUf0+Hoi0DPTZGsHXfWN8ZeCbFAHiRHU=; h=References:From:To:Cc:Subject:Date:In-reply-to:From; b=PE5m16C+/cBk5GWZuBSql3yTv14i9bD9Fi84WIiXIMlVxH2r/0UpMrxznwcb3fNhi cZojmjSCinyHlIMWsUjIu0u0wrV+ZaHi/kTE/NAR/NenML4vTa/aWkpWGVKtx4Hco4 T//Df9XpmOHdcwBhiRBJtbYqFcMAMRLVX3WHoBhAWLz1JrRw0WpIk/XZ+QJrUzaVQ7 TmWlJ+QxsM3ZyPU4Zs9VOi3h0gvJOVZYycP3u+gVwr66irRl+IvMb7UO2ZkvDDl94O 7kUortuccTscYgqykMewPJuQwdd6Ruei3N4YB2XX5nz921f/7gN8BttSy1sGSQHso3 qqHSW4GZR8dZQ== References: <20221215160747.2173998-1-arnd@kernel.org> User-agent: mu4e 1.8.11; emacs 28.1 From: Robert Jarzmik To: Arnd Bergmann Cc: Daniel Mack , Haojian Zhuang , Robert Jarzmik , soc@kernel.org, Arnd Bergmann , Russell King , Nathan Chancellor , Nick Desaulniers , Tom Rix , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, llvm@lists.linux.dev Subject: Re: [PATCH] ARM: pxa: fix building with clang Date: Sat, 17 Dec 2022 21:45:41 +0100 In-reply-to: <20221215160747.2173998-1-arnd@kernel.org> Message-ID: Precedence: bulk X-Mailing-List: llvm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; format=flowed Arnd Bergmann writes: > From: Arnd Bergmann > > The integrated assembler in clang does not understand the xscale > specific mra/mar instructions: > > arch/arm/mach-pxa/pxa27x.c:136:15: error: unsupported > architectural extension: xscale > asm volatile(".arch_extension xscale\n\t" > arch/arm/mach-pxa/pxa27x.c:136:40: error: invalid instruction, > did you mean: mcr, mla, mrc, mrs, msr? > mra r2, r3, acc0 > > Since these are coprocessor features, the same can be expressed > using > mrrc/mcrr, so use that for builds with IAS. Ok Arnd, but "mrrc" is an ARMv6 instruction if I'm not mistaken. Yet PXA27X is an ARMv5 XScale instruction set IP. Is that patch correct therefore, or is it just to make clang happy even if it's not correct ? Cheers. -- Robert From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 24DEDC4332F for ; Sat, 17 Dec 2022 20:58:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:Message-ID:In-reply-to:Date:Subject:Cc: To:From:References:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=VVI2pRMxb+8dDDax/56v4wfj0P3ui4kkE2Hjpd92ZvM=; b=G315k23vCHh0JCi716V523Ehve BElhFE0zWefJBKkD0vRTYS21tbmPzZRv5HBAOjSWCKCIFk53L1k6HF9xfVnEDJI1XoC0zd44zPWsf YRiDsK9FoqUKShCIGiaB2di3+XuMPG6N5NsBuhEOzOSsDl2RtxYYRLRGq8gDlq+tBHWQ1qc4s9LdW n0P4AJiGo6SxTh8HmcoOmBPa7hFaPVtqysSdp3mYyBHDKowBOX1jOrTDyZdOMYZlw84ZXtWsVoAFP FZCpYy0mF8IC4jFrlDMYAySwpd5qeryvYNzAa3j/0/AOIc3kPW7yzzo961A/veDrNBkRFyOuGxts8 kloZYrKg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1p6eFR-00CpnO-ER; Sat, 17 Dec 2022 20:57:33 +0000 Received: from smtp5-g21.free.fr ([2a01:e0c:1:1599::14]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1p6eFL-00CpmM-00 for linux-arm-kernel@lists.infradead.org; Sat, 17 Dec 2022 20:57:32 +0000 Received: from SOPL295.local (unknown [IPv6:2a01:e0a:a6a:5f90:5db3:4ad4:9c19:1e87]) (Authenticated sender: robert.jarzmik@free.fr) by smtp5-g21.free.fr (Postfix) with ESMTPSA id 020015FF88; Sat, 17 Dec 2022 21:57:02 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=free.fr; s=smtp-20201208; t=1671310637; bh=OVeURlGUnn7ZUf0+Hoi0DPTZGsHXfWN8ZeCbFAHiRHU=; h=References:From:To:Cc:Subject:Date:In-reply-to:From; b=PE5m16C+/cBk5GWZuBSql3yTv14i9bD9Fi84WIiXIMlVxH2r/0UpMrxznwcb3fNhi cZojmjSCinyHlIMWsUjIu0u0wrV+ZaHi/kTE/NAR/NenML4vTa/aWkpWGVKtx4Hco4 T//Df9XpmOHdcwBhiRBJtbYqFcMAMRLVX3WHoBhAWLz1JrRw0WpIk/XZ+QJrUzaVQ7 TmWlJ+QxsM3ZyPU4Zs9VOi3h0gvJOVZYycP3u+gVwr66irRl+IvMb7UO2ZkvDDl94O 7kUortuccTscYgqykMewPJuQwdd6Ruei3N4YB2XX5nz921f/7gN8BttSy1sGSQHso3 qqHSW4GZR8dZQ== References: <20221215160747.2173998-1-arnd@kernel.org> User-agent: mu4e 1.8.11; emacs 28.1 From: Robert Jarzmik To: Arnd Bergmann Cc: Daniel Mack , Haojian Zhuang , Robert Jarzmik , soc@kernel.org, Arnd Bergmann , Russell King , Nathan Chancellor , Nick Desaulniers , Tom Rix , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, llvm@lists.linux.dev Subject: Re: [PATCH] ARM: pxa: fix building with clang Date: Sat, 17 Dec 2022 21:45:41 +0100 In-reply-to: <20221215160747.2173998-1-arnd@kernel.org> Message-ID: MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221217_125730_461330_4C514892 X-CRM114-Status: GOOD ( 11.03 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Arnd Bergmann writes: > From: Arnd Bergmann > > The integrated assembler in clang does not understand the xscale > specific mra/mar instructions: > > arch/arm/mach-pxa/pxa27x.c:136:15: error: unsupported > architectural extension: xscale > asm volatile(".arch_extension xscale\n\t" > arch/arm/mach-pxa/pxa27x.c:136:40: error: invalid instruction, > did you mean: mcr, mla, mrc, mrs, msr? > mra r2, r3, acc0 > > Since these are coprocessor features, the same can be expressed > using > mrrc/mcrr, so use that for builds with IAS. Ok Arnd, but "mrrc" is an ARMv6 instruction if I'm not mistaken. Yet PXA27X is an ARMv5 XScale instruction set IP. Is that patch correct therefore, or is it just to make clang happy even if it's not correct ? Cheers. -- Robert _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel