From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jonathan Creekmore <jonathan.creekmore@gmail.com>
Subject: Re: [PATCH v5 2/5] build: Hook the schedulers into
	Kconfig
Date: Thu, 14 Jan 2016 10:23:52 -0600
Message-ID: <m21t9k3zaf.fsf@Nebula.lan>
References: <1452782954-56016-1-git-send-email-jonathan.creekmore@gmail.com>
	<1452782954-56016-3-git-send-email-jonathan.creekmore@gmail.com>
	<5697D71D02000078000C6DE6@prv-mh.provo.novell.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta4.messagelabs.com ([85.158.143.247])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <jonathan.creekmore@gmail.com>) id 1aJkgn-000096-GL
	for xen-devel@lists.xenproject.org; Thu, 14 Jan 2016 16:23:57 +0000
Received: by mail-yk0-f193.google.com with SMTP id k129so38345572yke.3
	for <xen-devel@lists.xenproject.org>;
	Thu, 14 Jan 2016 08:23:56 -0800 (PST)
In-reply-to: <5697D71D02000078000C6DE6@prv-mh.provo.novell.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Jan Beulich <JBeulich@suse.com>
Cc: George Dunlap <george.dunlap@eu.citrix.com>, Jonathan Creekmore <jonathan.creekmore@gmail.com>, Dario Faggioli <dario.faggioli@citrix.com>, xen-devel@lists.xenproject.org
List-Id: xen-devel@lists.xenproject.org


Jan Beulich writes:

>>>> On 14.01.16 at 15:49, <jonathan.creekmore@gmail.com> wrote:
>> --- a/xen/common/Kconfig
>> +++ b/xen/common/Kconfig
>> @@ -51,4 +51,63 @@ config KEXEC
>>
>>  	  If unsure, say Y.
>>
>> +# Enable schedulers
>> +menu "Schedulers"
>> +	visible if EXPERT = "y"
>> +
>> +config SCHED_CREDIT
>> +	bool
>> +	default y
>> +	---help---
>> +	  The traditional credit scheduler is a general purpose scheduler.
>
> So is this option now useful for anything?

It keeps the code between all of the schedulers consistent (all of them
have a #define if they are compiled it) and helps keep my downstream
patch smaller.

>
>> +choice
>> +	prompt "Default Scheduler?"
>> +	default SCHED_CREDIT_DEFAULT if SCHED_CREDIT
>> +	default SCHED_CREDIT2_DEFAULT if SCHED_CREDIT2
>> +	default SCHED_RTDS_DEFAULT if SCHED_RTDS
>> +	default SCHED_ARINC653_DEFAULT if SCHED_ARINC653
>
> And certainly all these defaults are now pointless, considering
> that the condition of the first one is "if y".

Yes, I could rip all of those out now since credit is always the
default. I left it in there for the ideal case that credit didn't have
to be special cased but, at this point, I will rip it out if you want.