From: Andi Kleen <andi@firstfloor.org>
To: David Howells <dhowells@redhat.com>
Cc: linux-arch@vger.kernel.org, mingo@elte.hu, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/7] Add assertion checking macros
Date: Fri, 16 Dec 2011 13:36:53 -0800 [thread overview]
Message-ID: <m21us4qjuy.fsf@firstfloor.org> (raw)
In-Reply-To: <20111216141417.24668.15693.stgit@warthog.procyon.org.uk> (David Howells's message of "Fri, 16 Dec 2011 14:14:17 +0000")
David Howells <dhowells@redhat.com> writes:
>
> There is no need to display val here in the case the expression fails
> since it can only be 0. If this fails, it produces an error like the
> following:
>
> ------------[ cut here ]------------
> kernel BUG at fs/fscache/main.c:109!
> ASSERTION FAILED
It would be nice to display the expression here like an user space
assert. While it can be looked up in the source it would
make quick eyeballing easier.
Probably wouldn't cost too much additional text size?
>
> (e) ASSERTIFCMP(C, X, OP, Y)
>
> This is a combination of ASSERTIF and ASSERTCMP. For example:
>
> ASSERTIFCMP(test_bit(FSCACHE_OP_EXCLUSIVE, &op->flags),
> object->n_exclusive, >, 0);
You probably want a checkpatch rule with those to only allow a few
selected functions like test_bit. Otherwise people will put real side
effects in there.
-Andi
--
ak@linux.intel.com -- Speaking for myself only
next prev parent reply other threads:[~2011-12-16 21:38 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-16 14:13 [PATCH 1/7] Add conditional oopsing with annotation David Howells
2011-12-16 14:14 ` [PATCH 2/7] Make shrink_dcache_for_umount_subtree() use ANNOTATED_BUG() David Howells
2011-12-16 14:14 ` [PATCH 3/7] Add assertion checking macros David Howells
2011-12-16 21:36 ` Andi Kleen [this message]
2011-12-20 15:38 ` David Howells
2011-12-16 14:14 ` [PATCH 4/7] FS-Cache: Use new core assertion macros David Howells
2011-12-16 14:14 ` [PATCH 5/7] CacheFiles: " David Howells
2011-12-16 14:14 ` [PATCH 6/7] AFS: " David Howells
2011-12-16 14:14 ` [PATCH 7/7] RxRPC: " David Howells
2011-12-17 19:15 ` [PATCH 1/7] Add conditional oopsing with annotation Mike Frysinger
2011-12-18 8:02 ` Ingo Molnar
2011-12-20 15:34 ` David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m21us4qjuy.fsf@firstfloor.org \
--to=andi@firstfloor.org \
--cc=dhowells@redhat.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.