Re: [PATCH bpf-next 0/2] Fix verifier test failures in verbose mode

[Eduard Zingerman <eddyz87@gmail.com>]

Gregory Bell <grbell@redhat.com> writes:

> This patch series fixes two issues that cause false failures in the
> BPF verifier test suite when run with verbose output (`-v`).
>
> The following tests fail only when running the test_verifier in
> verbose.
>
> #458/p ld_dw: xor semi-random 64 bit imms, test 5 FAIL
> #494/p precise: test 1 FAIL
> #495/p precise: test 2 FAIL
> #497/p precise: ST zero to stack insn is supported FAIL
> #498/p precise: STX insn causing spi > allocated_stack FAIL
> #501/p scale: scale test 1 FAIL
> #502/p scale: scale test 2 FAIL
>
> This leads to inconsistent results across verbose and
> non-verbose runs.
>
> Patch 1 addresses an issue where the verbose flag (`-v`) unintentionally
> overrides the `opts.log_level`, leading to incorrect contents when checking
> bpf_vlog in tests with `expected_ret == VERBOSE_ACCEPT`. This occurs when
> running verbose with `-v` but not `-vv`
>
> Patch 2 increases the size of the `bpf_vlog[]` buffer to prevent truncation
> of large verifier logs, which was causing failures in several scale and
> 64-bit immediate tests.
>
>
> Before patches:
> ./test_verifier | grep FAIL
> Summary: 790 PASSED, 0 SKIPPED, 0 FAILED

Can reproduce the issue with -v option, the series fixes failures I see.

Tested-by: Eduard Zingerman <eddyz87@gmail.com>