From: Chris Ball <cjb@laptop.org>
To: Juergen Kilb <J.Kilb@phytec.de>
Cc: linux-mmc@vger.kernel.org,
Girish K S <girish.shivananjappa@linaro.org>,
linux-omap@vger.kernel.org
Subject: Re: [PATCH] omap_hsmmc: fix missing parenthesis in pr_info
Date: Sat, 29 Oct 2011 16:04:16 -0400 [thread overview]
Message-ID: <m239ebef9b.fsf@bob.laptop.org> (raw)
In-Reply-To: <1319917151-5626-1-git-send-email-J.Kilb@phytec.de> (Juergen Kilb's message of "Sat, 29 Oct 2011 21:39:11 +0200")
Hi,
On Sat, Oct 29 2011, Juergen Kilb wrote:
> In commit a3c76eb9 (mmc: replace printk with appropriate
> display macro) the opening parenthesis of pr_info was missing.
>
> Signed-off-by: Juergen Kilb <J.Kilb@phytec.de>
> ---
> drivers/mmc/host/omap_hsmmc.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/mmc/host/omap_hsmmc.c b/drivers/mmc/host/omap_hsmmc.c
> index e8ff123..101cd31 100644
> --- a/drivers/mmc/host/omap_hsmmc.c
> +++ b/drivers/mmc/host/omap_hsmmc.c
> @@ -1270,7 +1270,7 @@ static void omap_hsmmc_protect_card(struct omap_hsmmc_host *host)
> }
> } else {
> if (!host->protect_card) {
> - pr_info"%s: cover is open, "
> + pr_info("%s: cover is open, "
> "card is now inaccessible\n",
> mmc_hostname(host->mmc));
> host->protect_card = 1;
Oops. Thank you; I've pushed this to mmc-next now, and will send the
fix to Linus. I've checked for other errors in the original patch.
- Chris.
--
Chris Ball <cjb@laptop.org> <http://printf.net/>
One Laptop Per Child
next prev parent reply other threads:[~2011-10-29 20:04 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-29 19:39 [PATCH] omap_hsmmc: fix missing parenthesis in pr_info Juergen Kilb
2011-10-29 20:04 ` Chris Ball [this message]
2011-11-02 23:59 ` Kevin Hilman
2011-11-03 8:10 ` S, Venkatraman
2011-11-03 10:42 ` Chris Ball
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m239ebef9b.fsf@bob.laptop.org \
--to=cjb@laptop.org \
--cc=J.Kilb@phytec.de \
--cc=girish.shivananjappa@linaro.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.