All of lore.kernel.org
 help / color / mirror / Atom feed
From: Seth Falcon <seth@userprimary.net>
To: Gustaf Hendeby <hendeby@isy.liu.se>
Cc: gitster@pobox.com, git@vger.kernel.org
Subject: Re: [PATCH] send-email, fix breakage in combination with --compose
Date: Mon, 21 Jan 2008 16:05:17 -0800	[thread overview]
Message-ID: <m23asqafnm.fsf@userprimary.net> (raw)
In-Reply-To: <1200945466-21154-2-git-send-email-hendeby@isy.liu.se> (Gustaf Hendeby's message of "Mon\, 21 Jan 2008 20\:57\:46 +0100")

Hi Gustaf,

Gustaf Hendeby <hendeby@isy.liu.se> writes:
> This fixes the subtile bug in git send-email that was introduced into
> git send-email with
>
> commit aa54892f5ada8282643dc7387b33261c7135d784
> send-email: detect invocation errors earlier
>
> causing no patches to be sent out if the --compose flag was used.
>
> Signed-off-by: Gustaf Hendeby <hendeby@isy.liu.se>

I gave this a quick test and it works for me too.  Thanks!

So FWIW,

Acked-by: Seth Falcon <seth@userprimary.net>

-- 
Seth Falcon | seth@userprimary.net | blog: http://userprimary.net/user/

  reply	other threads:[~2008-01-22  0:13 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-01-21 18:30 git-send-email not sending? Seth Falcon
2008-01-21 19:57 ` Test of send-email patch Gustaf Hendeby
2008-01-21 19:57   ` [PATCH] send-email, fix breakage in combination with --compose Gustaf Hendeby
2008-01-22  0:05     ` Seth Falcon [this message]
2008-01-22  3:19     ` Jeff King
2008-01-22  3:23       ` [PATCH 1/3] t9001: add missing && operators Jeff King
2008-01-22  3:25         ` [PATCH 2/3] t9001: enhance fake sendmail test harness Jeff King
2008-01-22  3:29           ` [PATCH 3/3] send-email: test compose functionality Jeff King

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m23asqafnm.fsf@userprimary.net \
    --to=seth@userprimary.net \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=hendeby@isy.liu.se \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.