All of lore.kernel.org
 help / color / mirror / Atom feed
From: Detlev Zundel <dzu@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 3/4] [v3] nand_util: drop trailing all-0xff pages if requested
Date: Fri, 27 May 2011 11:43:04 +0200	[thread overview]
Message-ID: <m24o4gsclz.fsf@ohwell.denx.de> (raw)
In-Reply-To: <0ea56396c07f0fcb92175e7303f4bbda23724a00.1306246651.git.bengardiner@nanometrics.ca> (Ben Gardiner's message of "Tue, 24 May 2011 10:18:36 -0400")

Hi Ben,

> Add a flag to nand_read_skip_bad() such that if true, any trailing
> pages in an eraseblock whose contents are entirely 0xff will be
> dropped.
>
> The implementation is via a new drop_ffs() function which is
> based on the function of the same name from the ubiformat
> utility by Artem Bityutskiy.
>
> This is as-per the reccomendations of the UBI FAQ [1]
>
> Signed-off-by: Ben Gardiner <bengardiner@nanometrics.ca>
> CC: Artem Bityutskiy <dedekind1@gmail.com>
> CC: Detlev Zundel <dzu@denx.de>
>
> [1] http://www.linux-mtd.infradead.org/doc/ubi.html#L_flasher_algo

Looks good -

Acked-by: Detlev Zundel <dzu@denx.de>

Cheers
  Detlev

-- 
Der Kluge tue gleich anfangs, was der Dumme erst am Ende.
                                    --- Baltasar Gracian
--
DENX Software Engineering GmbH,      MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich,  Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-40 Fax: (+49)-8142-66989-80 Email: dzu at denx.de

  reply	other threads:[~2011-05-27  9:43 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-24 14:18 [U-Boot] [PATCH v3 0/4] introduce nand write.trimffs Ben Gardiner
2011-05-24 14:18 ` [U-Boot] [PATCH 1/4] [v3] nand_base: trivial: fix comment read/write comment Ben Gardiner
2011-06-06 21:32   ` Scott Wood
2011-05-24 14:18 ` [U-Boot] [PATCH 2/4] [v3] nand_util: convert nand_write_skip_bad() to flags Ben Gardiner
2011-06-06 21:32   ` Scott Wood
2011-05-24 14:18 ` [U-Boot] [PATCH 3/4] [v3] nand_util: drop trailing all-0xff pages if requested Ben Gardiner
2011-05-27  9:43   ` Detlev Zundel [this message]
2011-06-06 20:58   ` Scott Wood
2011-06-07 13:09     ` Ben Gardiner
2011-06-07 16:34       ` Scott Wood
2011-06-14 20:35         ` [U-Boot] [PATCH v4 0/3] introduce nand write.trimffs Ben Gardiner
2011-06-14 20:35           ` [U-Boot] [PATCH 1/3] [v4] nand_util: treat WITH_YAFFS_OOB as a mode Ben Gardiner
2011-06-14 20:35           ` [U-Boot] [PATCH 2/3] [v4] nand_util: drop trailing all-0xff pages if requested Ben Gardiner
2011-06-14 20:35           ` [U-Boot] [PATCH 3/3] [v4] cmd_nand: add nand write.trimffs command Ben Gardiner
2011-06-15 23:05           ` [U-Boot] [PATCH v4 0/3] introduce nand write.trimffs Scott Wood
2011-05-24 14:18 ` [U-Boot] [PATCH 4/4] [v3] cmd_nand: add nand write.trimffs command Ben Gardiner
2011-05-27  9:41   ` Detlev Zundel
2011-06-06 21:00   ` Scott Wood
2011-06-07 13:09     ` Ben Gardiner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m24o4gsclz.fsf@ohwell.denx.de \
    --to=dzu@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.