From: Andreas Schwab <schwab@linux-m68k.org>
To: Christoph Hellwig <hch@lst.de>
Cc: akpm@linux-foundation.org, linux-kernel@vger.kernel.org,
linux-arch@vger.kernel.org, linux@arm.linux.org.uk,
dhowells@redhat.com, ysato@users.sourceforge.jp,
tony.luck@intel.com, geert@linux-m68k.org, zippel@linux-m68k.org,
gerg@uclinux.org, schwidefsky@de.ibm.com,
heiko.carstens@de.ibm.com, jdike@addtoit.com, tglx@linutronix.de,
mingo@redhat.com, hpa@zytor.com, viro@zeniv.linux.org.uk
Subject: Re: [PATCH 1/6] generic sys_old_select
Date: Mon, 01 Feb 2010 23:40:29 +0100 [thread overview]
Message-ID: <m24om0shpe.fsf@igel.home> (raw)
In-Reply-To: <20100201185506.GA11045@lst.de> (Christoph Hellwig's message of "Mon, 1 Feb 2010 19:55:06 +0100")
Christoph Hellwig <hch@lst.de> writes:
> Index: linux-2.6/fs/compat.c
> ===================================================================
> --- linux-2.6.orig/fs/compat.c 2010-01-12 14:08:16.202003005 +0100
> +++ linux-2.6/fs/compat.c 2010-01-29 23:35:20.187003404 +0100
> @@ -1795,6 +1795,24 @@ asmlinkage long compat_sys_select(int n,
> return ret;
> }
>
> +struct compat_sel_arg_struct {
> + compat_ulong_t n;
> + compat_ulong_t inp;
> + compat_ulong_t outp;
> + compat_ulong_t exp;
> + compat_ulong_t tvp;
> +};
Shouldn't the last four be compat_uptr_t?
Andreas.
--
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
"And now for something completely different."
next prev parent reply other threads:[~2010-02-01 22:40 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-01 18:55 [PATCH 1/6] generic sys_old_select Christoph Hellwig
2010-02-01 21:58 ` H. Peter Anvin
2010-02-01 22:40 ` Andreas Schwab [this message]
2010-02-02 8:34 ` Christoph Hellwig
2010-02-01 23:37 ` Russell King
2010-02-02 1:03 ` Greg Ungerer
2010-02-02 8:55 ` Dave Young
2010-02-08 14:05 ` David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m24om0shpe.fsf@igel.home \
--to=schwab@linux-m68k.org \
--cc=akpm@linux-foundation.org \
--cc=dhowells@redhat.com \
--cc=geert@linux-m68k.org \
--cc=gerg@uclinux.org \
--cc=hch@lst.de \
--cc=heiko.carstens@de.ibm.com \
--cc=hpa@zytor.com \
--cc=jdike@addtoit.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=mingo@redhat.com \
--cc=schwidefsky@de.ibm.com \
--cc=tglx@linutronix.de \
--cc=tony.luck@intel.com \
--cc=viro@zeniv.linux.org.uk \
--cc=ysato@users.sourceforge.jp \
--cc=zippel@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.