From: Andreas Schwab <schwab@linux-m68k.org>
To: Christoph Hellwig <hch@lst.de>
Cc: Roland McGrath <roland@redhat.com>, linux-m68k@vger.kernel.org
Subject: Re: m68k ptrace code
Date: Wed, 05 Aug 2009 23:12:32 +0200 [thread overview]
Message-ID: <m24osmhsn3.fsf@igel.home> (raw)
In-Reply-To: <20090805152749.GE6476@lst.de> (Christoph Hellwig's message of "Wed, 5 Aug 2009 17:27:49 +0200")
Christoph Hellwig <hch@lst.de> writes:
> Hi Andreas,
>
> On Mon, May 11, 2009 at 11:32:05AM +0200, Andreas Schwab wrote:
>> > Looks good to me, except you also want to nix PTRACE_KILL from your switch
>> > so the generic code handles it. Same goes for {PEEK,POKE}{DATA,TEXT} too.
>> > Also note that you have to define a PTRACE_SINGLEBLOCK value in
>> > asm/ptrace.h (new request code in your ptrace syscall ABI) to make
>> > user_enable_block_step() get used by anything.
>>
>> Thanks for your comments. I have made these changes and verified with
>> the ptrace testsuite that the singleblock request works correctly.
>> There are a few failures in the testsuite, which I haven't analyzed yet,
>> but none are regressions.
>
> Any reason why this has never been commited?
Looks like Geert has a big backlog.
Andreas.
--
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
"And now for something completely different."
prev parent reply other threads:[~2009-08-05 21:12 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20090427191230.GA1657@lst.de>
2009-04-27 19:14 ` m68k ptrace code Christoph Hellwig
2009-05-10 19:32 ` Andreas Schwab
2009-05-10 23:18 ` Roland McGrath
2009-05-11 9:32 ` Andreas Schwab
2009-08-05 15:27 ` Christoph Hellwig
2009-08-05 21:12 ` Andreas Schwab [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m24osmhsn3.fsf@igel.home \
--to=schwab@linux-m68k.org \
--cc=hch@lst.de \
--cc=linux-m68k@vger.kernel.org \
--cc=roland@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.