All of lore.kernel.org
 help / color / mirror / Atom feed
From: Detlev Zundel <dzu@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] [PATCH 7/8] ppc4xx: Remove superfluous dram_init() call or replace it by initdram()
Date: Wed, 04 Jun 2008 12:45:09 +0200	[thread overview]
Message-ID: <m24p89bhsa.fsf@ohwell.denx.de> (raw)
In-Reply-To: <1212433356-27144-7-git-send-email-sr@denx.de> (Stefan Roese's message of "Mon, 2 Jun 2008 21:02:35 +0200")

Hi Stefan,

> Historically the 405 U-Boot port had a dram_init() call in early init
> stage. This function was still called from start.S and most of the time
> coded in assembler. This is not needed anymore (since a long time) and
> boards should implement the common initdram() function in C instead.
>
> This patch now removed the dram_init() call from start.S and removes the
> empty implementations that are scattered through most of the 405 board
> ports. Some older board ports really implement this dram_init() though.
> These are:
>
> csb272
> csb472
> ERIC
> EXBITGEN
> W7OLMC
> W7OLMG
>
> I changed those boards to call this assembler dram_init() function now
> from their board specific initdram() instead. This *should* work, but please
> test again on those platforms. And it is perhaps a good idea that those
> boards use some common 405 SDRAM initialization code from cpu/ppc4xx at
> some time. So further patches welcome here.
>
> Signed-off-by: Stefan Roese <sr@denx.de>

I put those maintainers that I could find on CC to inform them.  You
could have done the same ;)

ERIC and W70LMC, W70LMG don't have maintainer entries...

Cheers
  Detlev

-- 
You see, the best way to solve a problem is to rigorously define it in
terms of other people's problems, and then run away quickly.
                                          -- Roland McGrath
--
DENX Software Engineering GmbH,      MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich,  Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-40 Fax: (+49)-8142-66989-80 Email: dzu at denx.de

  reply	other threads:[~2008-06-04 10:45 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-06-02 19:02 [U-Boot-Users] [PATCH 1/8] ppc4xx: Consolidate 405 and 440 NAND booting code in start.S Stefan Roese
2008-06-02 19:02 ` [U-Boot-Users] [PATCH 2/8] ppc4xx: Consolidate PPC4xx SDRAM/DDR/DDR2 defines, part1 Stefan Roese
2008-06-02 19:02 ` [U-Boot-Users] [PATCH 3/8] ppc4xx: Consolidate PPC4xx SDRAM/DDR/DDR2 defines, part2 Stefan Roese
2008-06-05  1:10   ` Jerry Van Baren
2008-06-05  4:16     ` Stefan Roese
2008-06-02 19:02 ` [U-Boot-Users] [PATCH 4/8] ppc4xx: Change Kilauea to use the common DDR2 init function Stefan Roese
2008-06-02 19:02 ` [U-Boot-Users] [PATCH 5/8] ppc4xx: Fix common ECC generation code for 440GP style platforms Stefan Roese
2008-06-02 19:02 ` [U-Boot-Users] [PATCH 6/8] ppc4xx: Use new 4xx SDRAM controller enable defines in common ECC code Stefan Roese
2008-06-02 19:02 ` [U-Boot-Users] [PATCH 7/8] ppc4xx: Remove superfluous dram_init() call or replace it by initdram() Stefan Roese
2008-06-04 10:45   ` Detlev Zundel [this message]
2008-06-04 11:16     ` Stefan Roese
2008-06-02 19:02 ` [U-Boot-Users] [PATCH 8/8] ppc4xx: Remove implementations of testdram() Stefan Roese

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m24p89bhsa.fsf@ohwell.denx.de \
    --to=dzu@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.