All of lore.kernel.org
 help / color / mirror / Atom feed
From: Yoshinori Sato <ysato@users.sourceforge.jp>
To: kernel-janitors@vger.kernel.org
Subject: [KJ] Re: [Patch] replace MODULE_PARM innet/ne-h8300.c
Date: Fri, 13 Jan 2006 08:45:27 +0000	[thread overview]
Message-ID: <m24q48349k.wl%ysato@users.sourceforge.jp> (raw)

[-- Attachment #1: Type: text/plain, Size: 1497 bytes --]

At Tue, 10 Jan 2006 14:06:22 +0100,
Eric Sesterhenn / snakebyte wrote:
> 
> hi,
> 
> this patch replaces the MODULE_PARM usage in uli526x.c
> with module_param.
> 

I am fine.
I delete it incidentally because do not use "bad".

Signed-off-by: Eric Sesterhenn <snakebyte@gmx.de>
Signed-off-by: Yoshinori Sato <ysato@users.sourceforge.jp>

===File ~/ne-h8300.diff=====================================
diff --git a/drivers/net/ne-h8300.c b/drivers/net/ne-h8300.c
index 8f40368..ccd0c0f 100644
--- a/drivers/net/ne-h8300.c
+++ b/drivers/net/ne-h8300.c
@@ -598,11 +598,9 @@ retry:
 static struct net_device *dev_ne[MAX_NE_CARDS];
 static int io[MAX_NE_CARDS];
 static int irq[MAX_NE_CARDS];
-static int bad[MAX_NE_CARDS];	/* 0xbad = bad sig or no reset ack */
 
-MODULE_PARM(io, "1-" __MODULE_STRING(MAX_NE_CARDS) "i");
-MODULE_PARM(irq, "1-" __MODULE_STRING(MAX_NE_CARDS) "i");
-MODULE_PARM(bad, "1-" __MODULE_STRING(MAX_NE_CARDS) "i");
+module_param_array(io, int, NULL, 0);
+module_param_array(irq, int, NULL, 0);
 MODULE_PARM_DESC(io, "I/O base address(es)");
 MODULE_PARM_DESC(irq, "IRQ number(s)");
 MODULE_DESCRIPTION("H8/300 NE2000 Ethernet driver");
@@ -624,7 +622,6 @@ int init_module(void)
 			break;
 		if (io[this_dev]) {
 			dev->irq = irq[this_dev];
-			dev->mem_end = bad[this_dev];
 			dev->base_addr = io[this_dev];
 		} else {
 			dev->base_addr = h8300_ne_base[this_dev];
============================================================

-- 
Yoshinori Sato
<ysato@users.sourceforge.jp>

[-- Attachment #2: Type: text/plain, Size: 168 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
https://lists.osdl.org/mailman/listinfo/kernel-janitors

                 reply	other threads:[~2006-01-13  8:45 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m24q48349k.wl%ysato@users.sourceforge.jp \
    --to=ysato@users.sourceforge.jp \
    --cc=kernel-janitors@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.