[Qemu-devel] Re: [PATCH 09/18] block/qcow2.c: fix warnings with _FORTIFY_SOURCE

[Andreas Schwab <schwab@linux-m68k.org>]

"Kirill A. Shutemov" <kirill@shutemov.name> writes:

>      lseek(fd, s->refcount_block_offset, SEEK_SET);
> -    write(fd, s->refcount_block, ref_clusters * s->cluster_size);
> +    ret = write(fd, s->refcount_block, ref_clusters * s->cluster_size);
> +    if (ret != s->cluster_size) {
> +        ret = -errno;
> +        goto exit;
> +    }

If you have a short write you'll get an undefined errno.

Andreas.

-- 
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."