Git branches with Gentoo fixes

Git branches with Gentoo fixes

[Diego 'Flameeyes' Pettenò]

[-- Attachment #1.1: Type: text/plain, Size: 626 bytes --]


Hi all,

Since I have just had to fix (again) an --as-needed issues on alsa-tools
on the Gentoo ebuild, I've decided to clone the git repo and see to try
pushing (again, I'm sure I tried before) the Gentoo-specific patches.

You can find two git branches for alsa-tools and alsa-utils at these
addresses:

git://git.flameeyes.eu/others/alsa/alsa-tools.git
git://git.flameeyes.eu/others/alsa/alsa-utils.git

For the patches coming from users, the proper Author setting was done so
that they are reported coming from the correct contributor.

HTH,
-- 
Diego "Flameeyes" Pettenò
http://blog.flameeyes.eu/


[-- Attachment #1.2: Type: application/pgp-signature, Size: 196 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel

Re: Git branches with Gentoo fixes

[Diego 'Flameeyes' Pettenò]

[-- Attachment #1.1: Type: text/plain, Size: 305 bytes --]

flameeyes@gmail.com (Diego 'Flameeyes' Pettenò) writes:

> git://git.flameeyes.eu/others/alsa/alsa-tools.git
> git://git.flameeyes.eu/others/alsa/alsa-utils.git

Add to this also

git://git.flameeyes.eu/others/alsa/alsa-plugins.git


-- 
Diego "Flameeyes" Pettenò
http://blog.flameeyes.eu/

[-- Attachment #1.2: Type: application/pgp-signature, Size: 196 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel

Re: Git branches with Gentoo fixes

[Travis Place]

On Thursday 13 November 2008 10:28:22 am Diego 'Flameeyes' Pettenò wrote:
> flameeyes@gmail.com (Diego 'Flameeyes' Pettenò) writes:
> > git://git.flameeyes.eu/others/alsa/alsa-tools.git
> > git://git.flameeyes.eu/others/alsa/alsa-utils.git
>
> Add to this also
>
> git://git.flameeyes.eu/others/alsa/alsa-plugins.git

Are the -9999 ebuilds in portage still pointing to the HG repo ?

Travis.
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel

Re: Git branches with Gentoo fixes

[Diego 'Flameeyes' Pettenò]

[-- Attachment #1.1: Type: text/plain, Size: 527 bytes --]

Travis Place <wishie@wishie.net> writes:

> Are the -9999 ebuilds in portage still pointing to the HG repo ?

There used to be one for alsa-driver, since I decided some time ago not
to follow ALSA in Gentoo (for difference in view with the kernel
developers and the docs team) I have sincerely no clue what the destiny
of the -9999 ebuild has been, so I have to check...

... it seems so. I'll let it be known to who does maintain ALSA nowadays
of that.

-- 
Diego "Flameeyes" Pettenò
http://blog.flameeyes.eu/

[-- Attachment #1.2: Type: application/pgp-signature, Size: 196 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel

Re: Git branches with Gentoo fixes

[Takashi Iwai]

At Thu, 13 Nov 2008 01:28:22 +0100,
Diego 'Flameeyes' Pettenò wrote:
> 
> flameeyes@gmail.com (Diego 'Flameeyes' Pettenò) writes:
> 
> > git://git.flameeyes.eu/others/alsa/alsa-tools.git
> > git://git.flameeyes.eu/others/alsa/alsa-utils.git
> 
> Add to this also
> 
> git://git.flameeyes.eu/others/alsa/alsa-plugins.git

Could you post the summary of your changes, at least?


thanks,

Takashi

Re: Git branches with Gentoo fixes

[Takashi Iwai]

At Thu, 13 Nov 2008 08:44:39 +0100,
I wrote:
> 
> At Thu, 13 Nov 2008 01:28:22 +0100,
> Diego 'Flameeyes' Pettenò wrote:
> > 
> > flameeyes@gmail.com (Diego 'Flameeyes' Pettenò) writes:
> > 
> > > git://git.flameeyes.eu/others/alsa/alsa-tools.git
> > > git://git.flameeyes.eu/others/alsa/alsa-utils.git
> > 
> > Add to this also
> > 
> > git://git.flameeyes.eu/others/alsa/alsa-plugins.git
> 
> Could you post the summary of your changes, at least?

Also, please put the branch name to pull in the same line.
I guess it's master, but the recent git requires the pulling branch
explicitly.

thanks,

Takashi

Re: Git branches with Gentoo fixes

[Takashi Iwai]

At Thu, 13 Nov 2008 01:28:22 +0100,
Diego 'Flameeyes' Pettenò wrote:
>
> flameeyes@gmail.com (Diego 'Flameeyes' Pettenò) writes:
> 
> > git://git.flameeyes.eu/others/alsa/alsa-tools.git
> > git://git.flameeyes.eu/others/alsa/alsa-utils.git
> 
> Add to this also
> 
> git://git.flameeyes.eu/others/alsa/alsa-plugins.git

Use rather AC_ENABLE() instead of AC_WITH().
It's more intuitive.


BTW, we'd like also a sign-off in each commit by the committer for
non-kernel repos (although not strictly needed).
Don't forget to add --sign option at each time.


thanks,

Takashi

Re: Git branches with Gentoo fixes

[Diego 'Flameeyes' Pettenò]

[-- Attachment #1.1: Type: text/plain, Size: 699 bytes --]

Takashi Iwai <tiwai@suse.de> writes:

> Use rather AC_ENABLE() instead of AC_WITH().
> It's more intuitive.

Okay, I actually had ENABLE in the original patch I made about two years
ago, but switched to WITH since speex was using that.

> BTW, we'd like also a sign-off in each commit by the committer for
> non-kernel repos (although not strictly needed).
> Don't forget to add --sign option at each time.

Done now, I've rewritten history for the repositories and now they all
should be fine.

I also further fixed the hdspmixer issue in the proper way, I was tired
for sure for not noticing the hack I've been using.

-- 
Diego "Flameeyes" Pettenò
http://blog.flameeyes.eu/

[-- Attachment #1.2: Type: application/pgp-signature, Size: 196 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel

Re: Git branches with Gentoo fixes

[Takashi Iwai]

At Thu, 13 Nov 2008 13:24:39 +0100,
Diego 'Flameeyes' Pettenò wrote:
> 
> Takashi Iwai <tiwai@suse.de> writes:
> 
> > Use rather AC_ENABLE() instead of AC_WITH().
> > It's more intuitive.
> 
> Okay, I actually had ENABLE in the original patch I made about two years
> ago, but switched to WITH since speex was using that.
> 
> > BTW, we'd like also a sign-off in each commit by the committer for
> > non-kernel repos (although not strictly needed).
> > Don't forget to add --sign option at each time.
> 
> Done now, I've rewritten history for the repositories and now they all
> should be fine.
> 
> I also further fixed the hdspmixer issue in the proper way, I was tired
> for sure for not noticing the hack I've been using.

Thanks for fixing.  If finished, please post again with summaries.


Takashi

Re: Git branches with Gentoo fixes

[Diego 'Flameeyes' Pettenò]

[-- Attachment #1.1: Type: text/plain, Size: 955 bytes --]

Takashi Iwai <tiwai@suse.de> writes:

> Thanks for fixing.  If finished, please post again with summaries.

git://git.flameeyes.eu/others/alsa/alsa-utils.git master

- Fix building speaker-test when NLS is enabled, locale.h was not being
  included;
- Fix alsaconf use of dialog by redirecting to a new descriptor, or
  "snd-***" was tried for loading in case of errors;
- Replace modules-update with update-modules in alsaconf, since Gentoo
  also use the same command name as Debian.

git://git.flameeyes.eu/others/alsa/alsa-tools.git master

- Fix building with --as-needed ld option, by not passing library names
  on LDFLAGS variables;

git://git.flameeyes.eu/others/alsa/alsa-plugins.git master

- Add --disable options for jack, pulseaudio, libsamplerate and
  libavcodec based plugins, so that they can be disabled even if the
  software is found in the system;

-- 
Diego "Flameeyes" Pettenò
http://blog.flameeyes.eu/

[-- Attachment #1.2: Type: application/pgp-signature, Size: 196 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel

Re: Git branches with Gentoo fixes

[Takashi Iwai]

At Thu, 13 Nov 2008 14:21:12 +0100,
Diego 'Flameeyes' Pettenò wrote:
> 
> Takashi Iwai <tiwai@suse.de> writes:
> 
> > Thanks for fixing.  If finished, please post again with summaries.
> 
> git://git.flameeyes.eu/others/alsa/alsa-utils.git master
> 
> - Fix building speaker-test when NLS is enabled, locale.h was not being
>   included;
> - Fix alsaconf use of dialog by redirecting to a new descriptor, or
>   "snd-***" was tried for loading in case of errors;
> - Replace modules-update with update-modules in alsaconf, since Gentoo
>   also use the same command name as Debian.
> 
> git://git.flameeyes.eu/others/alsa/alsa-tools.git master
> 
> - Fix building with --as-needed ld option, by not passing library names
>   on LDFLAGS variables;
> 
> git://git.flameeyes.eu/others/alsa/alsa-plugins.git master
> 
> - Add --disable options for jack, pulseaudio, libsamplerate and
>   libavcodec based plugins, so that they can be disabled even if the
>   software is found in the system;

Thanks, all pulled in, pushed out now.

BTW, you can create summaries more easily via git-shortlog:

	% git shortlog origin/master..HEAD


Takashi

Re: Git branches with Gentoo fixes

[Takashi Iwai]

At Thu, 13 Nov 2008 01:14:51 +0100,
Diego 'Flameeyes' Pettenò wrote:
> 
> Hi all,
> 
> Since I have just had to fix (again) an --as-needed issues on alsa-tools
> on the Gentoo ebuild, I've decided to clone the git repo and see to try
> pushing (again, I'm sure I tried before) the Gentoo-specific patches.
> 
> You can find two git branches for alsa-tools and alsa-utils at these
> addresses:
> 
> git://git.flameeyes.eu/others/alsa/alsa-tools.git
> git://git.flameeyes.eu/others/alsa/alsa-utils.git
> 
> For the patches coming from users, the proper Author setting was done so
> that they are reported coming from the correct contributor.

In commit de0aea763c5113f2373fc1cf6034b018d255bd94,

> diff --git a/alsaconf/alsaconf.in b/alsaconf/alsaconf.in
> index 806ddb6..56f2a4b 100644
> --- a/alsaconf/alsaconf.in
> +++ b/alsaconf/alsaconf.in
> @@ -908,13 +908,8 @@ BEGIN { in_sound=0; }
>  
>      farewell
>      clear
> -    if [ "$distribution" = "gentoo" ]; then
> -      xecho "Running modules-update..."
> -      modules-update
> -    elif [ "$distribution" = "debian" ]; then
> -      xecho "Running update-modules..."
> -      update-modules
> -    fi
> +    xecho "Running update-modules..."
> +    update-modules
>      if [ -x $rcalsasound ] ; then

You unconditionally call update-modules, but this doesn't exist in
all distros, but this is wrong.  The world isn't ruled by only debian
and gentoo :)

Check the availability before calling it.

Other changes in alsa-utils look OK.


thanks,

Takashi

Re: Git branches with Gentoo fixes

[Takashi Iwai]

At Thu, 13 Nov 2008 01:14:51 +0100,
Diego 'Flameeyes' Pettenò wrote:
> 
> 
> git://git.flameeyes.eu/others/alsa/alsa-tools.git
> 
...
> diff --git a/hdspmixer/src/Makefile.am b/hdspmixer/src/Makefile.am
> index 9bb83af..1b898bc 100644
> --- a/hdspmixer/src/Makefile.am
> +++ b/hdspmixer/src/Makefile.am
> @@ -56,3 +56,5 @@ hdspmixer_SOURCES = \
>  	pixmaps.cxx \
>  	pixmaps.h \
> 	defines.h
> +
> +hdspmixer_LDADD = -lfltk

Looks like a wrong fix.


thanks,

Takashi