From: Juan Quintela <quintela@mandrakesoft.com>
To: Eduardo Pereira Habkost <ehabkost@conectiva.com.br>
Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH] Fixes supermount Oopses when mount options are not given
Date: 01 Feb 2002 18:41:18 +0100 [thread overview]
Message-ID: <m2665h3xs1.fsf@localhost.mandrakesoft.com> (raw)
In-Reply-To: <20020201174507.GA1860@rayden.distro.conectiva>
In-Reply-To: <20020201174507.GA1860@rayden.distro.conectiva>
>>>>> "eduardo" == Eduardo Pereira Habkost <ehabkost@conectiva.com.br> writes:
eduardo> The following patch fixes two Oopses on supermount.
eduardo> The first one happens when the dev= option is not given to supermount, iput()
eduardo> is called after dput(), but iput() is already called by dput().
eduardo> The other one happens when the fs= option is not given. subfs_mount() doesn't
eduardo> check if sbi->s_type is NULL.
eduardo> Regards,
eduardo> --
eduardo> Eduardo Pereira Habkost <ehabkost@conectiva.com.br>
eduardo> http://www.boto.f2s.com
eduardo> 04BE D2EF 5A56 E446 D424 4785 71A4 49EB AC35 9568
eduardo> ----
eduardo> # ------------------------
eduardo> diff -urN kernel-2.4.17/linux/fs/supermount/super.c kernel-2.4.17-supermountok/linux/fs/supermount/super.c
eduardo> --- kernel-2.4.17/linux/fs/supermount/super.c Fri Feb 1 14:10:39 2002
eduardo> +++ kernel-2.4.17-supermountok/linux/fs/supermount/super.c Fri Feb 1 11:56:36 2002
eduardo> @@ -276,7 +276,7 @@
eduardo> char **type = types_in_order;
eduardo> - if (strcmp(sbi->s_type, "auto"))
eduardo> + if (sbi->s_type && strcmp(sbi->s_type, "auto"))
eduardo> return subfs_real_mount2 (sb, sbi->s_type);
eduardo> while (*type && retval) {
eduardo> diff -urN kernel-2.4.17/linux/fs/supermount/super_operations.c kernel-2.4.17-supermountok/linux/fs/supermount/super_operations.c
eduardo> --- kernel-2.4.17/linux/fs/supermount/super_operations.c Fri Feb 1 14:10:39 2002
eduardo> +++ kernel-2.4.17-supermountok/linux/fs/supermount/super_operations.c Fri Feb 1 11:56:36 2002
eduardo> @@ -279,10 +279,12 @@
eduardo> return s;
eduardo> fail_parsing:
s-> s_dev = 0;
eduardo> - dput (root);
eduardo> fail_allocating_root:
eduardo> supermount_debug ("get root dentry failed");
eduardo> - iput (root_inode);
eduardo> + if(root)
eduardo> + dput (root);
eduardo> + else
eduardo> + iput (root_inode);
eduardo> free_sbi (sbi);
eduardo> fail_no_memory:
eduardo> return NULL;
THanks a lot.
Later, Juan.
--
In theory, practice and theory are the same, but in practice they
are different -- Larry McVoy
prev parent reply other threads:[~2002-02-01 17:51 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-02-01 17:45 [PATCH] Fixes supermount Oopses when mount options are not given Eduardo Pereira Habkost
2002-02-01 17:41 ` Juan Quintela [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2665h3xs1.fsf@localhost.mandrakesoft.com \
--to=quintela@mandrakesoft.com \
--cc=ehabkost@conectiva.com.br \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.