From mboxrd@z Thu Jan 1 00:00:00 1970 From: khilman@baylibre.com (Kevin Hilman) Date: Wed, 18 Jan 2017 14:18:39 -0800 Subject: [PATCH 1/2] ARM64: dts: meson-gxm: Add R-Box Pro In-Reply-To: <63fbfc68-917f-68b2-9e7d-e1834e2841d3@suse.de> ("Andreas =?utf-8?Q?F=C3=A4rber=22's?= message of "Tue, 17 Jan 2017 04:35:10 +0100") References: <20170117030611.23827-1-afaerber@suse.de> <20170117030611.23827-2-afaerber@suse.de> <63fbfc68-917f-68b2-9e7d-e1834e2841d3@suse.de> Message-ID: To: linus-amlogic@lists.infradead.org List-Id: linus-amlogic.lists.infradead.org Andreas F?rber writes: > Am 17.01.2017 um 04:06 schrieb Andreas F?rber: >> + leds { >> + compatible = "gpio-leds"; >> + >> + blue { >> + label = "rbox-pro:blue:on"; >> + gpios = <&gpio_ao GPIOAO_9 GPIO_ACTIVE_HIGH>; >> + default-state = "on"; >> + }; >> + >> + red { >> + label = "rbox-pro:red:standby"; >> + gpios = <&gpio GPIODV_28 GPIO_ACTIVE_HIGH>; >> + default-state = "off"; >> + retain-state-suspended; >> + panic-indicator; >> + }; >> + }; > > The original property names for these two were led and red. If anyone > has better label names than the above, please speak up. Ditto for > vega-s95. On the odroidc2 it's called alive but uses heartbeat there. > > The vendor device tree had a third "mcu" GPIO in the sysled node, > GPIOAO_6, which leads to immediate power-off. I tried using > "gpio-poweroff" to configure this pin, but that driver fails to > initialize because some pm callback is already registered - I assume > from psci, which apparently succeeds to power-off the system, too. For > comparison, the S905 based Vega S95 Telos has no such mcu property. Any > thoughts? > > Also, any ideas how best to switch from blue to red for suspend? Add > pinctrl properties above? systemd service doing echo from userspace? I > assume in Android the Amlogic sysled driver handles all that logic - > didn't find any suspend equivalent to gpio-poweroff. in leds-gpio, when retain-state-suspended is not set, the LED is automatically set to value 0. I wonder if leds-gpio should grow support to make the suspend value configurable? Or a property like "toggle-state-suspended" ? Kevin From mboxrd@z Thu Jan 1 00:00:00 1970 From: khilman@baylibre.com (Kevin Hilman) Date: Wed, 18 Jan 2017 14:18:39 -0800 Subject: [PATCH 1/2] ARM64: dts: meson-gxm: Add R-Box Pro In-Reply-To: <63fbfc68-917f-68b2-9e7d-e1834e2841d3@suse.de> ("Andreas =?utf-8?Q?F=C3=A4rber=22's?= message of "Tue, 17 Jan 2017 04:35:10 +0100") References: <20170117030611.23827-1-afaerber@suse.de> <20170117030611.23827-2-afaerber@suse.de> <63fbfc68-917f-68b2-9e7d-e1834e2841d3@suse.de> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Andreas F?rber writes: > Am 17.01.2017 um 04:06 schrieb Andreas F?rber: >> + leds { >> + compatible = "gpio-leds"; >> + >> + blue { >> + label = "rbox-pro:blue:on"; >> + gpios = <&gpio_ao GPIOAO_9 GPIO_ACTIVE_HIGH>; >> + default-state = "on"; >> + }; >> + >> + red { >> + label = "rbox-pro:red:standby"; >> + gpios = <&gpio GPIODV_28 GPIO_ACTIVE_HIGH>; >> + default-state = "off"; >> + retain-state-suspended; >> + panic-indicator; >> + }; >> + }; > > The original property names for these two were led and red. If anyone > has better label names than the above, please speak up. Ditto for > vega-s95. On the odroidc2 it's called alive but uses heartbeat there. > > The vendor device tree had a third "mcu" GPIO in the sysled node, > GPIOAO_6, which leads to immediate power-off. I tried using > "gpio-poweroff" to configure this pin, but that driver fails to > initialize because some pm callback is already registered - I assume > from psci, which apparently succeeds to power-off the system, too. For > comparison, the S905 based Vega S95 Telos has no such mcu property. Any > thoughts? > > Also, any ideas how best to switch from blue to red for suspend? Add > pinctrl properties above? systemd service doing echo from userspace? I > assume in Android the Amlogic sysled driver handles all that logic - > didn't find any suspend equivalent to gpio-poweroff. in leds-gpio, when retain-state-suspended is not set, the LED is automatically set to value 0. I wonder if leds-gpio should grow support to make the suspend value configurable? Or a property like "toggle-state-suspended" ? Kevin From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kevin Hilman Subject: Re: [PATCH 1/2] ARM64: dts: meson-gxm: Add R-Box Pro Date: Wed, 18 Jan 2017 14:18:39 -0800 Message-ID: References: <20170117030611.23827-1-afaerber@suse.de> <20170117030611.23827-2-afaerber@suse.de> <63fbfc68-917f-68b2-9e7d-e1834e2841d3@suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <63fbfc68-917f-68b2-9e7d-e1834e2841d3@suse.de> ("Andreas =?utf-8?Q?F=C3=A4rber=22's?= message of "Tue, 17 Jan 2017 04:35:10 +0100") List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Andreas =?utf-8?Q?F=C3=A4rber?= Cc: Mark Rutland , devicetree@vger.kernel.org, Catalin Marinas , Will Deacon , linux-kernel@vger.kernel.org, Rob Herring , Carlo Caione , linux-amlogic@lists.infradead.org, linux-arm-kernel@lists.infradead.org List-Id: devicetree@vger.kernel.org QW5kcmVhcyBGw6RyYmVyIDxhZmFlcmJlckBzdXNlLmRlPiB3cml0ZXM6Cgo+IEFtIDE3LjAxLjIw MTcgdW0gMDQ6MDYgc2NocmllYiBBbmRyZWFzIEbDpHJiZXI6Cj4+ICsJbGVkcyB7Cj4+ICsJCWNv bXBhdGlibGUgPSAiZ3Bpby1sZWRzIjsKPj4gKwo+PiArCQlibHVlIHsKPj4gKwkJCWxhYmVsID0g InJib3gtcHJvOmJsdWU6b24iOwo+PiArCQkJZ3Bpb3MgPSA8JmdwaW9fYW8gR1BJT0FPXzkgR1BJ T19BQ1RJVkVfSElHSD47Cj4+ICsJCQlkZWZhdWx0LXN0YXRlID0gIm9uIjsKPj4gKwkJfTsKPj4g Kwo+PiArCQlyZWQgewo+PiArCQkJbGFiZWwgPSAicmJveC1wcm86cmVkOnN0YW5kYnkiOwo+PiAr CQkJZ3Bpb3MgPSA8JmdwaW8gR1BJT0RWXzI4IEdQSU9fQUNUSVZFX0hJR0g+Owo+PiArCQkJZGVm YXVsdC1zdGF0ZSA9ICJvZmYiOwo+PiArCQkJcmV0YWluLXN0YXRlLXN1c3BlbmRlZDsKPj4gKwkJ CXBhbmljLWluZGljYXRvcjsKPj4gKwkJfTsKPj4gKwl9Owo+Cj4gVGhlIG9yaWdpbmFsIHByb3Bl cnR5IG5hbWVzIGZvciB0aGVzZSB0d28gd2VyZSBsZWQgYW5kIHJlZC4gSWYgYW55b25lCj4gaGFz IGJldHRlciBsYWJlbCBuYW1lcyB0aGFuIHRoZSBhYm92ZSwgcGxlYXNlIHNwZWFrIHVwLiBEaXR0 byBmb3IKPiB2ZWdhLXM5NS4gT24gdGhlIG9kcm9pZGMyIGl0J3MgY2FsbGVkIGFsaXZlIGJ1dCB1 c2VzIGhlYXJ0YmVhdCB0aGVyZS4KPgo+IFRoZSB2ZW5kb3IgZGV2aWNlIHRyZWUgaGFkIGEgdGhp cmQgIm1jdSIgR1BJTyBpbiB0aGUgc3lzbGVkIG5vZGUsCj4gR1BJT0FPXzYsIHdoaWNoIGxlYWRz IHRvIGltbWVkaWF0ZSBwb3dlci1vZmYuIEkgdHJpZWQgdXNpbmcKPiAiZ3Bpby1wb3dlcm9mZiIg dG8gY29uZmlndXJlIHRoaXMgcGluLCBidXQgdGhhdCBkcml2ZXIgZmFpbHMgdG8KPiBpbml0aWFs aXplIGJlY2F1c2Ugc29tZSBwbSBjYWxsYmFjayBpcyBhbHJlYWR5IHJlZ2lzdGVyZWQgLSBJIGFz c3VtZQo+IGZyb20gcHNjaSwgd2hpY2ggYXBwYXJlbnRseSBzdWNjZWVkcyB0byBwb3dlci1vZmYg dGhlIHN5c3RlbSwgdG9vLiBGb3IKPiBjb21wYXJpc29uLCB0aGUgUzkwNSBiYXNlZCBWZWdhIFM5 NSBUZWxvcyBoYXMgbm8gc3VjaCBtY3UgcHJvcGVydHkuIEFueQo+IHRob3VnaHRzPwo+Cj4gQWxz bywgYW55IGlkZWFzIGhvdyBiZXN0IHRvIHN3aXRjaCBmcm9tIGJsdWUgdG8gcmVkIGZvciBzdXNw ZW5kPyBBZGQKPiBwaW5jdHJsIHByb3BlcnRpZXMgYWJvdmU/IHN5c3RlbWQgc2VydmljZSBkb2lu ZyBlY2hvIGZyb20gdXNlcnNwYWNlPyBJCj4gYXNzdW1lIGluIEFuZHJvaWQgdGhlIEFtbG9naWMg c3lzbGVkIGRyaXZlciBoYW5kbGVzIGFsbCB0aGF0IGxvZ2ljIC0KPiBkaWRuJ3QgZmluZCBhbnkg c3VzcGVuZCBlcXVpdmFsZW50IHRvIGdwaW8tcG93ZXJvZmYuCgppbiBsZWRzLWdwaW8sIHdoZW4g cmV0YWluLXN0YXRlLXN1c3BlbmRlZCBpcyBub3Qgc2V0LCB0aGUgTEVEIGlzCmF1dG9tYXRpY2Fs bHkgc2V0IHRvIHZhbHVlIDAuICBJIHdvbmRlciBpZiBsZWRzLWdwaW8gc2hvdWxkIGdyb3cgc3Vw cG9ydAp0byBtYWtlIHRoZSBzdXNwZW5kIHZhbHVlIGNvbmZpZ3VyYWJsZT8gIE9yIGEgcHJvcGVy dHkgbGlrZQoidG9nZ2xlLXN0YXRlLXN1c3BlbmRlZCIgPwoKS2V2aW4KCgpfX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51eC1hcm0ta2VybmVsIG1haWxp bmcgbGlzdApsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3Rz LmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1hcm0ta2VybmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751109AbdARWUO (ORCPT ); Wed, 18 Jan 2017 17:20:14 -0500 Received: from mail-pg0-f44.google.com ([74.125.83.44]:35581 "EHLO mail-pg0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750965AbdARWUM (ORCPT ); Wed, 18 Jan 2017 17:20:12 -0500 From: Kevin Hilman To: Andreas =?utf-8?Q?F=C3=A4rber?= Cc: linux-amlogic@lists.infradead.org, Mark Rutland , devicetree@vger.kernel.org, Will Deacon , linux-kernel@vger.kernel.org, Rob Herring , Catalin Marinas , Carlo Caione , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 1/2] ARM64: dts: meson-gxm: Add R-Box Pro Organization: BayLibre References: <20170117030611.23827-1-afaerber@suse.de> <20170117030611.23827-2-afaerber@suse.de> <63fbfc68-917f-68b2-9e7d-e1834e2841d3@suse.de> Date: Wed, 18 Jan 2017 14:18:39 -0800 In-Reply-To: <63fbfc68-917f-68b2-9e7d-e1834e2841d3@suse.de> ("Andreas =?utf-8?Q?F=C3=A4rber=22's?= message of "Tue, 17 Jan 2017 04:35:10 +0100") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (darwin) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by mail.home.local id v0IMKl1d020382 Andreas Färber writes: > Am 17.01.2017 um 04:06 schrieb Andreas Färber: >> + leds { >> + compatible = "gpio-leds"; >> + >> + blue { >> + label = "rbox-pro:blue:on"; >> + gpios = <&gpio_ao GPIOAO_9 GPIO_ACTIVE_HIGH>; >> + default-state = "on"; >> + }; >> + >> + red { >> + label = "rbox-pro:red:standby"; >> + gpios = <&gpio GPIODV_28 GPIO_ACTIVE_HIGH>; >> + default-state = "off"; >> + retain-state-suspended; >> + panic-indicator; >> + }; >> + }; > > The original property names for these two were led and red. If anyone > has better label names than the above, please speak up. Ditto for > vega-s95. On the odroidc2 it's called alive but uses heartbeat there. > > The vendor device tree had a third "mcu" GPIO in the sysled node, > GPIOAO_6, which leads to immediate power-off. I tried using > "gpio-poweroff" to configure this pin, but that driver fails to > initialize because some pm callback is already registered - I assume > from psci, which apparently succeeds to power-off the system, too. For > comparison, the S905 based Vega S95 Telos has no such mcu property. Any > thoughts? > > Also, any ideas how best to switch from blue to red for suspend? Add > pinctrl properties above? systemd service doing echo from userspace? I > assume in Android the Amlogic sysled driver handles all that logic - > didn't find any suspend equivalent to gpio-poweroff. in leds-gpio, when retain-state-suspended is not set, the LED is automatically set to value 0. I wonder if leds-gpio should grow support to make the suspend value configurable? Or a property like "toggle-state-suspended" ? Kevin