From: Kevin Hilman <khilman@baylibre.com>
To: Ulf Hansson <ulf.hansson@linaro.org>
Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>,
linux-pm@vger.kernel.org, Len Brown <len.brown@intel.com>,
Pavel Machek <pavel@ucw.cz>,
Geert Uytterhoeven <geert+renesas@glider.be>,
Lina Iyer <lina.iyer@linaro.org>,
Axel Haslam <ahaslam@baylibre.com>,
Marek Szyprowski <m.szyprowski@samsung.com>,
Jon Hunter <jonathanh@nvidia.com>,
Andy Gross <andy.gross@linaro.org>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Subject: Re: [PATCH v2 1/5] PM / Domains: Remove redundant call to pm_request_idle() in genpd
Date: Wed, 15 Jun 2016 14:33:07 -0700 [thread overview]
Message-ID: <m27fdqp27g.fsf@baylibre.com> (raw)
In-Reply-To: <1464600795-26307-2-git-send-email-ulf.hansson@linaro.org> (Ulf Hansson's message of "Mon, 30 May 2016 11:33:11 +0200")
Ulf Hansson <ulf.hansson@linaro.org> writes:
> The PM core increases the runtime PM usage count at the system PM prepare
> phase. Later when the system resumes, it does a pm_runtime_put() in the
> complete phase, which in addition to decrementing the usage count, does
> the equivalent of a pm_request_idle().
>
> Therefore the call to pm_request_idle() from within genpd's ->complete()
> callback is redundant, so let's remove it.
>
> Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
Reviewed-by: Kevin Hilman <khilman@baylibre.com>
next prev parent reply other threads:[~2016-06-15 21:33 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-30 9:33 [PATCH v2 0/5] PM / Domains / Runtime: Optimize device system PM when using genpd Ulf Hansson
2016-05-30 9:33 ` [PATCH v2 1/5] PM / Domains: Remove redundant call to pm_request_idle() in genpd Ulf Hansson
2016-06-15 21:33 ` Kevin Hilman [this message]
2016-05-30 9:33 ` [PATCH v2 2/5] PM / Runtime: Prevent re-resuming devices in pm_runtime_force_resume() Ulf Hansson
2016-06-15 21:33 ` Kevin Hilman
2016-05-30 9:33 ` [PATCH v2 3/5] PM / Domains: Allow runtime PM during system PM phases Ulf Hansson
2016-06-15 21:38 ` Kevin Hilman
2016-06-20 8:23 ` Ulf Hansson
2016-05-30 9:33 ` [PATCH v2 4/5] PM / Domains: Stop/start devices during system PM suspend/resume in genpd Ulf Hansson
2016-06-15 21:40 ` Kevin Hilman
2016-05-30 9:33 ` [PATCH v2 5/5] PM / Runtime: Defer resuming of the device in pm_runtime_force_resume() Ulf Hansson
2016-06-15 21:41 ` Kevin Hilman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m27fdqp27g.fsf@baylibre.com \
--to=khilman@baylibre.com \
--cc=ahaslam@baylibre.com \
--cc=andy.gross@linaro.org \
--cc=geert+renesas@glider.be \
--cc=jonathanh@nvidia.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=len.brown@intel.com \
--cc=lina.iyer@linaro.org \
--cc=linux-pm@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=pavel@ucw.cz \
--cc=rjw@rjwysocki.net \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.