From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Sender: List-Post: List-Help: List-Unsubscribe: List-Subscribe: References: <20230209014108.209950-1-parav@nvidia.com> From: David Edmondson Date: Thu, 09 Feb 2023 13:16:22 +0000 In-reply-to: Message-ID: MIME-Version: 1.0 Subject: Re: [virtio-comment] [PATCH v3] virtio-net: Improve introductory description Content-Type: text/plain To: Parav Pandit Cc: "mst@redhat.com" , "virtio-dev@lists.oasis-open.org" , "cohuck@redhat.com" , Shahaf Shuler , "virtio-comment@lists.oasis-open.org" List-ID: On Thursday, 2023-02-09 at 12:45:09 UTC, Parav Pandit wrote: >> From: David Edmondson >> Sent: Thursday, February 9, 2023 7:03 AM >> > > [..] >> > +to the Ethernet network. The device has transmit and receive queues. >> > +The driver posts empty buffers in the receive virtqueue. >> > +The device receives the incoming packets from the link; the device >> > +places these incoming packets in the receive virtqueue buffers. >> > +The driver enqueues outgoing packets to the transmit virtqueue. The >> > device >> >> We "post" receive buffers, yet "enqueue" transmit buffers. These actions seem >> the same. >> >> Maybe "submits" in both cases? >> > At virtqueue level it is same. > In context of virtio net device, transmit operation is queued that awaits processing (to send) by device. > While receive side, its unsolicited operation done by driver that doesn't await processing by device. > Whenever/if in future when a packet arrives, the posted buffer is consumed. > > So enqueue and post were capturing this contextual detail. > But maybe I am trying to be too precise here but above wording were more natural to me at net level. :) > Let me know.. I'm not too bothered. The operations are functionally the same, so using different words seemed odd. -- Please don't stand so close to me. This publicly archived list offers a means to provide input to the OASIS Virtual I/O Device (VIRTIO) TC. In order to verify user consent to the Feedback License terms and to minimize spam in the list archive, subscription is required before posting. Subscribe: virtio-comment-subscribe@lists.oasis-open.org Unsubscribe: virtio-comment-unsubscribe@lists.oasis-open.org List help: virtio-comment-help@lists.oasis-open.org List archive: https://lists.oasis-open.org/archives/virtio-comment/ Feedback License: https://www.oasis-open.org/who/ipr/feedback_license.pdf List Guidelines: https://www.oasis-open.org/policies-guidelines/mailing-lists Committee: https://www.oasis-open.org/committees/virtio/ Join OASIS: https://www.oasis-open.org/join/