From mboxrd@z Thu Jan 1 00:00:00 1970 From: khilman@baylibre.com (Kevin Hilman) Date: Tue, 28 Feb 2017 10:00:37 -0800 Subject: [PATCH v3 1/6] ARM: davinci: da8xx: allow having multiple pdata-quirks In-Reply-To: <1487772805-19021-2-git-send-email-bgolaszewski@baylibre.com> (Bartosz Golaszewski's message of "Wed, 22 Feb 2017 15:13:20 +0100") References: <1487772805-19021-1-git-send-email-bgolaszewski@baylibre.com> <1487772805-19021-2-git-send-email-bgolaszewski@baylibre.com> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Bartosz Golaszewski writes: > We currently bail-out after applying a single quirk. We will want > to reuse the function doing the vpif capture registration so remove > the break; and continue iterating over the quirk array. > > Signed-off-by: Bartosz Golaszewski Reviewed-by: Kevin Hilman > --- > arch/arm/mach-davinci/pdata-quirks.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/arch/arm/mach-davinci/pdata-quirks.c b/arch/arm/mach-davinci/pdata-quirks.c > index 5b57da4..36fb217 100644 > --- a/arch/arm/mach-davinci/pdata-quirks.c > +++ b/arch/arm/mach-davinci/pdata-quirks.c > @@ -23,7 +23,6 @@ static void pdata_quirks_check(struct pdata_init *quirks) > if (of_machine_is_compatible(quirks->compatible)) { > if (quirks->fn) > quirks->fn(); > - break; > } > quirks++; > } From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751649AbdB1SJJ (ORCPT ); Tue, 28 Feb 2017 13:09:09 -0500 Received: from mail-pg0-f43.google.com ([74.125.83.43]:35805 "EHLO mail-pg0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751037AbdB1SI4 (ORCPT ); Tue, 28 Feb 2017 13:08:56 -0500 From: Kevin Hilman To: Bartosz Golaszewski Cc: Sekhar Nori , David Lechner , Michael Turquette , Patrick Titiano , Laurent Pinchart , Russell King , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 1/6] ARM: davinci: da8xx: allow having multiple pdata-quirks Organization: BayLibre References: <1487772805-19021-1-git-send-email-bgolaszewski@baylibre.com> <1487772805-19021-2-git-send-email-bgolaszewski@baylibre.com> Date: Tue, 28 Feb 2017 10:00:37 -0800 In-Reply-To: <1487772805-19021-2-git-send-email-bgolaszewski@baylibre.com> (Bartosz Golaszewski's message of "Wed, 22 Feb 2017 15:13:20 +0100") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (darwin) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Bartosz Golaszewski writes: > We currently bail-out after applying a single quirk. We will want > to reuse the function doing the vpif capture registration so remove > the break; and continue iterating over the quirk array. > > Signed-off-by: Bartosz Golaszewski Reviewed-by: Kevin Hilman > --- > arch/arm/mach-davinci/pdata-quirks.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/arch/arm/mach-davinci/pdata-quirks.c b/arch/arm/mach-davinci/pdata-quirks.c > index 5b57da4..36fb217 100644 > --- a/arch/arm/mach-davinci/pdata-quirks.c > +++ b/arch/arm/mach-davinci/pdata-quirks.c > @@ -23,7 +23,6 @@ static void pdata_quirks_check(struct pdata_init *quirks) > if (of_machine_is_compatible(quirks->compatible)) { > if (quirks->fn) > quirks->fn(); > - break; > } > quirks++; > }