From: khilman@baylibre.com (Kevin Hilman)
To: linus-amlogic@lists.infradead.org
Subject: [PATCH 1/3] mmc: meson-gx: fix setting f_min
Date: Fri, 27 Jan 2017 09:42:13 -0800 [thread overview]
Message-ID: <m28tpwwgay.fsf@baylibre.com> (raw)
In-Reply-To: <e26a74f8-9819-6940-4c90-225377cc0a3e@gmail.com> (Heiner Kallweit's message of "Thu, 26 Jan 2017 22:41:15 +0100")
Heiner Kallweit <hkallweit1@gmail.com> writes:
> Currently f_min is set to 4 MHz whilst the comment states 400 MHz.
> I think the itention is to set f_min to 400 kHz.
Yes indeed.
> Change value and comment accordingly.
>
> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
Acked-by: Kevin Hilman <khilman@baylibre.com>
> ---
> drivers/mmc/host/meson-gx-mmc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/meson-gx-mmc.c b/drivers/mmc/host/meson-gx-mmc.c
> index bf19d03c..cf071756 100644
> --- a/drivers/mmc/host/meson-gx-mmc.c
> +++ b/drivers/mmc/host/meson-gx-mmc.c
> @@ -268,7 +268,7 @@ static int meson_mmc_clk_init(struct meson_host *host)
> if (f_min != UINT_MAX)
> f_min = DIV_ROUND_UP(CLK_SRC_XTAL_RATE, CLK_DIV_MAX);
> else
> - f_min = 4000000; /* default min: 400 MHz */
> + f_min = 400000; /* default min: 400 kHz */
> host->mmc->f_min = f_min;
>
> /* create the mux */
WARNING: multiple messages have this Message-ID (diff)
From: khilman@baylibre.com (Kevin Hilman)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/3] mmc: meson-gx: fix setting f_min
Date: Fri, 27 Jan 2017 09:42:13 -0800 [thread overview]
Message-ID: <m28tpwwgay.fsf@baylibre.com> (raw)
In-Reply-To: <e26a74f8-9819-6940-4c90-225377cc0a3e@gmail.com> (Heiner Kallweit's message of "Thu, 26 Jan 2017 22:41:15 +0100")
Heiner Kallweit <hkallweit1@gmail.com> writes:
> Currently f_min is set to 4 MHz whilst the comment states 400 MHz.
> I think the itention is to set f_min to 400 kHz.
Yes indeed.
> Change value and comment accordingly.
>
> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
Acked-by: Kevin Hilman <khilman@baylibre.com>
> ---
> drivers/mmc/host/meson-gx-mmc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/meson-gx-mmc.c b/drivers/mmc/host/meson-gx-mmc.c
> index bf19d03c..cf071756 100644
> --- a/drivers/mmc/host/meson-gx-mmc.c
> +++ b/drivers/mmc/host/meson-gx-mmc.c
> @@ -268,7 +268,7 @@ static int meson_mmc_clk_init(struct meson_host *host)
> if (f_min != UINT_MAX)
> f_min = DIV_ROUND_UP(CLK_SRC_XTAL_RATE, CLK_DIV_MAX);
> else
> - f_min = 4000000; /* default min: 400 MHz */
> + f_min = 400000; /* default min: 400 kHz */
> host->mmc->f_min = f_min;
>
> /* create the mux */
next prev parent reply other threads:[~2017-01-27 17:42 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-26 21:41 [PATCH 1/3] mmc: meson-gx: fix setting f_min Heiner Kallweit
2017-01-26 21:41 ` Heiner Kallweit
2017-01-27 17:42 ` Kevin Hilman [this message]
2017-01-27 17:42 ` Kevin Hilman
2017-01-31 11:55 ` Ulf Hansson
2017-01-31 11:55 ` Ulf Hansson
2017-01-31 20:32 ` Heiner Kallweit
2017-01-31 20:32 ` Heiner Kallweit
2017-01-31 22:44 ` Kevin Hilman
2017-01-31 22:44 ` Kevin Hilman
2017-02-01 0:36 ` Kevin Hilman
2017-02-01 0:36 ` Kevin Hilman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m28tpwwgay.fsf@baylibre.com \
--to=khilman@baylibre.com \
--cc=linus-amlogic@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.