From: Andreas Schwab <schwab@linux-m68k.org>
To: Tiejun Chen <tiejun.chen@windriver.com>
Cc: linuxppc-dev@lists.ozlabs.org, jason.wessel@windriver.com
Subject: Re: [PATCH 2/2] PPC_BOOK3E/KGDB: support kgdb kernel space
Date: Wed, 17 Oct 2012 14:07:07 +0200 [thread overview]
Message-ID: <m28vb5s3o4.fsf@igel.home> (raw)
In-Reply-To: <1350471011-2478-2-git-send-email-tiejun.chen__24766.2045098425$1350471081$gmane$org@windriver.com> (Tiejun Chen's message of "Wed, 17 Oct 2012 18:50:11 +0800")
Tiejun Chen <tiejun.chen@windriver.com> writes:
> diff --git a/arch/powerpc/kernel/exceptions-64e.S b/arch/powerpc/kernel/exceptions-64e.S
> index 4684e33..ed5862d 100644
> --- a/arch/powerpc/kernel/exceptions-64e.S
> +++ b/arch/powerpc/kernel/exceptions-64e.S
> @@ -539,11 +539,15 @@ kernel_dbg_exc:
> rfdi
>
> /* Normal debug exception */
> +#ifndef CONFIG_KGDB
> /* XXX We only handle coming from userspace for now since we can't
> * quite save properly an interrupted kernel state yet
> */
> 1: andi. r14,r11,MSR_PR; /* check for userspace again */
> beq kernel_dbg_exc; /* if from kernel mode */
> +#else
> +1:
> +#endif
You could move the label before the conditional.
Andreas.
--
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
"And now for something completely different."
next prev parent reply other threads:[~2012-10-17 12:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-17 10:50 [PATCH 1/2] powerpc/kgdb: Fix a single stgep case of lazy IRQ Tiejun Chen
2012-10-17 10:50 ` [PATCH 2/2] PPC_BOOK3E/KGDB: support kgdb kernel space Tiejun Chen
[not found] ` <1350471011-2478-2-git-send-email-tiejun.chen__24766.2045098425$1350471081$gmane$org@windriver.com>
2012-10-17 12:07 ` Andreas Schwab [this message]
2012-10-18 1:47 ` tiejun.chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m28vb5s3o4.fsf@igel.home \
--to=schwab@linux-m68k.org \
--cc=jason.wessel@windriver.com \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=tiejun.chen@windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.