From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1oH4W1-0003Dt-SK for mharc-grub-devel@gnu.org; Thu, 28 Jul 2022 10:29:29 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:47970) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oH4Vz-00038Y-8d for grub-devel@gnu.org; Thu, 28 Jul 2022 10:29:27 -0400 Received: from mx0a-00069f02.pphosted.com ([205.220.165.32]:50988) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oH4Vt-00032p-W2 for grub-devel@gnu.org; Thu, 28 Jul 2022 10:29:27 -0400 Received: from pps.filterd (m0246627.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 26SD33QC018492; Thu, 28 Jul 2022 14:29:14 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : cc : subject : in-reply-to : references : date : message-id : content-type : content-transfer-encoding : mime-version; s=corp-2022-7-12; bh=srDjJ04qxgErt3jprrqhs5eb2/O60tx+lR/7nuIJViQ=; b=oE1lAxkeSU/Z3T18KteTq4582L0M5qdPRQOIg/fkcuNywFq8C/fD8Mh4lBhOjp5WqTgT Fx/0PUUUYoIklnmfEF2PRO5cK9gbM0qNmg6e/8uoOqayqIKV6oCttAuCnxs60DX6+ams ygcIXYKcUlKwOMyPzTkqU4wct9V8K454yQiskIb8f8RLThgCA7Lr2rh4QqLshK0uo2FE IP99Z8Ou2TwSZwJ7M7mJJxL7eviOXcFQsyVNnJzsakdJe8V7bOMbybVRQ2PHBaIYNzZy 2LXPTpbfG3DUg6GFRgMWSQjkGEUtY0fmtfjLUmc0chAyqachwQKk7PE7fHS7FUlP4mRS wg== Received: from phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta02.appoci.oracle.com [147.154.114.232]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3hg94gmq6j-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 28 Jul 2022 14:29:13 +0000 Received: from pps.filterd (phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (8.17.1.5/8.17.1.5) with ESMTP id 26SEOepx017150; Thu, 28 Jul 2022 14:29:12 GMT Received: from nam11-dm6-obe.outbound.protection.outlook.com (mail-dm6nam11lp2174.outbound.protection.outlook.com [104.47.57.174]) by phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTPS id 3hh653ba52-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 28 Jul 2022 14:29:12 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=K11s2cGlQstkSzs6jmTcIcPlWjX57gPXc4philYFQGYPK6ojmb/5Gd8ilNZ1W4nssp1RnWxIaqG67dBDP9jEsZcAnFNGXWC+MZaL4uEfeHgBfAFov5vVwZAdKCg0KzBuIWZfBS80WpzorXvU0aEpOWbstBbOaK4iFdhpxxm8aAEovj+OEaFw8q8lYvZB12mrW+VmQ/5dsx6Eq9JPVKAeufHUCNkXRRDvh17yhDnhF3gBY82GANcqtYEfHpbQXwoxIU9qxS8t0jljIekLM7AhJARBl4/rkBAVYJ34pfYY8JvXLs8jWBsyowJc3rLxPW1ogMPiaa+5P8uz0kKGdGp29g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=srDjJ04qxgErt3jprrqhs5eb2/O60tx+lR/7nuIJViQ=; b=itE2njND9YHmzl/qwAXA5Xjn4cG2YiRXWyRRVygCFSY6AFhILUPeTvnQAwj4On+K5rS70B7RuGyF7OqEaYKJ/PL+x4/1Q5hGhFu0wjR+LpmTgOP1dIy62UHBJtAxiELwMieVpqM1t/Z44NBkB9PVA4Mfa5LJZIfi+8PH5yreS7MZMTW7R4iaS4YzUk8IBes8E71e3z6nBJsrcjAajB0hfVwhD6X1Nvvtspz0cOSFqppqjn7XB/bIGZ9fbEhI3cjkg+a6MeXKmIrTGX0Y5I/6+H+32vCfpgrq7V/YMYQZVhAhPcv8cXnhRkqF0w+C2jCgDBBDKFoMPSQynM8kgr5ZEw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=srDjJ04qxgErt3jprrqhs5eb2/O60tx+lR/7nuIJViQ=; b=b+1ehCFHIItyhtbbkzr5hoGMSOzZAD/o6KcKUq2zAeOsPO1FJlBZiwcHuugQz/BRIE24Dt/PjhbPdOIg3hg/7x+Aq8+mlbiAOeHcJTeS+a39d7PcKImbcAL0rfwEH5ZxALkSH3vbeuI81lVcXtSR+ydy56TLT+Z0h0M7tf5YcgA= Received: from BLAPR10MB5138.namprd10.prod.outlook.com (2603:10b6:208:322::8) by MWHPR10MB1887.namprd10.prod.outlook.com (2603:10b6:300:10b::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5458.21; Thu, 28 Jul 2022 14:29:10 +0000 Received: from BLAPR10MB5138.namprd10.prod.outlook.com ([fe80::89fe:338:779d:6bb0]) by BLAPR10MB5138.namprd10.prod.outlook.com ([fe80::89fe:338:779d:6bb0%8]) with mapi id 15.20.5482.011; Thu, 28 Jul 2022 14:29:10 +0000 From: Darren Kenny To: Glenn Washburn , Vladimir 'phcoder' Serbinenko Cc: The development of GNU GRUB , Daniel Kiper Subject: Re: [PATCH 1/1] gensymlist: fix clang build with exporting of __builtin_trap In-Reply-To: <20220614131643.2651e9a0@crass-HP-ZBook-15-G2> References: <27577c50039bf5debf47faefa9f03d8bc9d128e8.1655213266.git.darren.kenny@oracle.com> <20220614131643.2651e9a0@crass-HP-ZBook-15-G2> Date: Thu, 28 Jul 2022 15:29:05 +0100 Message-ID: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: DB7PR05CA0013.eurprd05.prod.outlook.com (2603:10a6:10:36::26) To BLAPR10MB5138.namprd10.prod.outlook.com (2603:10b6:208:322::8) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 59addba2-5dc9-469b-c7ae-08da70a588ad X-MS-TrafficTypeDiagnostic: MWHPR10MB1887:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Qv3JAPp4BeX9lO/6Tl0V0fPXc3pkLF2YWFx4VHhqqwNiDg1nWGDTWFzP4/DNH2SvaBesHmaW7wnPO9cf88ZSCgHa63+KqoP1rfcWswuvgt/y+o5cbq2QfKZ109t99uNJ8lymK6ji34v6UQ5noK7a90Q1mI+nouN2lzlwg1c3isGrghaxc9bPtrHBU4rMMJvjqa52DmhijM8aMf1BpW9aqYw566QK0dcdhhqepaFBxAzja6Y2GknT8jlCDK9l8BMQqkCFuSA4jD8TzDmMu+74oeAeYYvLBufw+I8sKe9UcuUU8nDs51Eni5bTzqqwGG+2JKDif0u8u5E+Xma9uYt28zHeC6GDl5IdsP1ieQ2mG4KhHlbuSWcwe180TzRaV2HW7nI2CQTUFXHYgavVCgwT2JVagd41bZYWNuirZkqjHpAHuG9CaRFnpVfmsb/JXWCJCmO4La7tg6J3cLUjJ9mcUtE+26wbKKE1Wg1fkK8BF1nYOtjtE1Kf3xbOWr54rUVlApylk6mkMPt9nHUo1KXNR0KxarpMn7IwCY1IRGDDMApsuF0fYUKeAJLiNZQyg4FuYoeHOkZ+h3Wm3BHaBnW9OXMU5Jot1dWX2pfRPHjOBiTBXiDlTYeiuYPTaBZghvMBeXKP2jWR2McLeP/KADQeerXh/EfEwUSTK3Fhjt5aH3GiOEzSLBRHpKkhPDfxz+sP5t5VOEK45bz6syBQYB9jq/CV0faKIpRo9Laoo3g3d4QHmLJnTO5a58FtVVcwLr75KOwSp05wt+ZZlhlJIoOUz4FwJVFabOPOXwF97a6YohPGp9A+TKy9mq+/ADVV1JT8 X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BLAPR10MB5138.namprd10.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230016)(376002)(136003)(39860400002)(396003)(366004)(346002)(41300700001)(6486002)(2906002)(966005)(6512007)(26005)(478600001)(44832011)(36756003)(4326008)(86362001)(54906003)(6506007)(110136005)(6666004)(316002)(8676002)(83380400001)(5660300002)(8936002)(66476007)(66556008)(66946007)(38100700002)(2616005)(186003); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Wk12ZUF4YUp6eG1BM0lteXV0aFRXR01sc1JYQjR1cnJtUWhFR0VxTVBjSGZC?= =?utf-8?B?RG5iZWV1RmhLNk5tMVRJSGtqbG5nTVUyTEFHSGYvWGNJZFhsaE9hV0JPYWlm?= =?utf-8?B?WTZKS1ljZkZobmltSmcrdGJIVGxEZEpKbGtTaS9uYUszNTdtcHJRa3RhL3B6?= =?utf-8?B?YlM4UTNuYWxkeGlBVXVKYVNSTjUvZk1FZFhackluK2k1ZDhoem16VEI4aVYz?= =?utf-8?B?Q3VHWmxnL3dEbjRFTmR1aTRVUlNiS0dNQ2JJcURSSVBPV2dKcWlsRGVsMmoy?= =?utf-8?B?VFNQc0JybUFCQ1BCVVhZbG53YWhSdFlMc01jVkpSbnVOMUFaY0hhb0xIZ1Jo?= =?utf-8?B?Zyt4MkZGWFgycXFsYldyUmFYdngxVjFLcDNrMm8rNkZ2NVNYSTBQaTRpS1hs?= =?utf-8?B?V3p3ZS80cHFsZHhnUHhIcW1KY0VOYXd4V0dLQ2V5ZjV2Vnl0cWptbFUxSHhI?= =?utf-8?B?SkdGZENvaC9qNTR3Rm1yNTFLVFlVa3I4NlBVclMyelRyby9YbHArQmlHeXlo?= =?utf-8?B?VVRyQUlsa1ZERmNtdmdxTFo5anJkNmZpbnlJaGFIUmc0UDlTZkFUa214YVM2?= =?utf-8?B?cWVvUElCaGdTbTNuYkdjRzFvR0txMWFiZUlEWEhmMFNxT2RhZjY0TnNlKyta?= =?utf-8?B?dWtub1pJWnZPWmY3bjUwblk0ZnpjOHgwa21JMUo3Yis2TmE1Ty9BekZMNC9G?= =?utf-8?B?dG9SVWdJNjZJZk5qZFM5V0czMW5KTUtHVHJwYW1hcFVLdS83VGNVZmp2YWcw?= =?utf-8?B?cjREOXB0Z3ljWFNhS2ZnOG9YaWovSFUvV2xJREljbzZIVzQ4eG9rbVgwQWMv?= =?utf-8?B?UmlpY3FVTUxvL2FJaitGWkdTSVBoSGQ2MVZ5SmkvSXB2aGRSTjBObmJRaTMv?= =?utf-8?B?eURrQUlJQ2IyeGdabTBsNjYxeEw1UklpYkpLdlhPZkt3cnFMOEpJUUFmL0Zw?= =?utf-8?B?U243S0ExMUN2NzdYbUd5MFU4Nzh3MkF2SUtoT3dJZjdOZkFsRkNlVzNCNzFa?= =?utf-8?B?eFFXYW4yZEdDQ1ZKTlBBelJDSHBBd2VqMzV3TXp3c0Zoc0tFNzVGUVNMQ2xo?= =?utf-8?B?VWNGS0hoei96Rmc0MlNlbzFPVW01MWpjb0NiTDZNL0RhYXJ1Ykw3Q0hpSi93?= =?utf-8?B?M0YvVWs2T1hoNmFPQWJsS3A0SURDS1o1TDNmZWF4RkJYMTIrejA4RnRPMFhT?= =?utf-8?B?NnZLZmFRV0RVRkdEK2UvZmNuK2t0U0p5SW1PcExLUlZrS0I2WUsreTBjZFdT?= =?utf-8?B?ZW5Bd1U1QzhNWXNZWmhQbEZna29MQ0ExV3FzYUZ2ZCtuWkJ2UkFjN3g3amJ5?= =?utf-8?B?ZTlGdmV3R1FsZFh1UkgwMUJlMXM2NDNYRHNVL3pGbGFFdnJCdlhoTGErbmVR?= =?utf-8?B?ZDlzcWVMZVRlRUx1azI3RXZKVDZEZDc4Mm9pK1VxWlQ0ZFo1UUl3emQ4VGRh?= =?utf-8?B?WXVrNEZSYTBGMFk2OU8vajNkMHJFOHFxMTh4aUp2SlZqWXpicUhldnNOU0hR?= =?utf-8?B?OG5qMU1hY3Q4ZFovVXJkaFFuZmNiajBGNWxvUHFHa1duWG5rcnhpR01BYUZH?= =?utf-8?B?WTNpcHI2N2hqNE4zKzBKNWdQdXVpOXhVM3dPczBUUTZNRlFlYjJEdm5pdkNo?= =?utf-8?B?ZGFpVll1T3NBRHBmUnJBZmxNSzBVdDllTjZIRnZucDF0cWtscW1JK2xYYkdZ?= =?utf-8?B?b0hWMHRIaER6RTR5dURObS9ONEM4bElCbVBSL3V6UnA4SGxNOGpjWXk3aW4r?= =?utf-8?B?NUoydTU4K21uWFd3a1FheWNsODVGQVZZVVEvLy9XTzlpMndLZFJ0U0xLRkZt?= =?utf-8?B?OVZQMkpkT0VDS0daZklhWEdFZ2tPT3RHVHRvbDUzemx4OXJWS3hzZFQ4ZTZa?= =?utf-8?B?WVRXTWdzWEZ6WE9TSEFYTGlKLzZwU0Y3S2RJOEdzSmRrMDFpazZNcUc1ZjFE?= =?utf-8?B?ekhGU0ZlTi9TdUhwN2xIWStqS2QyK2Y4NnNRUzNxZEc1K3FBZ2c5RXh1eFIx?= =?utf-8?B?SzB2OHF2amp6c3ZoaFVnSFArbmhabm0zTXlOUExSOUpLNmQ0NjFmK1FXa0ZC?= =?utf-8?B?QzBJWFYvNkNuamdHUWE0bHQvd0hLQWZELzhmNVRPTnBjVzBmdFFRME5iRU1w?= =?utf-8?Q?MFVJMbMP8AM4KZFgapbIow6Qr?= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 59addba2-5dc9-469b-c7ae-08da70a588ad X-MS-Exchange-CrossTenant-AuthSource: BLAPR10MB5138.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Jul 2022 14:29:10.1674 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: EqaUeyrW2xdQrpyxnq3pwJzTS/D8/QazGb6JDkHKIJtW6sbZ7XcYDS7/uaa/ssY9WLbnCvdI6dUEPQ2E13iHQA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR10MB1887 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.883,Hydra:6.0.517,FMLib:17.11.122.1 definitions=2022-07-28_05,2022-07-28_02,2022-06-22_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 phishscore=0 bulkscore=0 adultscore=0 mlxscore=0 mlxlogscore=999 spamscore=0 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2206140000 definitions=main-2207280065 X-Proofpoint-GUID: fcHfPNsxSAaQlWAM_qVs1V_BzkCVkmmK X-Proofpoint-ORIG-GUID: fcHfPNsxSAaQlWAM_qVs1V_BzkCVkmmK Received-SPF: pass client-ip=205.220.165.32; envelope-from=darren.kenny@oracle.com; helo=mx0a-00069f02.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 28 Jul 2022 14:29:27 -0000 Hi Glenn, Finally managed to get a look at this again, and I agree Glenn that your patch fixes this issue too, so I withdraw my patch. Thanks, Darren. On Tuesday, 2022-06-14 at 13:18:43 -05, Glenn Washburn wrote: > On Tue, 14 Jun 2022 18:55:18 +0200 > "Vladimir 'phcoder' Serbinenko" wrote: > >> Correct solution is to provide __builtin_trap ourselves. Likely it would= be >> a wrapper around grub_abort > > This seems like tacit support for at least the direction of my patch > removing the use of __builtin_trap[1] which was introduced recently in > cd37d3d39 (gnulib: Drop no-abort.patch) and which uses grub_abort() > instead of __builtin_trap. The only other place that could potentially > use __builtin_trap is in grub-core/lib/gnulib/verify.h in the "assume" > macro. However, I don't see anywhere that macro is being used. Though > Daniel was wondering what was wrong with defining abort in > grub-core/lib/posix_wrap/stdlib.h as had been done in db7337a3d > (grub-core/lib/posix_wrap/stdlib.h (abort): Removed). > > Glenn > > [1] https://lists.gnu.org/archive/html/grub-devel/2022-03/msg00220.html > >>=20 >> Le mar. 14 juin 2022, 15:37, Darren Kenny a >> =C3=A9crit : >>=20 >> > clang expands the abort function to __builtin_trap, but that cannot be >> > exported. >> > >> > The script that generates the symlist.c file should also exclude any >> > symbols that start with __builtin_. >> > >> > Signed-off-by: Darren Kenny >> > --- >> > grub-core/gensymlist.sh | 1 + >> > 1 file changed, 1 insertion(+) >> > >> > diff --git a/grub-core/gensymlist.sh b/grub-core/gensymlist.sh >> > index 5074ef6aad58..a2e5b85d0a71 100644 >> > --- a/grub-core/gensymlist.sh >> > +++ b/grub-core/gensymlist.sh >> > @@ -58,6 +58,7 @@ EOF >> > >> > (while read LINE; do echo $LINE; done) \ >> > | grep -v '^#' \ >> > + | grep -v 'EXPORT_FUNC *(__builtin_[a-zA-Z0-9_]*)' \ >> > | sed -n \ >> > -e '/EXPORT_FUNC *([a-zA-Z0-9_]*)/{s/.*EXPORT_FUNC >> > *(\([a-zA-Z0-9_]*\)).*/ {"\1", \1, 1},/;p;}' \ >> > -e '/EXPORT_VAR *([a-zA-Z0-9_]*)/{s/.*EXPORT_VAR >> > *(\([a-zA-Z0-9_]*\)).*/ {"\1", (void *) \&\1, 0},/;p;}' \ >> > -- >> > 2.31.1 >> > >> > >> > _______________________________________________ >> > Grub-devel mailing list >> > Grub-devel@gnu.org >> > https://lists.gnu.org/mailman/listinfo/grub-devel >> > > > _______________________________________________ > Grub-devel mailing list > Grub-devel@gnu.org > https://lists.gnu.org/mailman/listinfo/grub-devel