From: Andrew W Elble <aweits@rit.edu>
To: "J. Bruce Fields" <bfields@fieldses.org>
Cc: <linux-nfs@vger.kernel.org>, <jlayton@poochiereds.net>
Subject: Re: [PATCH RFCv2] nfsd: fix race with open / open upgrade stateids
Date: Thu, 05 Nov 2015 16:54:45 -0500 [thread overview]
Message-ID: <m2a8qsru1m.fsf@discipline.rit.edu> (raw)
In-Reply-To: <20151105212108.GH9210@fieldses.org> (J. Bruce Fields's message of "Thu, 5 Nov 2015 16:21:08 -0500")
> Is there some lock imbalance?:
Hmmmm, I'll have to poke at that a bit.
> When you send a v2 patch, would you mind also describing what's changed?
> If you stick the description here (between the --- and the diff), it'll
> be discarded when git applies the patch (which is what we want).
Ah. In this case, v1 missed unlocking the rwsem if nfs4_upgrade_open()
returned status.
> Is there's some particular point that you thought was confusing here?
> Then I'm fine with highlighting that. But I don't want to routinely add
> these block comments on every little function.
Ok.
> Code looks OK, though. (And I don't spot the locking problem on a quick
> skim...).
--
Andrew W. Elble
aweits@discipline.rit.edu
Infrastructure Engineer, Communications Technical Lead
Rochester Institute of Technology
PGP: BFAD 8461 4CCF DC95 DA2C B0EB 965B 082E 863E C912
next prev parent reply other threads:[~2015-11-05 21:54 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-04 17:13 [PATCH RFCv2] nfsd: fix race with open / open upgrade stateids Andrew Elble
2015-11-05 21:21 ` J. Bruce Fields
2015-11-05 21:54 ` Andrew W Elble [this message]
2015-11-05 22:03 ` J. Bruce Fields
2015-11-06 1:14 ` Andrew W Elble
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2a8qsru1m.fsf@discipline.rit.edu \
--to=aweits@rit.edu \
--cc=bfields@fieldses.org \
--cc=jlayton@poochiereds.net \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.