From: Andreas Schwab <schwab@linux-m68k.org>
To: Junio C Hamano <gitster@pobox.com>
Cc: Felipe Contreras <felipe.contreras@gmail.com>, git@vger.kernel.org
Subject: Re: [PATCH] prompt: fix tracked files for zsh
Date: Sun, 21 Apr 2013 21:02:12 +0200 [thread overview]
Message-ID: <m2a9or907f.fsf@igel.home> (raw)
In-Reply-To: <7vli8cuv5j.fsf@alter.siamese.dyndns.org> (Junio C. Hamano's message of "Sun, 21 Apr 2013 01:48:08 -0700")
Junio C Hamano <gitster@pobox.com> writes:
> Andreas Schwab <schwab@linux-m68k.org> writes:
>
>> Felipe Contreras <felipe.contreras@gmail.com> writes:
>>
>>> + if [ -n "${ZSH_VERSION-}" ]; then
>>> + u="%%"
>>> + else
>>> + u="%"
>>> + fi
>>
>> aka u="%${ZSH_VERSION:+%}"
>
> Do you need/want a colon there? Even if it is empty, as long as it
> is defined we would want this, no?
The original wouldn't.
Andreas.
--
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
"And now for something completely different."
next prev parent reply other threads:[~2013-04-21 19:02 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-21 8:11 [PATCH] prompt: fix tracked files for zsh Felipe Contreras
2013-04-21 8:21 ` Andreas Schwab
2013-04-21 8:48 ` Junio C Hamano
2013-04-21 19:02 ` Andreas Schwab [this message]
2013-04-21 21:00 ` Felipe Contreras
2013-04-21 22:00 ` Junio C Hamano
2013-04-21 22:32 ` Felipe Contreras
2013-04-21 8:43 ` Eric Sunshine
2013-04-21 8:43 ` Junio C Hamano
2013-04-21 8:43 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2a9or907f.fsf@igel.home \
--to=schwab@linux-m68k.org \
--cc=felipe.contreras@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.