From: Thierry Vignaud <tvignaud@mandriva.com>
To: alsa-devel@alsa-project.org
Cc: Takashi Iwai <tiwai@suse.de>
Subject: Re: [alsa-cvslog] alsa-lib: Fix the state in snd_pcm_ioplug_pause()
Date: Mon, 25 Feb 2008 16:29:51 +0100 [thread overview]
Message-ID: <m2ablpyryo.fsf@vador.mandriva.com> (raw)
In-Reply-To: <ALOGGER1203948542.59@alsa-project.org> (Takashi Iwai's message of "Mon\, 25 Feb 2008 15\:09\:02 +0100 \(CET\)")
Takashi Iwai <tiwai@suse.de> writes:
> changeset: 2423:7388ad3d21ea
> tag: tip
> user: tiwai
> date: Mon Feb 25 15:11:46 2008 +0100
> files: src/pcm/pcm_ioplug.c
> description:
> Fix the state in snd_pcm_ioplug_pause()
>
> The states[] in snd_pcm_ioplug_pause() has wrong values. They should be
> swapped. ALSA bug#3796:
> https://bugtrack.alsa-project.org/alsa-bug/view.php?id=3796
Aren't some bits missing from this bug report? (s/o->data->state =
states[enable]/io->data->state = states[prev])
> diff -r 6d83f965a9d9 -r 7388ad3d21ea src/pcm/pcm_ioplug.c
> --- a/src/pcm/pcm_ioplug.c Mon Feb 25 14:58:45 2008 +0100
> +++ b/src/pcm/pcm_ioplug.c Mon Feb 25 15:11:46 2008 +0100
> @@ -484,7 +484,7 @@ static int snd_pcm_ioplug_pause(snd_pcm_
> {
> ioplug_priv_t *io = pcm->private_data;
> static snd_pcm_state_t states[2] = {
> - SND_PCM_STATE_PAUSED, SND_PCM_STATE_RUNNING
> + SND_PCM_STATE_RUNNING, SND_PCM_STATE_PAUSED
> };
> int prev, err;
>
>
>
> -------------------------------------------------------------------------
> This SF.net email is sponsored by: Microsoft
> Defy all challenges. Microsoft(R) Visual Studio 2008.
> http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
> _______________________________________________
> Alsa-cvslog mailing list
> Alsa-cvslog@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/alsa-cvslog
next parent reply other threads:[~2008-02-25 15:30 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <ALOGGER1203948542.59@alsa-project.org>
2008-02-25 15:29 ` Thierry Vignaud [this message]
2008-02-25 15:32 ` [alsa-cvslog] alsa-lib: Fix the state in snd_pcm_ioplug_pause() Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2ablpyryo.fsf@vador.mandriva.com \
--to=tvignaud@mandriva.com \
--cc=alsa-devel@alsa-project.org \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.