From: Juan Quintela <quintela@mandrakesoft.com>
To: Rich Baum <richbaum@acm.org>
Cc: linux-kernel@vger.kernel.org,
Linus Torvalds <torvalds@transmeta.com>,
Alan Cox <alan@lxorguk.ukuu.org.uk>
Subject: Re: [PATCH] warning fixes for 2.4.5pre5
Date: 25 May 2001 17:13:39 +0200 [thread overview]
Message-ID: <m2ae41o40s.fsf@trasno.mitica> (raw)
In-Reply-To: <873E21525C8@coral.indstate.edu>
In-Reply-To: <873E21525C8@coral.indstate.edu>
Hi
> --- linux/arch/i386/math-emu/fpu_trig.c Fri Apr 6 12:42:47 2001
> +++ rb/arch/i386/math-emu/fpu_trig.c Tue May 22 16:44:57 2001
> @@ -1543,6 +1543,7 @@
> EXCEPTION(EX_INTERNAL | 0x116);
> return;
> #endif /* PARANOID */
>+ return;
> }
> }
> else if ( (st0_tag == TAG_Valid) || (st0_tag == TW_Denormal) )
Will not be better to move the return out of the #endif PARANOID?
Otherwise you get 2 returns when you have defined paranoid ...
> --- linux/drivers/scsi/sym53c8xx.c Fri Apr 27 15:59:19 2001
> +++ rb/drivers/scsi/sym53c8xx.c Tue May 22 16:45:03 2001
> @@ -11564,6 +11564,7 @@
> OUTL_DSP (NCB_SCRIPT_PHYS (np, clrack));
> return;
> out_stuck:
>+ return;
> }
same
Later,Juan.
--
In theory, practice and theory are the same, but in practice they
are different -- Larry McVoy
next prev parent reply other threads:[~2001-05-25 15:15 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-05-25 2:40 [PATCH] warning fixes for 2.4.5pre5 Rich Baum
2001-05-25 15:13 ` Juan Quintela [this message]
2001-05-25 15:42 ` Alan Cox
2001-05-25 16:10 ` Alan Cox
2001-05-25 20:47 ` Rich Baum
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2ae41o40s.fsf@trasno.mitica \
--to=quintela@mandrakesoft.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=richbaum@acm.org \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.