From mboxrd@z Thu Jan 1 00:00:00 1970 Received: by 2002:a17:906:80c3:b0:7ae:d8f:8937 with SMTP id a3csp129458ejx; Tue, 29 Nov 2022 00:21:40 -0800 (PST) X-Google-Smtp-Source: AA0mqf6/XXekI4eCLNC2tNVuFMC3uSOAULwvQKctmqMoeEnB0aKKBcUTp72lM8+gpS1FN/uo5mm/ X-Received: by 2002:a05:620a:129a:b0:6f6:2a21:3638 with SMTP id w26-20020a05620a129a00b006f62a213638mr35595388qki.610.1669710100387; Tue, 29 Nov 2022 00:21:40 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1669710100; cv=none; d=google.com; s=arc-20160816; b=ZxCI1Q0MFOGw5G4KTid+QSSf+0NHAvjncB6FBIK7pyUsBzQrGdrjIu5IhKzbCjm0yo HNhoqOGbvXO6b25tA1PbL2JB+0ZG6QhZ4ApfN4wdILQOX86dQ1a60xVA76d8YveFAEon c0txbhxSdshlji22WbkOcUcUfRsbVpPR4suJj/Vi5MKH25cS+IGjuajwCfnJ+1wXwyi2 ofPbRBq4U/HAMBqny2HEtsXtKwNGqzGr9UEes04iSA7AaQtkO7ynGWHpsaN4MBzIBYQD ddJVHxu5Rpr01j4ePgm8diqRV6K3seVQmMlHj0s9/GG/PrQmmwLgv8XHRS9dZiVFSim9 zxRg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:mime-version:message-id :in-reply-to:date:subject:cc:to:from:user-agent:references :dkim-signature; bh=imvRvzRFXNSpuT6Yejm950coPKmHh3JD6y+kT+OXZbg=; b=zi2WWEHnV0W4bOODAI2FugGIcbgLz9pfmBI+Vrh102Kw1EhX+KDGxCoiTmcYYXpuVr 0rqd+2Kh7d8NCuxmocAC3ttvRwSjKcYNdZvTM91QZMZpVUEKMMovfY9+yWp6NN506dh8 b9e17YOcYwKkvOb3pkrKXUV6MmNG9YrWXq+NV1YMYKMcgM1UbDSTPNsYgP0y1OUA5wTg A28Rw9m3/JXr5IjSgALJXPtEdEzkDnThQODIH/tjBmCFCzuSEtw9ErNaXbEiQ+uSECu8 nxFR3PjIYeInb1XtdBEACv1vyz20M2QXt2/X/ipUkBh+PFfs7INvrYbdSK9f8G/JXkX8 yEvw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=KdvQdUCj; spf=pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id g6-20020a05620a40c600b006eeb3165564si8673633qko.34.2022.11.29.00.21.40 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Tue, 29 Nov 2022 00:21:40 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=KdvQdUCj; spf=pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ozvrN-0002Xc-7v; Tue, 29 Nov 2022 03:20:57 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ozvrC-0002Vv-Nd; Tue, 29 Nov 2022 03:20:54 -0500 Received: from mail-io1-xd35.google.com ([2607:f8b0:4864:20::d35]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ozvqu-0008Kj-0j; Tue, 29 Nov 2022 03:20:38 -0500 Received: by mail-io1-xd35.google.com with SMTP id p141so9491039iod.6; Tue, 29 Nov 2022 00:20:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:message-id:in-reply-to:date:subject:cc:to:from :user-agent:references:from:to:cc:subject:date:message-id:reply-to; bh=imvRvzRFXNSpuT6Yejm950coPKmHh3JD6y+kT+OXZbg=; b=KdvQdUCjl8mb9mnkOlyW5/VT2ooURpf53XrlpuqPwwb6I9BxD6HJafkhGwXhFUoMTm r9eQd+qt4L5vgkp/E2TA7r+U7DElnpBAes8w7sxZbVl1lRVHbB+B4PsPtiEkE8RpAtoz VzsPWZUV297t6YvKH1fS5K+rD9pnqLr5NSyTxO5C0+IgM4YInc3Yvxr8Z0AI4Hafa0RE 7DNzRCc3VxB3KPIiSeI4osB/hJ5moZp/FgyvQGIpdd3VVEMrYzwVb93sVQtH+sNIU6fk GRwlyKkN/ufMt2EsCPe5ynX1o1OkqjSFF61JSO55U2uLsI57yrAXm1XHu8gXRcoTi5rS jntA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:message-id:in-reply-to:date:subject:cc:to:from :user-agent:references:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=imvRvzRFXNSpuT6Yejm950coPKmHh3JD6y+kT+OXZbg=; b=5qEJlzN1S5OYL15zPsNuBCHdYJrbUYR1+2WWolB+be75VdKm00vIpfrpMaUdQm/OtZ Uls/+BXIh4fochZ2d1D06n/Z2wAsvBDZA9qmnCm+v08y2dd1QgNOznPhencH+cmaUbb7 9dASaGhjYEf6XGgYrnlxdBIK+pk0mjrbg2fhOD2SRbnhF534S/QlvHXzvMCXZlqNgWq0 GIc78S1eaiT2CDsOkfguZq/KSX11cIznVRl8644Fjsrz8SW3XKgO7Oh4ejU/kPUB4XFU W06yo2Vb65nnZZRL3CZWrRrSIBEBaXz8LDRggP9fVSA/x/JN/j7oH21gGG6yFDycN78r baPw== X-Gm-Message-State: ANoB5pnLjyZyoG2Q9q60MyNnzQGlctMs1hgJ1QOzJr+zKnPfsqGv9LzV g6KAbbjQ1X5TfznwCbO8URTaaN+upSqYuA== X-Received: by 2002:a05:6602:408b:b0:6bb:f9be:3691 with SMTP id bl11-20020a056602408b00b006bbf9be3691mr23942063iob.123.1669710011962; Tue, 29 Nov 2022 00:20:11 -0800 (PST) Received: from MBP (ec2-18-117-95-84.us-east-2.compute.amazonaws.com. [18.117.95.84]) by smtp.gmail.com with ESMTPSA id v23-20020a02b097000000b00389ca12ddd1sm996842jah.174.2022.11.29.00.20.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 29 Nov 2022 00:20:11 -0800 (PST) References: <20221108023542.17557-1-schspa@gmail.com> User-agent: mu4e 1.8.10; emacs 28.2 From: Schspa Shi To: Peter Maydell Cc: qemu-arm@nongnu.org, qemu-devel@nongnu.org Subject: Re: [PATCH] hw/arm/boot: set initrd parameters to 64bit in fdt Date: Tue, 29 Nov 2022 15:50:55 +0800 In-reply-to: Message-ID: MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=2607:f8b0:4864:20::d35; envelope-from=schspa@gmail.com; helo=mail-io1-xd35.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-arm@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org Sender: qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org X-TUID: V+9hYjR9W6OX Peter Maydell writes: > On Tue, 8 Nov 2022 at 02:35, Schspa Shi wrote: >> >> We use 32bit value for linux,initrd-[start/end], when we have >> loader_start > 4GB, there will be a wrong initrd_start passed >> to the kernel, and the kernel will report the following warning > >> To fix it, we can change it to u64 type. >> >> Signed-off-by: Schspa Shi >> --- >> hw/arm/boot.c | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/hw/arm/boot.c b/hw/arm/boot.c >> index 57efb61ee419..da719a4f8874 100644 >> --- a/hw/arm/boot.c >> +++ b/hw/arm/boot.c >> @@ -638,14 +638,14 @@ int arm_load_dtb(hwaddr addr, const struct arm_boot_info *binfo, >> } >> >> if (binfo->initrd_size) { >> - rc = qemu_fdt_setprop_cell(fdt, "/chosen", "linux,initrd-start", >> + rc = qemu_fdt_setprop_u64(fdt, "/chosen", "linux,initrd-start", >> binfo->initrd_start); >> if (rc < 0) { >> fprintf(stderr, "couldn't set /chosen/linux,initrd-start\n"); >> goto fail; >> } >> >> - rc = qemu_fdt_setprop_cell(fdt, "/chosen", "linux,initrd-end", >> + rc = qemu_fdt_setprop_u64(fdt, "/chosen", "linux,initrd-end", >> binfo->initrd_start + binfo->initrd_size); >> if (rc < 0) { >> fprintf(stderr, "couldn't set /chosen/linux,initrd-end\n"); > > Hi; the device-tree folks got back to me a bit late on this one, > but apparently the intention is that these fields should be > of a size that matches the #address-cells (and they'll fix the > schema docs to say that at some point). Some future kernel > or dtb-schema-check might warn about this, and also since it is > what u-boot does: > https://github.com/u-boot/u-boot/blob/218e2c45af83f2cb7b1374b9023b4ced6eb0bb77/common/fdt_support.c#L248 > following that same approach is the safest thing in terms of not > breaking existing code. > > I think that to do this in QEMU we just need to call > > qemu_fdt_setprop_sized_cells(fdt, "/chosen", "linux,initrd-start", > acells, binfo->initrd_start); > > and similarly for initrd-end. > > Would you mind doing a respin and test of this patch that works > that way? > I have made a new patch & test it this way, it works perfectly. > thanks > -- PMM -- BRs Schspa Shi