All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew W Elble <aweits@rit.edu>
To: "J. Bruce Fields" <bfields@fieldses.org>
Cc: <linux-nfs@vger.kernel.org>, <bfields@redhat.com>, <jlayton@kernel.org>
Subject: Re: [PATCH] nfsd: fix error handling in nfs4_set_delegation()
Date: Mon, 07 May 2018 12:03:35 -0400	[thread overview]
Message-ID: <m2bmdr8nc8.fsf@discipline.rit.edu> (raw)
In-Reply-To: <20180503214119.GC27964@fieldses.org> (J. Bruce Fields's message of "Thu, 3 May 2018 17:41:19 -0400")


"J. Bruce Fields" <bfields@fieldses.org> writes:

> Apologies for the slow response, this looks right, I'm just still trying
> to figure out whether this is the only problem here--e.g. does it cause
> problems to have this lease temporarily applied before the delegation is
> hashed?

So the only thing I can currently theorize is that we might eject some
recalls for delegations that will never hit the wire. I think the worst
possibility is that nfsd4_cb_recall_done() might wind up declaring the
callback path to be down? Still looking...

Thanks,

Andy

-- 
Andrew W. Elble
aweits@discipline.rit.edu
Infrastructure Engineer, Communications Technical Lead
Rochester Institute of Technology
PGP: BFAD 8461 4CCF DC95 DA2C B0EB 965B 082E 863E C912

      reply	other threads:[~2018-05-07 16:10 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-18 21:04 [PATCH] nfsd: fix error handling in nfs4_set_delegation() Andrew Elble
2018-05-03 21:41 ` J. Bruce Fields
2018-05-07 16:03   ` Andrew W Elble [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m2bmdr8nc8.fsf@discipline.rit.edu \
    --to=aweits@rit.edu \
    --cc=bfields@fieldses.org \
    --cc=bfields@redhat.com \
    --cc=jlayton@kernel.org \
    --cc=linux-nfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.