From mboxrd@z Thu Jan 1 00:00:00 1970 From: khilman@baylibre.com (Kevin Hilman) Date: Tue, 06 Dec 2016 16:47:41 -0800 Subject: [PATCH] pinctrl: meson: fix gpio request disabling other modes In-Reply-To: <20161206140817.11708-1-narmstrong@baylibre.com> (Neil Armstrong's message of "Tue, 6 Dec 2016 15:08:16 +0100") References: <20161206140817.11708-1-narmstrong@baylibre.com> Message-ID: To: linus-amlogic@lists.infradead.org List-Id: linus-amlogic.lists.infradead.org Neil Armstrong writes: > The pinctrl_gpio_request is called with the "full" gpio number, already > containing the base, then meson_pmx_request_gpio is then called with the > final pin number. > Remove the base addition when calling meson_pmx_disable_other_groups. > > Fixes: 6ac730951104 ("pinctrl: add driver for Amlogic Meson SoCs") > CC: Beniamino Galvani > Signed-off-by: Neil Armstrong Acked-by: Kevin Hilman From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kevin Hilman Subject: Re: [PATCH] pinctrl: meson: fix gpio request disabling other modes Date: Tue, 06 Dec 2016 16:47:41 -0800 Message-ID: References: <20161206140817.11708-1-narmstrong@baylibre.com> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from mail-pf0-f173.google.com ([209.85.192.173]:35953 "EHLO mail-pf0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751180AbcLGArn (ORCPT ); Tue, 6 Dec 2016 19:47:43 -0500 Received: by mail-pf0-f173.google.com with SMTP id 189so73347021pfz.3 for ; Tue, 06 Dec 2016 16:47:43 -0800 (PST) In-Reply-To: <20161206140817.11708-1-narmstrong@baylibre.com> (Neil Armstrong's message of "Tue, 6 Dec 2016 15:08:16 +0100") Sender: linux-gpio-owner@vger.kernel.org List-Id: linux-gpio@vger.kernel.org To: Neil Armstrong Cc: linus.walleij@linaro.org, carlo@caione.org, linux-gpio@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Beniamino Galvani Neil Armstrong writes: > The pinctrl_gpio_request is called with the "full" gpio number, already > containing the base, then meson_pmx_request_gpio is then called with the > final pin number. > Remove the base addition when calling meson_pmx_disable_other_groups. > > Fixes: 6ac730951104 ("pinctrl: add driver for Amlogic Meson SoCs") > CC: Beniamino Galvani > Signed-off-by: Neil Armstrong Acked-by: Kevin Hilman From mboxrd@z Thu Jan 1 00:00:00 1970 From: khilman@baylibre.com (Kevin Hilman) Date: Tue, 06 Dec 2016 16:47:41 -0800 Subject: [PATCH] pinctrl: meson: fix gpio request disabling other modes In-Reply-To: <20161206140817.11708-1-narmstrong@baylibre.com> (Neil Armstrong's message of "Tue, 6 Dec 2016 15:08:16 +0100") References: <20161206140817.11708-1-narmstrong@baylibre.com> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Neil Armstrong writes: > The pinctrl_gpio_request is called with the "full" gpio number, already > containing the base, then meson_pmx_request_gpio is then called with the > final pin number. > Remove the base addition when calling meson_pmx_disable_other_groups. > > Fixes: 6ac730951104 ("pinctrl: add driver for Amlogic Meson SoCs") > CC: Beniamino Galvani > Signed-off-by: Neil Armstrong Acked-by: Kevin Hilman