From mboxrd@z Thu Jan 1 00:00:00 1970 From: khilman@baylibre.com (Kevin Hilman) Date: Wed, 23 Nov 2016 14:32:05 -0800 Subject: [PATCH v2] ARM: dts: da850: add the mstpri and ddrctl nodes In-Reply-To: <5e647eb0-2f8a-b46b-2048-7616bfb54ad7@lechnology.com> (David Lechner's message of "Wed, 23 Nov 2016 10:19:53 -0600") References: <1479207611-18028-1-git-send-email-bgolaszewski@baylibre.com> <5e647eb0-2f8a-b46b-2048-7616bfb54ad7@lechnology.com> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org David Lechner writes: > On 11/23/2016 04:27 AM, Bartosz Golaszewski wrote: >> 2016-11-22 23:23 GMT+01:00 David Lechner : >>> On 11/15/2016 05:00 AM, Bartosz Golaszewski wrote: >>>> >>>> Add the nodes for the MSTPRI configuration and DDR2/mDDR memory >>>> controller drivers to da850.dtsi. >>>> >>>> Signed-off-by: Bartosz Golaszewski >>>> --- >>>> v1 -> v2: >>>> - moved the priority controller node above the cfgchip node >>>> - renamed added nodes to better reflect their purpose >>>> >>>> arch/arm/boot/dts/da850.dtsi | 8 ++++++++ >>>> 1 file changed, 8 insertions(+) >>>> >>>> diff --git a/arch/arm/boot/dts/da850.dtsi b/arch/arm/boot/dts/da850.dtsi >>>> index 1bb1f6d..412eec6 100644 >>>> --- a/arch/arm/boot/dts/da850.dtsi >>>> +++ b/arch/arm/boot/dts/da850.dtsi >>>> @@ -210,6 +210,10 @@ >>>> }; >>>> >>>> }; >>>> + prictrl: priority-controller at 14110 { >>>> + compatible = "ti,da850-mstpri"; >>>> + reg = <0x14110 0x0c>; >>> >>> >>> I think we should add status = "disabled"; here and let boards opt in. >>> >>>> + }; >>>> cfgchip: chip-controller at 1417c { >>>> compatible = "ti,da830-cfgchip", "syscon", >>>> "simple-mfd"; >>>> reg = <0x1417c 0x14>; >>>> @@ -451,4 +455,8 @@ >>>> 1 0 0x68000000 0x00008000>; >>>> status = "disabled"; >>>> }; >>>> + memctrl: memory-controller at b0000000 { >>>> + compatible = "ti,da850-ddr-controller"; >>>> + reg = <0xb0000000 0xe8>; >>> >>> >>> same here. status = "disabled"; >>> >>>> + }; >>>> }; >>>> >> >> Hi David, >> >> I did that initially[1][2] and it was rejected by Kevin[3] and Laurent[4]. >> >> FYI this patch has already been queued by Sekhar. > > Thanks. I did not see those threads. > > FYI to maintainers, having these enabled by default causes error > messages in the kernel log for other boards that are not supported by > the drivers. Then the driver is too noisy and should be cleaned up. > Since there is only one board that is supported and soon > to be 2 that are not, I would rather have this disabled by default to > avoid the error messages. IMO, what exactly are the error messages? Sounds like the driver is being too verbose, and calling things errors that are not really errors. Kevin From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kevin Hilman Subject: Re: [PATCH v2] ARM: dts: da850: add the mstpri and ddrctl nodes Date: Wed, 23 Nov 2016 14:32:05 -0800 Message-ID: References: <1479207611-18028-1-git-send-email-bgolaszewski@baylibre.com> <5e647eb0-2f8a-b46b-2048-7616bfb54ad7@lechnology.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <5e647eb0-2f8a-b46b-2048-7616bfb54ad7@lechnology.com> (David Lechner's message of "Wed, 23 Nov 2016 10:19:53 -0600") List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: David Lechner Cc: Mark Rutland , linux-devicetree , Tomi Valkeinen , Michael Turquette , Sekhar Nori , Russell King , linux-drm , LKML , Peter Ujfalusi , Bartosz Golaszewski , Rob Herring , Jyri Sarha , Frank Rowand , arm-soc , Laurent Pinchart List-Id: devicetree@vger.kernel.org RGF2aWQgTGVjaG5lciA8ZGF2aWRAbGVjaG5vbG9neS5jb20+IHdyaXRlczoKCj4gT24gMTEvMjMv MjAxNiAwNDoyNyBBTSwgQmFydG9zeiBHb2xhc3pld3NraSB3cm90ZToKPj4gMjAxNi0xMS0yMiAy MzoyMyBHTVQrMDE6MDAgRGF2aWQgTGVjaG5lciA8ZGF2aWRAbGVjaG5vbG9neS5jb20+Ogo+Pj4g T24gMTEvMTUvMjAxNiAwNTowMCBBTSwgQmFydG9zeiBHb2xhc3pld3NraSB3cm90ZToKPj4+Pgo+ Pj4+IEFkZCB0aGUgbm9kZXMgZm9yIHRoZSBNU1RQUkkgY29uZmlndXJhdGlvbiBhbmQgRERSMi9t RERSIG1lbW9yeQo+Pj4+IGNvbnRyb2xsZXIgZHJpdmVycyB0byBkYTg1MC5kdHNpLgo+Pj4+Cj4+ Pj4gU2lnbmVkLW9mZi1ieTogQmFydG9zeiBHb2xhc3pld3NraSA8YmdvbGFzemV3c2tpQGJheWxp YnJlLmNvbT4KPj4+PiAtLS0KPj4+PiB2MSAtPiB2MjoKPj4+PiAtIG1vdmVkIHRoZSBwcmlvcml0 eSBjb250cm9sbGVyIG5vZGUgYWJvdmUgdGhlIGNmZ2NoaXAgbm9kZQo+Pj4+IC0gcmVuYW1lZCBh ZGRlZCBub2RlcyB0byBiZXR0ZXIgcmVmbGVjdCB0aGVpciBwdXJwb3NlCj4+Pj4KPj4+PiAgYXJj aC9hcm0vYm9vdC9kdHMvZGE4NTAuZHRzaSB8IDggKysrKysrKysKPj4+PiAgMSBmaWxlIGNoYW5n ZWQsIDggaW5zZXJ0aW9ucygrKQo+Pj4+Cj4+Pj4gZGlmZiAtLWdpdCBhL2FyY2gvYXJtL2Jvb3Qv ZHRzL2RhODUwLmR0c2kgYi9hcmNoL2FybS9ib290L2R0cy9kYTg1MC5kdHNpCj4+Pj4gaW5kZXgg MWJiMWY2ZC4uNDEyZWVjNiAxMDA2NDQKPj4+PiAtLS0gYS9hcmNoL2FybS9ib290L2R0cy9kYTg1 MC5kdHNpCj4+Pj4gKysrIGIvYXJjaC9hcm0vYm9vdC9kdHMvZGE4NTAuZHRzaQo+Pj4+IEBAIC0y MTAsNiArMjEwLDEwIEBACj4+Pj4gICAgICAgICAgICAgICAgICAgICAgICAgfTsKPj4+Pgo+Pj4+ ICAgICAgICAgICAgICAgICB9Owo+Pj4+ICsgICAgICAgICAgICAgICBwcmljdHJsOiBwcmlvcml0 eS1jb250cm9sbGVyQDE0MTEwIHsKPj4+PiArICAgICAgICAgICAgICAgICAgICAgICBjb21wYXRp YmxlID0gInRpLGRhODUwLW1zdHByaSI7Cj4+Pj4gKyAgICAgICAgICAgICAgICAgICAgICAgcmVn ID0gPDB4MTQxMTAgMHgwYz47Cj4+Pgo+Pj4KPj4+IEkgdGhpbmsgd2Ugc2hvdWxkIGFkZCBzdGF0 dXMgPSAiZGlzYWJsZWQiOyBoZXJlIGFuZCBsZXQgYm9hcmRzIG9wdCBpbi4KPj4+Cj4+Pj4gKyAg ICAgICAgICAgICAgIH07Cj4+Pj4gICAgICAgICAgICAgICAgIGNmZ2NoaXA6IGNoaXAtY29udHJv bGxlckAxNDE3YyB7Cj4+Pj4gICAgICAgICAgICAgICAgICAgICAgICAgY29tcGF0aWJsZSA9ICJ0 aSxkYTgzMC1jZmdjaGlwIiwgInN5c2NvbiIsCj4+Pj4gInNpbXBsZS1tZmQiOwo+Pj4+ICAgICAg ICAgICAgICAgICAgICAgICAgIHJlZyA9IDwweDE0MTdjIDB4MTQ+Owo+Pj4+IEBAIC00NTEsNCAr NDU1LDggQEAKPj4+PiAgICAgICAgICAgICAgICAgICAgICAgICAgIDEgMCAweDY4MDAwMDAwIDB4 MDAwMDgwMDA+Owo+Pj4+ICAgICAgICAgICAgICAgICBzdGF0dXMgPSAiZGlzYWJsZWQiOwo+Pj4+ ICAgICAgICAgfTsKPj4+PiArICAgICAgIG1lbWN0cmw6IG1lbW9yeS1jb250cm9sbGVyQGIwMDAw MDAwIHsKPj4+PiArICAgICAgICAgICAgICAgY29tcGF0aWJsZSA9ICJ0aSxkYTg1MC1kZHItY29u dHJvbGxlciI7Cj4+Pj4gKyAgICAgICAgICAgICAgIHJlZyA9IDwweGIwMDAwMDAwIDB4ZTg+Owo+ Pj4KPj4+Cj4+PiBzYW1lIGhlcmUuIHN0YXR1cyA9ICJkaXNhYmxlZCI7Cj4+Pgo+Pj4+ICsgICAg ICAgfTsKPj4+PiAgfTsKPj4+Pgo+Pgo+PiBIaSBEYXZpZCwKPj4KPj4gSSBkaWQgdGhhdCBpbml0 aWFsbHlbMV1bMl0gYW5kIGl0IHdhcyByZWplY3RlZCBieSBLZXZpblszXSBhbmQgTGF1cmVudFs0 XS4KPj4KPj4gRllJIHRoaXMgcGF0Y2ggaGFzIGFscmVhZHkgYmVlbiBxdWV1ZWQgYnkgU2VraGFy Lgo+Cj4gVGhhbmtzLiBJIGRpZCBub3Qgc2VlIHRob3NlIHRocmVhZHMuCj4KPiBGWUkgdG8gbWFp bnRhaW5lcnMsIGhhdmluZyB0aGVzZSBlbmFibGVkIGJ5IGRlZmF1bHQgY2F1c2VzIGVycm9yCj4g bWVzc2FnZXMgaW4gdGhlIGtlcm5lbCBsb2cgZm9yIG90aGVyIGJvYXJkcyB0aGF0IGFyZSBub3Qg c3VwcG9ydGVkIGJ5Cj4gdGhlIGRyaXZlcnMuCgpUaGVuIHRoZSBkcml2ZXIgaXMgdG9vIG5vaXN5 IGFuZCBzaG91bGQgYmUgY2xlYW5lZCB1cC4KCj4gU2luY2UgdGhlcmUgaXMgb25seSBvbmUgYm9h cmQgdGhhdCBpcyBzdXBwb3J0ZWQgYW5kIHNvb24KPiB0byBiZSAyIHRoYXQgYXJlIG5vdCwgSSB3 b3VsZCByYXRoZXIgaGF2ZSB0aGlzIGRpc2FibGVkIGJ5IGRlZmF1bHQgdG8KPiBhdm9pZCB0aGUg ZXJyb3IgbWVzc2FnZXMuCgpJTU8sIHdoYXQgZXhhY3RseSBhcmUgdGhlIGVycm9yIG1lc3NhZ2Vz PyBTb3VuZHMgbGlrZSB0aGUgZHJpdmVyIGlzCmJlaW5nIHRvbyB2ZXJib3NlLCBhbmQgY2FsbGlu ZyB0aGluZ3MgZXJyb3JzIHRoYXQgYXJlIG5vdCByZWFsbHkgZXJyb3JzLgoKS2V2aW4KX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxp bmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJl ZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933488AbcKWWcN (ORCPT ); Wed, 23 Nov 2016 17:32:13 -0500 Received: from mail-pg0-f45.google.com ([74.125.83.45]:36713 "EHLO mail-pg0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934325AbcKWWcJ (ORCPT ); Wed, 23 Nov 2016 17:32:09 -0500 From: Kevin Hilman To: David Lechner Cc: Bartosz Golaszewski , Michael Turquette , Sekhar Nori , Rob Herring , Frank Rowand , Mark Rutland , Peter Ujfalusi , Russell King , linux-devicetree , David Airlie , LKML , linux-drm , Tomi Valkeinen , Jyri Sarha , arm-soc , Laurent Pinchart Subject: Re: [PATCH v2] ARM: dts: da850: add the mstpri and ddrctl nodes Organization: BayLibre References: <1479207611-18028-1-git-send-email-bgolaszewski@baylibre.com> <5e647eb0-2f8a-b46b-2048-7616bfb54ad7@lechnology.com> Date: Wed, 23 Nov 2016 14:32:05 -0800 In-Reply-To: <5e647eb0-2f8a-b46b-2048-7616bfb54ad7@lechnology.com> (David Lechner's message of "Wed, 23 Nov 2016 10:19:53 -0600") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (darwin) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org David Lechner writes: > On 11/23/2016 04:27 AM, Bartosz Golaszewski wrote: >> 2016-11-22 23:23 GMT+01:00 David Lechner : >>> On 11/15/2016 05:00 AM, Bartosz Golaszewski wrote: >>>> >>>> Add the nodes for the MSTPRI configuration and DDR2/mDDR memory >>>> controller drivers to da850.dtsi. >>>> >>>> Signed-off-by: Bartosz Golaszewski >>>> --- >>>> v1 -> v2: >>>> - moved the priority controller node above the cfgchip node >>>> - renamed added nodes to better reflect their purpose >>>> >>>> arch/arm/boot/dts/da850.dtsi | 8 ++++++++ >>>> 1 file changed, 8 insertions(+) >>>> >>>> diff --git a/arch/arm/boot/dts/da850.dtsi b/arch/arm/boot/dts/da850.dtsi >>>> index 1bb1f6d..412eec6 100644 >>>> --- a/arch/arm/boot/dts/da850.dtsi >>>> +++ b/arch/arm/boot/dts/da850.dtsi >>>> @@ -210,6 +210,10 @@ >>>> }; >>>> >>>> }; >>>> + prictrl: priority-controller@14110 { >>>> + compatible = "ti,da850-mstpri"; >>>> + reg = <0x14110 0x0c>; >>> >>> >>> I think we should add status = "disabled"; here and let boards opt in. >>> >>>> + }; >>>> cfgchip: chip-controller@1417c { >>>> compatible = "ti,da830-cfgchip", "syscon", >>>> "simple-mfd"; >>>> reg = <0x1417c 0x14>; >>>> @@ -451,4 +455,8 @@ >>>> 1 0 0x68000000 0x00008000>; >>>> status = "disabled"; >>>> }; >>>> + memctrl: memory-controller@b0000000 { >>>> + compatible = "ti,da850-ddr-controller"; >>>> + reg = <0xb0000000 0xe8>; >>> >>> >>> same here. status = "disabled"; >>> >>>> + }; >>>> }; >>>> >> >> Hi David, >> >> I did that initially[1][2] and it was rejected by Kevin[3] and Laurent[4]. >> >> FYI this patch has already been queued by Sekhar. > > Thanks. I did not see those threads. > > FYI to maintainers, having these enabled by default causes error > messages in the kernel log for other boards that are not supported by > the drivers. Then the driver is too noisy and should be cleaned up. > Since there is only one board that is supported and soon > to be 2 that are not, I would rather have this disabled by default to > avoid the error messages. IMO, what exactly are the error messages? Sounds like the driver is being too verbose, and calling things errors that are not really errors. Kevin