From: Chris Ball <cjb@laptop.org>
To: Jaehoon Chung <jh80.chung@samsung.com>
Cc: "linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
Ben Dooks <ben-linux@fluff.org>,
Kyungmin Park <kyungmin.park@samsung.com>
Subject: Re: [PATCH] mmc: sdhci-s3c: add quirk about BROKEN_ADMA_ZEROLEN_DESC
Date: Thu, 28 Jul 2011 18:28:55 -0400 [thread overview]
Message-ID: <m2bowejazc.fsf@bob.laptop.org> (raw)
In-Reply-To: <4E1C0637.2090603@samsung.com> (Jaehoon Chung's message of "Tue, 12 Jul 2011 17:30:47 +0900")
Hi Jaehoon,
On Tue, Jul 12 2011, Jaehoon Chung wrote:
> This patch is added the quirk for Samsung SoCs.
>
> Samsung SoCs need to set QUIRK_BROKEN_ADMA_ZEROLEN_DESC.
> (If ADMA operation is more than 65535, maybe set by zero.)
>
> Signed-off-by: Jaehoon Chung <jh80.chung@samsung.com>
> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
> ---
> drivers/mmc/host/sdhci-s3c.c | 3 +++
> 1 files changed, 3 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/mmc/host/sdhci-s3c.c b/drivers/mmc/host/sdhci-s3c.c
> index 460ffaf..03da44a 100644
> --- a/drivers/mmc/host/sdhci-s3c.c
> +++ b/drivers/mmc/host/sdhci-s3c.c
> @@ -502,6 +502,9 @@ static int __devinit sdhci_s3c_probe(struct platform_device *pdev)
> /* This host supports the Auto CMD12 */
> host->quirks |= SDHCI_QUIRK_MULTIBLOCK_READ_ACMD12;
>
> + /* Samsung SoCs need BROKEN_ADMA_ZEROLEN_DESC */
> + host->quirks |= SDHCI_QUIRK_BROKEN_ADMA_ZEROLEN_DESC;
> +
> if (pdata->cd_type == S3C_SDHCI_CD_NONE ||
> pdata->cd_type == S3C_SDHCI_CD_PERMANENT)
> host->quirks |= SDHCI_QUIRK_BROKEN_CARD_DETECTION;
Pushed to mmc-next for 3.1, thanks.
- Chris.
--
Chris Ball <cjb@laptop.org> <http://printf.net/>
One Laptop Per Child
prev parent reply other threads:[~2011-07-28 22:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-12 8:30 [PATCH] mmc: sdhci-s3c: add quirk about BROKEN_ADMA_ZEROLEN_DESC Jaehoon Chung
2011-07-13 4:13 ` Seungwon Jeon
2011-07-13 4:18 ` Philip Rakity
2011-07-28 22:28 ` Chris Ball [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2bowejazc.fsf@bob.laptop.org \
--to=cjb@laptop.org \
--cc=ben-linux@fluff.org \
--cc=jh80.chung@samsung.com \
--cc=kyungmin.park@samsung.com \
--cc=linux-mmc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.