All of lore.kernel.org
 help / color / mirror / Atom feed
From: Detlev Zundel <dzu@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] Policy for checkpatch usage?
Date: Thu, 21 Apr 2011 17:19:47 +0200	[thread overview]
Message-ID: <m2bozzeing.fsf@ohwell.denx.de> (raw)
In-Reply-To: <5.2.0.9.1.20110421165402.04b12a50@localhost> (Fabian Cenedese's message of "Thu, 21 Apr 2011 16:56:36 +0200")

Hi Fabi,

> At 10:49 21.04.2011 -0400, Eric Cooper wrote:
>>On Thu, Apr 21, 2011 at 04:29:17PM +0200, Detlev Zundel wrote:
>>> What about the problem with checkpatch errors in current code, i.e. the
>>> origin of this sentence:
>>> 
>>>   Also warnings produced for context lines (i.e. existing code) rather
>>>   than actual changes can also be ignored.
>>
>>How about replacing it with this:
>>
>>    If you encounter warnings for existing code, not modified by your
>>    patch, consider submitting a separate, cosmetic-only patch --
>>    clearly described as such -- that *precedes* your substantive
>>    patch.
>
> Is that even possible? The cosmetic patch itself will be surrounded
> by context lines which may fire up a warning. So these lines need
> to be changed as well to satisy checkpatch. But this new patch
> will again include several context lines... until you have to fix up the
> whole file. Or did I misunderstand?

It may become an iterative process.  Fortunately our source files are
finite, so this process has a fixpoint ;)

Cheers
  Detlev

-- 
debian is a prototype for a future version of emacs.
                         -- Thien-Thi Nguyen in <7eekubiffq.fsf@ada2.unipv.it>
--
DENX Software Engineering GmbH,      MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich,  Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-40 Fax: (+49)-8142-66989-80 Email: dzu at denx.de

  parent reply	other threads:[~2011-04-21 15:19 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-04-20  9:24 [U-Boot] Policy for checkpatch usage? Detlev Zundel
2011-04-20 10:15 ` Graeme Russ
2011-04-20 12:43   ` Graeme Russ
2011-04-20 13:40     ` Detlev Zundel
2011-04-20 13:38   ` Detlev Zundel
2011-04-20 16:51   ` Scott Wood
2011-04-21  0:09     ` Graeme Russ
2011-04-21  5:18       ` Wolfgang Denk
2011-04-21 14:24         ` Detlev Zundel
2011-04-21 14:29     ` Detlev Zundel
2011-04-21 14:49       ` Eric Cooper
2011-04-21 14:56         ` Fabian Cenedese
2011-04-21 15:04           ` Eric Cooper
2011-04-21 15:37             ` Detlev Zundel
2011-04-21 15:19           ` Detlev Zundel [this message]
2011-04-21 15:46         ` Detlev Zundel
2011-04-23 15:29           ` Andreas Pretzsch
2011-04-27  9:07             ` Detlev Zundel
2011-04-21 16:10       ` Scott Wood
2011-04-22  0:43         ` Graeme Russ
2011-04-22  6:18           ` Albert ARIBAUD
2011-04-22 10:56             ` Graeme Russ
2011-04-22  8:54           ` Wolfgang Denk
2011-04-22 10:52             ` Graeme Russ
2011-04-22 12:46               ` Wolfgang Denk
2011-04-25  5:37                 ` Graeme Russ

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m2bozzeing.fsf@ohwell.denx.de \
    --to=dzu@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.