From: Darren Kenny <darren.kenny@oracle.com>
To: Alexander Bulekov <alxndr@bu.edu>, qemu-devel@nongnu.org
Cc: peter.maydell@linaro.org, Alexander Bulekov <alxndr@bu.edu>,
Paolo Bonzini <pbonzini@redhat.com>, Bandan Das <bsd@redhat.com>,
Stefan Hajnoczi <stefanha@redhat.com>,
Thomas Huth <thuth@redhat.com>, Qiuhao Li <Qiuhao.Li@outlook.com>,
Laurent Vivier <lvivier@redhat.com>
Subject: Re: [PULL 02/10] fuzz: add fuzz_reset API
Date: Fri, 17 Feb 2023 10:48:33 +0000 [thread overview]
Message-ID: <m2cz68efem.fsf@oracle.com> (raw)
In-Reply-To: <20230217040855.16873-3-alxndr@bu.edu>
I know this is a pull request, but if you prefer to have all the patches
with and R-b, you can add mine here too, but I'll leave it up to you.
Reviewed-by: Darren Kenny <darren.kenny@oracle.com>
Thanks,
Darren.
On Thursday, 2023-02-16 at 23:08:47 -05, Alexander Bulekov wrote:
> As we are converting most fuzzers to rely on reboots to reset state,
> introduce an API to make sure reboots are invoked in a consistent
> manner.
>
> Signed-off-by: Alexander Bulekov <alxndr@bu.edu>
> ---
> tests/qtest/fuzz/fuzz.c | 6 ++++++
> tests/qtest/fuzz/fuzz.h | 2 +-
> 2 files changed, 7 insertions(+), 1 deletion(-)
>
> diff --git a/tests/qtest/fuzz/fuzz.c b/tests/qtest/fuzz/fuzz.c
> index eb7520544b..3bedb81b32 100644
> --- a/tests/qtest/fuzz/fuzz.c
> +++ b/tests/qtest/fuzz/fuzz.c
> @@ -51,6 +51,12 @@ void flush_events(QTestState *s)
> }
> }
>
> +void fuzz_reset(QTestState *s)
> +{
> + qemu_system_reset(SHUTDOWN_CAUSE_GUEST_RESET);
> + main_loop_wait(true);
> +}
> +
> static QTestState *qtest_setup(void)
> {
> qtest_server_set_send_handler(&qtest_client_inproc_recv, &fuzz_qts);
> diff --git a/tests/qtest/fuzz/fuzz.h b/tests/qtest/fuzz/fuzz.h
> index 327c1c5a55..21d1362d65 100644
> --- a/tests/qtest/fuzz/fuzz.h
> +++ b/tests/qtest/fuzz/fuzz.h
> @@ -103,7 +103,7 @@ typedef struct FuzzTarget {
> } FuzzTarget;
>
> void flush_events(QTestState *);
> -void reboot(QTestState *);
> +void fuzz_reset(QTestState *);
>
> /* Use the QTest ASCII protocol or call address_space API directly?*/
> void fuzz_qtest_set_serialize(bool option);
> --
> 2.39.0
next prev parent reply other threads:[~2023-02-17 10:49 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-17 4:08 [PULL 00/10] Replace fork-based fuzzing with reboots Alexander Bulekov
2023-02-17 4:08 ` [PULL 01/10] hw/sparse-mem: clear memory on reset Alexander Bulekov
2023-02-17 4:08 ` [PULL 02/10] fuzz: add fuzz_reset API Alexander Bulekov
2023-02-17 10:48 ` Darren Kenny [this message]
2023-02-17 14:47 ` Alexander Bulekov
2023-02-17 4:08 ` [PULL 03/10] fuzz/generic-fuzz: use reboots instead of forks to reset state Alexander Bulekov
2023-02-17 4:08 ` [PULL 04/10] fuzz/generic-fuzz: add a limit on DMA bytes written Alexander Bulekov
2023-02-17 4:08 ` [PULL 05/10] fuzz/virtio-scsi: remove fork-based fuzzer Alexander Bulekov
2023-02-17 4:08 ` [PULL 06/10] fuzz/virtio-net: " Alexander Bulekov
2023-02-17 4:08 ` [PULL 07/10] fuzz/virtio-blk: " Alexander Bulekov
2023-02-17 4:08 ` [PULL 08/10] fuzz/i440fx: " Alexander Bulekov
2023-02-17 4:08 ` [PULL 09/10] fuzz: remove fork-fuzzing scaffolding Alexander Bulekov
2023-02-17 4:08 ` [PULL 10/10] docs/fuzz: remove mentions of fork-based fuzzing Alexander Bulekov
2023-02-21 13:14 ` [PULL 00/10] Replace fork-based fuzzing with reboots Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2cz68efem.fsf@oracle.com \
--to=darren.kenny@oracle.com \
--cc=Qiuhao.Li@outlook.com \
--cc=alxndr@bu.edu \
--cc=bsd@redhat.com \
--cc=lvivier@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.