From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1nx76L-0004MC-Sh for mharc-grub-devel@gnu.org; Fri, 03 Jun 2022 09:12:30 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:36056) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nx76C-0004Kl-L6 for grub-devel@gnu.org; Fri, 03 Jun 2022 09:12:20 -0400 Received: from mx0a-00069f02.pphosted.com ([205.220.165.32]:20430) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nx766-000341-Kh for grub-devel@gnu.org; Fri, 03 Jun 2022 09:12:20 -0400 Received: from pps.filterd (m0246627.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 253CFj1f022182 for ; Fri, 3 Jun 2022 13:12:07 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : cc : subject : in-reply-to : references : date : message-id : content-type : mime-version; s=corp-2021-07-09; bh=FSJ5EF24GUzmCU/BVgl1in3VniD0M+7Rnw/fFwKdsa4=; b=JZiIByXeiqw3sXMsS5LOMZ9+CbuYTXHw6R8p8TC0UyADNL7kOhtlxuqJxAnj5WU2WyP1 DwEWhp4QIuRpQUwsB27RBYBNO4FBoZr1DSDhR1ngJ2thLU0hrfW/v2/OVbriJIDKa66P JeffcXaYtES3N4Mr3UarlrJmXIw5BQ+k7lEYLAatAaP+f3ToThNh4Aqro5pekG7kMC4q UDu/RnOvrifOmS2qOBYQ/QUtJl2r+YBTCPwNG71ISnUo/t+cvdUABtO8cFWNe5YfGapT BVRNoSfp98z5tPVJobmAVhICwWOeGtK7rs7aUD5hYmCrurKEQ9bGvuLJ8Aw+odS5acVV aQ== Received: from iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta01.appoci.oracle.com [130.35.100.223]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3gf8rws3d2-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Fri, 03 Jun 2022 13:12:07 +0000 Received: from pps.filterd (iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (8.16.1.2/8.16.1.2) with SMTP id 253DBvte011784 for ; Fri, 3 Jun 2022 13:12:05 GMT Received: from nam11-dm6-obe.outbound.protection.outlook.com (mail-dm6nam11lp2174.outbound.protection.outlook.com [104.47.57.174]) by iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com with ESMTP id 3gc8k2cxbs-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Fri, 03 Jun 2022 13:12:05 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=K7EckeNOAtV4x6P4wOad4P4JnpNsbqf/4oXK9Su6yNqkFrT6SpOItUakywJJty/Q+iu1X7m7svm9geIp0UY8rkbVSpMJ9XWFcat3bdjeAW40mN033y4P5MgQf3ZVtoeiD1B1CzySk5pfAKjVOmRG6Me5xGMC4DF0c0e+of+4VHoSjDjgG6LglDeDKYdspuFdBo9JTVUsM1km5lYFfDgY6yFcBbLzDfa8L1Zm6cE23GJULTJF2zqvf83Lc2giNzor61urYMaOOmGRH6fl9q7Z/PLhTOhMfNMjJ1ckJCzYkFpNO6RgzU081ExiWkfBeVT12UNa3vCT4dzp3IeFbYEFIw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=FSJ5EF24GUzmCU/BVgl1in3VniD0M+7Rnw/fFwKdsa4=; b=McDzGIX+eZwzY0N/BkZipEeXFExPmJC1vZd0pKhArAVNxUVjVct9cX2SBR5nwfebO9ccOXjbiOlg8//dfl6TOqqToAAGSlHKtORZ19jRvm4KDa6Y+2RqckXaqmNTiOUoOWUQItGmXTWBiLOsU7RBot9rV0Lof/SLEfMADuTv8FMqeigzPflQz0NrdHIvhD5pHJXP9cJVhh0J0kc03V+xPsueYPamgHkwfvg16+MofkAYe7Pu+AlUvI0dLjvZz5/U22h3ko6r9jKgNPyZ8cTVNJLy4PoCb0RntYImDJR1sFrOluL81M700xNi47FLM+hMg15j5UCP4eetKSOxQIw+/w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=FSJ5EF24GUzmCU/BVgl1in3VniD0M+7Rnw/fFwKdsa4=; b=KEeSxbGoLeZIG9sNzwvfadIeH0SW+/DZRNVVrJnLvzy7hGTGd0kJxmz9Ap6W7sPkg09DqLufwu1hJONJxrESkIVhRUqolVCt2DWHDWjfsRWk9ebbmkrt5/IlqWn356Sc9Nt0J4Ci/pDwSNL+A4bTX8v/laPhlZtfwBiU0+EHEO4= Received: from BLAPR10MB5138.namprd10.prod.outlook.com (2603:10b6:208:322::8) by BN6PR10MB1378.namprd10.prod.outlook.com (2603:10b6:404:44::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5293.18; Fri, 3 Jun 2022 13:12:04 +0000 Received: from BLAPR10MB5138.namprd10.prod.outlook.com ([fe80::94bf:816a:120e:37e7]) by BLAPR10MB5138.namprd10.prod.outlook.com ([fe80::94bf:816a:120e:37e7%9]) with mapi id 15.20.5314.016; Fri, 3 Jun 2022 13:12:04 +0000 From: Darren Kenny To: Jagannathan Raman , grub-devel@gnu.org Cc: daniel.kiper@oracle.com, alec.r.brown@oracle.com Subject: Re: GRUB coverity fixes for CIDs 314020 and 314023 In-Reply-To: References: Date: Fri, 03 Jun 2022 14:12:00 +0100 Message-ID: Content-Type: text/plain X-ClientProxiedBy: DB7PR05CA0067.eurprd05.prod.outlook.com (2603:10a6:10:2e::44) To BLAPR10MB5138.namprd10.prod.outlook.com (2603:10b6:208:322::8) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 40a4f788-d0bc-4a71-ccc0-08da4562a712 X-MS-TrafficTypeDiagnostic: BN6PR10MB1378:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: BfsalPmuoPjWk1X3RT8BoYtQQqIePAD7TdW3UBa/NMEIJIARfNoc/ulWeMs29KtrQF4oomiOgQfge7iaf6M1LbYB6SBd/E+mjLA7UixzZwcTGpPf22DKaxF9xycQ6C4k3cm2v6rkSdb+Z+64+JlgNDIuSVnQB95lRiStrSMDhVGjk3QzbbNvC5sTYkBvSD7qfriE7jZQir8xHyJx8L46JfUtZ9dLwcQwRS/fz9U2DjatzMR0Pb5ARxbdvKOjj3BiT1vaAxX313OLVQxJ1h5XlaQvTqL4UNqKrRI+YzeFjzke6RR6oiC/SWlE7jYqSOejlNBXnDRxkQrAmtLvsNMTcQaPEOaWtSF5R5lk1x8ZIvdSnwLWVdTaLo0+KsRgM8JoRCVl3Al4LCV70NjMVnSgit+EKwWuq+jzHoNL8YoaQi2RZl76rBA3f/0qw2knCfg2LFlPBGawlaT3Jyq2dfTekIpMSrIv9uqclS15dysqtuUUHPrtqzVXUrZnEDBoLigSAHnrqBGDdnEbtPt/kFhBm3IjKLc47/bf+dflXTqygQncD95x26tF86tC75nv7S8uowGxyYfk7bqBc31AVvGV1fuv7B3yDbKw4TLQbQmzd2XOZpBSl8D6aUj2zD5NTZAnFPAQH8PKU68cHPbhVu8IAw== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BLAPR10MB5138.namprd10.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(107886003)(36756003)(83380400001)(44832011)(186003)(8936002)(508600001)(2616005)(316002)(86362001)(6486002)(8676002)(66476007)(66556008)(4326008)(4744005)(66946007)(26005)(6506007)(5660300002)(6666004)(2906002)(38100700002)(6512007); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?y4pDfe/v2W3IQlMwbKN8HnOoKgOhgebIKRouXZDDLsFYD47dkVC+HQQ5cvi7?= =?us-ascii?Q?wjzPpb0pOGXQbOQwI28G/b82wxwXuP6G3cII5c4IXaBoXiiilbM3sUVw8GpY?= =?us-ascii?Q?7lYkR4d+lKTZ0SQuoXFJ7HSlAEZoMbD03Uwq917C658Kun5gnrZGKkyfMrHc?= =?us-ascii?Q?/TCXodpuIkmox4iChF5Hh3otg403zd17Tk3Tnor9AlTSTBxghKkqzNk8cy+s?= =?us-ascii?Q?PN4r1alEZT2ohSSF1r/PKDT3fRC6TW6V/w+5eLgWuJ7j609/c3sN17ztWOA5?= =?us-ascii?Q?c0/LMaMaEea6BDyeRblUx4gdkrsHgMkGw38wNzC8/5QDX65kRepe6Dswisd0?= =?us-ascii?Q?XauYvCLubfX5ApEaYU+Xtn8giUBOM8HeRnV6mVvmEHhE1Dk+x7LaXWbdwz90?= =?us-ascii?Q?NpJ98y3G7JxXGPf4kHRWdi9TDEmPVDJCh8KtXn7vLmWT1/0cvJz1wT/JKGTM?= =?us-ascii?Q?rVONs1U/AWECH7JBwvJFP81U/ZP/m2Sz0trB/RuN7+aZnSHP191CPaA26bkM?= =?us-ascii?Q?RIZD+aTZh6woyn8pxQYLuNEteYcdCCWjpFw7MkgoabdFBI53YCff5LHO7BlQ?= =?us-ascii?Q?Eg4KwTVE5LytH8amqkCeFe9M8UJuy+jrnNbg2Rv+SXyqaE2DeH778UsVgTq+?= =?us-ascii?Q?R5Ir5dH6/FzaUQNW2Z29SRtwdVkhCihmcGEiOHtOKIW1/4oZ1klyRxVLpbq8?= =?us-ascii?Q?3p5Qj0FjMu0cNcXVqa/NEmJnyIYEXGoxZ0yhkdSwtAMDPtLV1PQWtVHe/z2P?= =?us-ascii?Q?UXtyEwDWUBezZ+ZvOE4pdc0iVx8WxXlAsJ94SB6MNJ54I1EM18uFWlweg1Ji?= =?us-ascii?Q?s+DsYDhNM1/mgb204SMvje4B5QQbeQGS9LzApOaU1cEeoiBpVY2C0deia63W?= =?us-ascii?Q?a6b0Sgu7o8TrYRjafN8uOuMKnGLxiHLI7OfpelLMvm27ULtOiAa7YcHyuFey?= =?us-ascii?Q?kxJ3Xbz49Xnb+SFeqYEKep2VwvRLpUJ5kiGngFkh98NuNDxJWN2zelerOpfW?= =?us-ascii?Q?RK5BqcF3aSOTyrV7/syBDHj2c4I2loCC2Wa/hr2s5NuVUy6IzuwuIkZ2r71m?= =?us-ascii?Q?9jqT6AH5FCiAKP4+UzMl0/4PrVfqMWOfoTq199jwSzkRghg6fEWLXCxMykP/?= =?us-ascii?Q?Trxh4+NJuzLEmT/ZVly7/h9LxgCWfPNhPuPTv6bYL/ZumCConumk7lYJcTPu?= =?us-ascii?Q?AE14MhA9uMS0VY9spPCllSNswxcYaJ0g4ozPw6a54lmrSwEDnlgWFzkSv/SE?= =?us-ascii?Q?2FDHvsbGm1GlGAylHSWg826zY8ihsirFNs6H7r+JdnHLxT4Wth3eG2WLZh7B?= =?us-ascii?Q?MrgG5IHQSuyhs0K2/h1TjzoeaZrQ6l6OTDzL9ah4LJrhsavo7uW1AtvviR4q?= =?us-ascii?Q?oNBTKBMosnPMsgYKyxYZOVgklT3aCkzYAH0r75sAQxpZpOdac4gnbqczHGSX?= =?us-ascii?Q?Imk6ILbq9oD/KRThggInq83tzUJuWIRdQYnY+TPBeSBNelfrQa3SOaDHmOxM?= =?us-ascii?Q?vjmaZvrpp7JigUpBmjSRYhlXsoOuNBJaPPyGR7cpKjWtMBvEthhO+zUEGLNj?= =?us-ascii?Q?3/O2SKU3dm6KbZYkrRGzoJAdC4favj2j6JU7JSsn77Dwu05qKE5KGuYZRssf?= =?us-ascii?Q?0gKM3lKSxRlHKaXFe1WJpeZxVVslCwr473FclJboPO3RLHI/0k37FeIXtx+B?= =?us-ascii?Q?U52BHNPNyKT3Lb96lWkrvE+afIvXuMm/ZNykBNLHnDv6kWkuiaHL8J2ULh0y?= =?us-ascii?Q?jofQU6wxkRQBakoNBnaJHg5Sp9EfxW0=3D?= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 40a4f788-d0bc-4a71-ccc0-08da4562a712 X-MS-Exchange-CrossTenant-AuthSource: BLAPR10MB5138.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Jun 2022 13:12:04.0516 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: UqMYdvyQK0C5mqcwC4rIwJgS09OvQpIadBvZjI1Eqx1fsuphjzD9VsM6/JOi7hkxskFmFszybH9Z0Sss+VxHHA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR10MB1378 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.517, 18.0.874 definitions=2022-06-03_04:2022-06-02, 2022-06-03 signatures=0 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 mlxscore=0 suspectscore=0 spamscore=0 phishscore=0 malwarescore=0 bulkscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2204290000 definitions=main-2206030058 X-Proofpoint-GUID: SFqyZYE0mC4vnFDGBqeGiUjJV72K7oX3 X-Proofpoint-ORIG-GUID: SFqyZYE0mC4vnFDGBqeGiUjJV72K7oX3 Received-SPF: pass client-ip=205.220.165.32; envelope-from=darren.kenny@oracle.com; helo=mx0a-00069f02.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 03 Jun 2022 13:12:21 -0000 On Thursday, 2022-06-02 at 15:18:25 UTC, Jagannathan Raman wrote: > Hi, > > This series addresses a couple of untrusted loop bounds flagged by > Coverity in "grub-core/fs/zfs". Both the bugs addressed in this series > are of the same type - caused by downcast of pointer from a strict type > to a less strict type. > > Please share your thoughts on this. > These changes look good to me, thanks for looking at them Jag. Reviewed-by: Darren Kenny Thanks, Darren. > Thank you! > -- > Jag > > Jagannathan Raman (2): > fs/zfs/zfs.c: make_mdn() - avoid pointer downcasting > fs/zfs/zfs.c: zfs_mount() - avoid pointer downcasting > > grub-core/fs/zfs/zfs.c | 16 +++++++--------- > 1 file changed, 7 insertions(+), 9 deletions(-) > > -- > 2.31.1