From mboxrd@z Thu Jan 1 00:00:00 1970 From: khilman@baylibre.com (Kevin Hilman) Date: Mon, 03 Apr 2017 09:07:50 -0700 Subject: [PATCH v2 1/2] pinctrl: meson: meson8b: fix the NAND DQS pins In-Reply-To: <20170401135922.1288-2-martin.blumenstingl@googlemail.com> (Martin Blumenstingl's message of "Sat, 1 Apr 2017 15:59:21 +0200") References: <20170325184350.7677-1-martin.blumenstingl@googlemail.com> <20170401135922.1288-1-martin.blumenstingl@googlemail.com> <20170401135922.1288-2-martin.blumenstingl@googlemail.com> Message-ID: To: linus-amlogic@lists.infradead.org List-Id: linus-amlogic.lists.infradead.org Martin Blumenstingl writes: > The nand_groups table uses different names for the NAND DQS pins than > the GROUP() definition in meson8b_cbus_groups (nand_dqs_0 vs nand_dqs0). > This prevents using the NAND DQS pins in the devicetree. > > Fix this by ensuring that the GROUP() definition and the > meson8b_cbus_groups use the same name for these pins. > > Fixes: 0fefcb6876d0 ("pinctrl: Add support for Meson8b") > Signed-off-by: Martin Blumenstingl Acked-by: Kevin Hilman > --- > drivers/pinctrl/meson/pinctrl-meson8b.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/pinctrl/meson/pinctrl-meson8b.c b/drivers/pinctrl/meson/pinctrl-meson8b.c > index 76f077f18193..f87ef5a0ee6c 100644 > --- a/drivers/pinctrl/meson/pinctrl-meson8b.c > +++ b/drivers/pinctrl/meson/pinctrl-meson8b.c > @@ -739,8 +739,8 @@ static const char * const sdxc_c_groups[] = { > static const char * const nand_groups[] = { > "nand_io", "nand_io_ce0", "nand_io_ce1", > "nand_io_rb0", "nand_ale", "nand_cle", > - "nand_wen_clk", "nand_ren_clk", "nand_dqs0", > - "nand_dqs1" > + "nand_wen_clk", "nand_ren_clk", "nand_dqs_0", > + "nand_dqs_1" > }; > > static const char * const nor_groups[] = { From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kevin Hilman Subject: Re: [PATCH v2 1/2] pinctrl: meson: meson8b: fix the NAND DQS pins Date: Mon, 03 Apr 2017 09:07:50 -0700 Message-ID: References: <20170325184350.7677-1-martin.blumenstingl@googlemail.com> <20170401135922.1288-1-martin.blumenstingl@googlemail.com> <20170401135922.1288-2-martin.blumenstingl@googlemail.com> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from mail-pg0-f44.google.com ([74.125.83.44]:33305 "EHLO mail-pg0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753724AbdDCQH6 (ORCPT ); Mon, 3 Apr 2017 12:07:58 -0400 Received: by mail-pg0-f44.google.com with SMTP id x125so124653314pgb.0 for ; Mon, 03 Apr 2017 09:07:57 -0700 (PDT) In-Reply-To: <20170401135922.1288-2-martin.blumenstingl@googlemail.com> (Martin Blumenstingl's message of "Sat, 1 Apr 2017 15:59:21 +0200") Sender: linux-gpio-owner@vger.kernel.org List-Id: linux-gpio@vger.kernel.org To: Martin Blumenstingl Cc: linux-amlogic@lists.infradead.org, linux-gpio@vger.kernel.org, carlo@caione.org, linus.walleij@linaro.org, linux-arm-kernel@lists.infradead.org Martin Blumenstingl writes: > The nand_groups table uses different names for the NAND DQS pins than > the GROUP() definition in meson8b_cbus_groups (nand_dqs_0 vs nand_dqs0). > This prevents using the NAND DQS pins in the devicetree. > > Fix this by ensuring that the GROUP() definition and the > meson8b_cbus_groups use the same name for these pins. > > Fixes: 0fefcb6876d0 ("pinctrl: Add support for Meson8b") > Signed-off-by: Martin Blumenstingl Acked-by: Kevin Hilman > --- > drivers/pinctrl/meson/pinctrl-meson8b.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/pinctrl/meson/pinctrl-meson8b.c b/drivers/pinctrl/meson/pinctrl-meson8b.c > index 76f077f18193..f87ef5a0ee6c 100644 > --- a/drivers/pinctrl/meson/pinctrl-meson8b.c > +++ b/drivers/pinctrl/meson/pinctrl-meson8b.c > @@ -739,8 +739,8 @@ static const char * const sdxc_c_groups[] = { > static const char * const nand_groups[] = { > "nand_io", "nand_io_ce0", "nand_io_ce1", > "nand_io_rb0", "nand_ale", "nand_cle", > - "nand_wen_clk", "nand_ren_clk", "nand_dqs0", > - "nand_dqs1" > + "nand_wen_clk", "nand_ren_clk", "nand_dqs_0", > + "nand_dqs_1" > }; > > static const char * const nor_groups[] = { From mboxrd@z Thu Jan 1 00:00:00 1970 From: khilman@baylibre.com (Kevin Hilman) Date: Mon, 03 Apr 2017 09:07:50 -0700 Subject: [PATCH v2 1/2] pinctrl: meson: meson8b: fix the NAND DQS pins In-Reply-To: <20170401135922.1288-2-martin.blumenstingl@googlemail.com> (Martin Blumenstingl's message of "Sat, 1 Apr 2017 15:59:21 +0200") References: <20170325184350.7677-1-martin.blumenstingl@googlemail.com> <20170401135922.1288-1-martin.blumenstingl@googlemail.com> <20170401135922.1288-2-martin.blumenstingl@googlemail.com> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Martin Blumenstingl writes: > The nand_groups table uses different names for the NAND DQS pins than > the GROUP() definition in meson8b_cbus_groups (nand_dqs_0 vs nand_dqs0). > This prevents using the NAND DQS pins in the devicetree. > > Fix this by ensuring that the GROUP() definition and the > meson8b_cbus_groups use the same name for these pins. > > Fixes: 0fefcb6876d0 ("pinctrl: Add support for Meson8b") > Signed-off-by: Martin Blumenstingl Acked-by: Kevin Hilman > --- > drivers/pinctrl/meson/pinctrl-meson8b.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/pinctrl/meson/pinctrl-meson8b.c b/drivers/pinctrl/meson/pinctrl-meson8b.c > index 76f077f18193..f87ef5a0ee6c 100644 > --- a/drivers/pinctrl/meson/pinctrl-meson8b.c > +++ b/drivers/pinctrl/meson/pinctrl-meson8b.c > @@ -739,8 +739,8 @@ static const char * const sdxc_c_groups[] = { > static const char * const nand_groups[] = { > "nand_io", "nand_io_ce0", "nand_io_ce1", > "nand_io_rb0", "nand_ale", "nand_cle", > - "nand_wen_clk", "nand_ren_clk", "nand_dqs0", > - "nand_dqs1" > + "nand_wen_clk", "nand_ren_clk", "nand_dqs_0", > + "nand_dqs_1" > }; > > static const char * const nor_groups[] = {