From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jonathan Creekmore <jonathan.creekmore@gmail.com>
Subject: Re: [PATCH v3 2/5] build: Hook the schedulers into
	Kconfig
Date: Fri, 08 Jan 2016 10:02:06 -0600
Message-ID: <m2d1tc3vr5.fsf@Nebula.lan>
References: <1452187761-38328-1-git-send-email-jonathan.creekmore@gmail.com>
	<1452187761-38328-3-git-send-email-jonathan.creekmore@gmail.com>
	<20160108154744.GE32260@char.us.oracle.com>
	<568FDBBA.8050103@citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta14.messagelabs.com ([193.109.254.103])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <jonathan.creekmore@gmail.com>) id 1aHZUQ-00055P-Cj
	for xen-devel@lists.xenproject.org; Fri, 08 Jan 2016 16:02:10 +0000
Received: by mail-yk0-f174.google.com with SMTP id k129so344142514yke.0
	for <xen-devel@lists.xenproject.org>;
	Fri, 08 Jan 2016 08:02:08 -0800 (PST)
In-reply-to: <568FDBBA.8050103@citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: George Dunlap <george.dunlap@eu.citrix.com>, Jonathan Creekmore <jonathan.creekmore@gmail.com>, Dario Faggioli <dario.faggioli@citrix.com>, xen-devel@lists.xenproject.org
List-Id: xen-devel@lists.xenproject.org


Andrew Cooper writes:

> On 08/01/16 15:47, Konrad Rzeszutek Wilk wrote:
>> On Thu, Jan 07, 2016 at 11:29:18AM -0600, Jonathan Creekmore wrote:
>>> Allow the schedulers to be independently enabled or disabled at
>>> compile-time. To match existing behavior, all four schedulers are
>>> compiled in by default, although the Credit2, RTDS, and ARINC653 are
>>> marked EXPERIMENTAL to match their not currently supported status.
>> By unmarking all of them in sequence I was able to get this:
>>
>> #
>> # Schedulers
>> #
>> # CONFIG_SCHED_CREDIT is not set
>> # CONFIG_SCHED_CREDIT2 is not set
>> # CONFIG_SCHED_RTDS is not set
>> # CONFIG_SCHED_ARINC653 is not set
>> # CONFIG_SCHED_CREDIT_DEFAULT is not set
>> # CONFIG_SCHED_CREDIT2_DEFAULT is not set
>> # CONFIG_SCHED_RTDS_DEFAULT is not set
>> # CONFIG_SCHED_ARINC653_DEFAULT is not set
>> CONFIG_SCHED_DEFAULT="credit"
>>
>>
>> And the hypervisor did build with:
>>
>> [konrad@char xen]$ nm --defined xen-syms |grep schedulers
>> ffff82d080290d58 D __end_schedulers_array
>> ffff82d080290d58 D __start_schedulers_array
>>
>> :-)
>>
>> Not exactly sure if there is some way to make us _not_ shoot
>> ourselves in the foot by mistake.
>>
>> Perhaps the build should complain if the size of the
>> __schedulers_array is zero?
>
> Hmm yes - an ASSERT() at the bottom of the linker file would be a very
> good defensive measure.
>
> A hypervisor without any schedulers compiled in will be rather sad.

I can definitely add that in.