All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chris Ball <cjb@laptop.org>
To: James Hogan <james.hogan@imgtec.com>
Cc: Seungwon Jeon <tgih.jun@samsung.com>,
	linux-mmc <linux-mmc@vger.kernel.org>,
	James Hogan <james@albanarts.com>,
	Will Newton <will.newton@imgtec.com>
Subject: Re: [PATCH] mmc: dw_mmc: Fix disableing DMA in Non-IDMAC
Date: Mon, 20 Feb 2012 12:07:50 -0500	[thread overview]
Message-ID: <m2d3995t7d.fsf@bob.laptop.org> (raw)
In-Reply-To: <4F42384E.8020006@imgtec.com> (James Hogan's message of "Mon, 20 Feb 2012 12:10:54 +0000")

Hi,

On Mon, Feb 20 2012, James Hogan wrote:
> Hi,
>
> On 20/02/12 12:03, Seungwon Jeon wrote:
>> dw_mci_pre_dma_transfer() is valid only if internal DMA. In case of
>> using other DMA it returns -ENOSYS. It prevents the DMA operations.
>> This patch makes dw_mci_pre_dma_transfer() effective in all DMA case.
>> 
>> Reported-by: James Hogan <james@albanarts.com>
>> Signed-off-by: Seungwon Jeon <tgih.jun@samsung.com>
>
> I've tested, and this seems to work for me (no IDMAC) as long as your
> other patch is applied first of course ("fixed compile error when
> disable CONFIG_MMC_DW_IDMAC").
>
> Probably worth fixing the typo in the subject too (s/disableing/disabling/).
>
> Otherwise, Acked-by: James Hogan <james.hogan@imgtec.com>

Thanks, pushed to mmc-next for 3.3 with the subject line fix, and with
explicit mention of the regression and the patch that caused it.

- Chris.
-- 
Chris Ball   <cjb@laptop.org>   <http://printf.net/>
One Laptop Per Child

      reply	other threads:[~2012-02-20 17:07 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-02-20  2:01 [PATCH] mmc: dw_mmc: Fix disableing DMA in Non-IDMAC Seungwon Jeon
2012-02-20  5:59 ` Namjae Jeon
     [not found] ` <CAAG0J9-wRLj29=LztT4Ppi7q6Q=4dm29vHODk9KdVAGWKMJgUw@mail.gmail.com>
2012-02-20 12:10   ` James Hogan
2012-02-20 17:07     ` Chris Ball [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m2d3995t7d.fsf@bob.laptop.org \
    --to=cjb@laptop.org \
    --cc=james.hogan@imgtec.com \
    --cc=james@albanarts.com \
    --cc=linux-mmc@vger.kernel.org \
    --cc=tgih.jun@samsung.com \
    --cc=will.newton@imgtec.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.