Re: [PATCH v7] ESDHC: Workaround for data crc error on p1010rdb

[Chris Ball <cjb@laptop.org>]

Hi,

On Mon, Feb 13 2012, Huang Changming-R66093 wrote:
>> Actually, I think I'm still missing something.  Why doesn't this work?
>> 
>> +static void esdhc_of_set_clock(struct sdhci_host *host, unsigned int
>> +clock) {
>> +       /* Workaround to reduce the clock frequency for p1010 esdhc */
>> +       if (of_find_compatible_node(NULL, NULL, "fsl,p1010-esdhc")) {
>> +               if (clock > 20000000)
>> +                       clock -= 5000000;
>> +               if (clock > 40000000)
>> +                       clock -= 5000000;
>> +       }
>> +
>> +       /* Set the clock */
>> +       esdhc_set_clock(host, clock);
>> +}
>> 
> These codes can work, too.
> I forget the clock will be reduced 5M/10M only when the clock is
> greater than 20MHz/45MHz.
> So I should not test the clock in this function.

Great, thanks -- please test and submit a patch with the code above,
and I'll merge it.

- Chris.
-- 
Chris Ball   <cjb@laptop.org>   <http://printf.net/>
One Laptop Per Child