From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Ball Subject: Re: [PATCH REPOST 1/2] arm/dt: Tegra: Update SDHCI nodes to match bindings Date: Tue, 20 Sep 2011 14:07:15 -0400 Message-ID: References: <1316537186-26753-1-git-send-email-swarren@nvidia.com> <201109201943.29510.arnd@arndb.de> <74CDBE0F657A3D45AFBB94109FB122FF04B732161E@HQMAIL01.nvidia.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <74CDBE0F657A3D45AFBB94109FB122FF04B732161E-C7FfzLzN0UxDw2glCA4ptUEOCMrvLtNR@public.gmane.org> (Stephen Warren's message of "Tue, 20 Sep 2011 10:59:33 -0700") List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org Sender: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org To: Stephen Warren Cc: "nicolas.pitre-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org" , "devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org" , "linux-mmc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org" List-Id: linux-mmc@vger.kernel.org Hi, On Tue, Sep 20 2011, Stephen Warren wrote: > Arnd Bergmann wrote at Tuesday, September 20, 2011 11:43 AM: >> On Tuesday 20 September 2011, Stephen Warren wrote: >> > The bindings were recently updated to have separate properties for each >> > type of GPIO. Update the Device Tree source to match that. >> > >> > Signed-off-by: Stephen Warren >> > Acked-by: Olof Johansson >> > --- >> > I'd previously sent these to Grant assuming they'd go in his dt/next branch, >> > but perhaps these should go in through Arnd's arm-soc next/dt branch? >> > >> >> Which tree has the update that changed the bindings? I think it should >> go into the same one. >> >> If it's already upstream, I can take it into the fixes branch. > > Chris applied them to the mmc-next tree: > > git://git.kernel.org/pub/scm/linux/kernel/git/cjb/mmc.git > > which appears to be temporarily at: > > git://dev.laptop.org/users/cjb/mmc Sending these via Arnd's next/dt sounds good to me. I know we'd usually take changes that require an atomic update through the same tree, but Stephen said in https://lkml.org/lkml/2011/8/30/352 : I don't think there's actually any need for that; initializing Tegra's SDHCI from device-tree has never worked in mainline to date; it relies on patch 1 being there. And if patch 2 was there without patch 3, the worst that will happen is some port runs in 4-bit mode instead of 8-bit, which evidently works fine since I didn't even notice 8-bit support was missing... Thanks, - Chris. -- Chris Ball One Laptop Per Child From mboxrd@z Thu Jan 1 00:00:00 1970 From: cjb@laptop.org (Chris Ball) Date: Tue, 20 Sep 2011 14:07:15 -0400 Subject: [PATCH REPOST 1/2] arm/dt: Tegra: Update SDHCI nodes to match bindings In-Reply-To: <74CDBE0F657A3D45AFBB94109FB122FF04B732161E@HQMAIL01.nvidia.com> (Stephen Warren's message of "Tue, 20 Sep 2011 10:59:33 -0700") References: <1316537186-26753-1-git-send-email-swarren@nvidia.com> <201109201943.29510.arnd@arndb.de> <74CDBE0F657A3D45AFBB94109FB122FF04B732161E@HQMAIL01.nvidia.com> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi, On Tue, Sep 20 2011, Stephen Warren wrote: > Arnd Bergmann wrote at Tuesday, September 20, 2011 11:43 AM: >> On Tuesday 20 September 2011, Stephen Warren wrote: >> > The bindings were recently updated to have separate properties for each >> > type of GPIO. Update the Device Tree source to match that. >> > >> > Signed-off-by: Stephen Warren >> > Acked-by: Olof Johansson >> > --- >> > I'd previously sent these to Grant assuming they'd go in his dt/next branch, >> > but perhaps these should go in through Arnd's arm-soc next/dt branch? >> > >> >> Which tree has the update that changed the bindings? I think it should >> go into the same one. >> >> If it's already upstream, I can take it into the fixes branch. > > Chris applied them to the mmc-next tree: > > git://git.kernel.org/pub/scm/linux/kernel/git/cjb/mmc.git > > which appears to be temporarily at: > > git://dev.laptop.org/users/cjb/mmc Sending these via Arnd's next/dt sounds good to me. I know we'd usually take changes that require an atomic update through the same tree, but Stephen said in https://lkml.org/lkml/2011/8/30/352 : I don't think there's actually any need for that; initializing Tegra's SDHCI from device-tree has never worked in mainline to date; it relies on patch 1 being there. And if patch 2 was there without patch 3, the worst that will happen is some port runs in 4-bit mode instead of 8-bit, which evidently works fine since I didn't even notice 8-bit support was missing... Thanks, - Chris. -- Chris Ball One Laptop Per Child From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752638Ab1ITSHr (ORCPT ); Tue, 20 Sep 2011 14:07:47 -0400 Received: from void.printf.net ([89.145.121.20]:47826 "EHLO void.printf.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751096Ab1ITSHo (ORCPT ); Tue, 20 Sep 2011 14:07:44 -0400 From: Chris Ball To: Stephen Warren Cc: Arnd Bergmann , Grant Likely , "nicolas.pitre\@linaro.org" , Olof Johansson , Shawn Guo , "linux-mmc\@vger.kernel.org" , "linux-tegra\@vger.kernel.org" , "devicetree-discuss\@lists.ozlabs.org" , "linux-arm-kernel\@lists.infradead.org" , "linux-kernel\@vger.kernel.org" Subject: Re: [PATCH REPOST 1/2] arm/dt: Tegra: Update SDHCI nodes to match bindings References: <1316537186-26753-1-git-send-email-swarren@nvidia.com> <201109201943.29510.arnd@arndb.de> <74CDBE0F657A3D45AFBB94109FB122FF04B732161E@HQMAIL01.nvidia.com> Date: Tue, 20 Sep 2011 14:07:15 -0400 In-Reply-To: <74CDBE0F657A3D45AFBB94109FB122FF04B732161E@HQMAIL01.nvidia.com> (Stephen Warren's message of "Tue, 20 Sep 2011 10:59:33 -0700") Message-ID: User-Agent: Gnus/5.110018 (No Gnus v0.18) Emacs/23.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On Tue, Sep 20 2011, Stephen Warren wrote: > Arnd Bergmann wrote at Tuesday, September 20, 2011 11:43 AM: >> On Tuesday 20 September 2011, Stephen Warren wrote: >> > The bindings were recently updated to have separate properties for each >> > type of GPIO. Update the Device Tree source to match that. >> > >> > Signed-off-by: Stephen Warren >> > Acked-by: Olof Johansson >> > --- >> > I'd previously sent these to Grant assuming they'd go in his dt/next branch, >> > but perhaps these should go in through Arnd's arm-soc next/dt branch? >> > >> >> Which tree has the update that changed the bindings? I think it should >> go into the same one. >> >> If it's already upstream, I can take it into the fixes branch. > > Chris applied them to the mmc-next tree: > > git://git.kernel.org/pub/scm/linux/kernel/git/cjb/mmc.git > > which appears to be temporarily at: > > git://dev.laptop.org/users/cjb/mmc Sending these via Arnd's next/dt sounds good to me. I know we'd usually take changes that require an atomic update through the same tree, but Stephen said in https://lkml.org/lkml/2011/8/30/352 : I don't think there's actually any need for that; initializing Tegra's SDHCI from device-tree has never worked in mainline to date; it relies on patch 1 being there. And if patch 2 was there without patch 3, the worst that will happen is some port runs in 4-bit mode instead of 8-bit, which evidently works fine since I didn't even notice 8-bit support was missing... Thanks, - Chris. -- Chris Ball One Laptop Per Child