From: Chris Ball <cjb@laptop.org>
To: Aries Lee <arieslee@jmicron.com>
Cc: linux-mmc@vger.kernel.org,
'Andrei Warkentin' <andreiw@motorola.com>,
'Adrian Hunter' <adrian.hunter@intel.com>,
'Arnd Bergmann' <arnd@arndb.de>,
'Andrew Morton' <akpm@linux-foundation.org>,
'Ohad Ben-Cohen' <ohad@wizery.com>,
'Philip Rakity' <prakity@marvell.com>
Subject: Re: [PATCH 1/1] Add support for JMicron chip with UHS-I function
Date: Thu, 04 Aug 2011 09:12:46 -0400 [thread overview]
Message-ID: <m2d3gl5nht.fsf@bob.laptop.org> (raw)
In-Reply-To: <201108040731.p747Vp13002998@jmr105.jmicron.com> (Aries Lee's message of "Thu, 4 Aug 2011 15:31:48 +0800")
Hi Aries,
On Thu, Aug 04 2011, Aries Lee wrote:
> 1. Force to assign some property at sdhci_add_host() function.
>
> 2. Jmicron doesn't support CMD19, install of tuning command, Jmicron run a
> procedure to tune the clock delay, command delay and data delay. Actually I
> want to define a quirks such like "SDHCI_QUIRK_NONSTANDARD_TUNE", but it run
> out the quirks definition. So I share SDHCI_QUIRK_UNSTABLE_RO_DETECT
> temporarily, looking for anyone provide any suggestion :-)
>
> The tuning procedure is very simple -- try to get card status and read data
> under totally 32 different clock delay setting, and record the result those
> Operations, then choose a proper delay setting from this result.
>
> 3. Jmicron using a nonstandard clock setting. this patch implement a
> function to set host clock by this nonstandard way.
>
> 4. The tuning procedure is put in host/sdhci.c temporarily, I am not sure it
> is a proper location or not, any suggestion?
>
> Signed-off-by: arieslee <arieslee@jmicron.com>
This patch is still corrupt.
Before sending it to us, you should send it to yourself, and check that
it can be applied with "git am" or "patch -p1".
Also, when sending a new version of a patch, please include a changelog
that explains what is different about the new version. If it's just a
resent version of the old patch, you can write that.
Thanks,
- Chris.
--
Chris Ball <cjb@laptop.org> <http://printf.net/>
One Laptop Per Child
next prev parent reply other threads:[~2011-08-04 13:13 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-04 7:31 [PATCH 1/1] Add support for JMicron chip with UHS-I function Aries Lee
2011-08-04 13:12 ` Chris Ball [this message]
-- strict thread matches above, loose matches on Subject: below --
2011-08-08 14:18 arieslee
2011-08-24 19:56 ` Chris Ball
[not found] <201108030600.p7360mhq023312@jmr105.jmicron.com>
2011-08-03 6:09 ` Aries Lee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2d3gl5nht.fsf@bob.laptop.org \
--to=cjb@laptop.org \
--cc=adrian.hunter@intel.com \
--cc=akpm@linux-foundation.org \
--cc=andreiw@motorola.com \
--cc=arieslee@jmicron.com \
--cc=arnd@arndb.de \
--cc=linux-mmc@vger.kernel.org \
--cc=ohad@wizery.com \
--cc=prakity@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.