All of lore.kernel.org
 help / color / mirror / Atom feed
From: Donald Hunter <donald.hunter@gmail.com>
To: Simon Horman <horms@kernel.org>
Cc: netdev@vger.kernel.org,  Jakub Kicinski <kuba@kernel.org>,
	 "David S. Miller" <davem@davemloft.net>,
	 Eric Dumazet <edumazet@google.com>,
	 Paolo Abeni <pabeni@redhat.com>,
	 Pablo Neira Ayuso <pablo@netfilter.org>,
	Jozsef Kadlecsik <kadlec@netfilter.org>,
	netfilter-devel@vger.kernel.org,  donald.hunter@redhat.com
Subject: Re: [PATCH net-next v1] netfilter: nfnetlink: convert kfree_skb to consume_skb
Date: Mon, 03 Jun 2024 10:19:27 +0100	[thread overview]
Message-ID: <m2ed9ecrj4.fsf@gmail.com> (raw)
In-Reply-To: <20240531161410.GC491852@kernel.org> (Simon Horman's message of "Fri, 31 May 2024 17:14:10 +0100")

Simon Horman <horms@kernel.org> writes:

> On Tue, May 28, 2024 at 11:37:54AM +0100, Donald Hunter wrote:
>> Use consume_skb in the batch code path to avoid generating spurious
>> NOT_SPECIFIED skb drop reasons.
>> 
>> Signed-off-by: Donald Hunter <donald.hunter@gmail.com>
>
> Hi Donald,
>
> I do wonder if this is the correct approach. I'm happy to stand corrected,
> but my understanding is that consume_skb() is for situations where the skb
> is no longer needed for reasons other than errors. But some of these
> call-sites do appear to be error paths of sorts.
>
> ...

Hi Simon,

They all look to be application layer errors which are either
communicated back to the client or cause a replay. My understanding is
that consume_skb() should be used here since kfree_skb() now implies a
(transport?) drop.

  reply	other threads:[~2024-06-03  9:22 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-28 10:37 [PATCH net-next v1] netfilter: nfnetlink: convert kfree_skb to consume_skb Donald Hunter
2024-05-31 16:14 ` Simon Horman
2024-06-03  9:19   ` Donald Hunter [this message]
2024-06-03 12:09     ` Simon Horman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m2ed9ecrj4.fsf@gmail.com \
    --to=donald.hunter@gmail.com \
    --cc=davem@davemloft.net \
    --cc=donald.hunter@redhat.com \
    --cc=edumazet@google.com \
    --cc=horms@kernel.org \
    --cc=kadlec@netfilter.org \
    --cc=kuba@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=pablo@netfilter.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.