From: David Edmondson <dme@dme.org>
To: Eric Blake <eblake@redhat.com>, qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>,
"open list:Block layer core" <qemu-block@nongnu.org>,
quintela@redhat.com, crosthwaite.peter@gmail.com,
dgilbert@redhat.com, f4bug@amsat.org, kraxel@redhat.com,
dirty.ice.hu@gmail.com, pbonzini@redhat.com,
Max Reitz <mreitz@redhat.com>,
rth@twiddle.net
Subject: Re: [PATCH v4] osdep: Make MIN/MAX evaluate arguments only once
Date: Fri, 05 Jun 2020 09:24:38 +0100 [thread overview]
Message-ID: <m2eeqtapix.fsf@dme.org> (raw)
In-Reply-To: <20200604215236.2798244-1-eblake@redhat.com>
On Thursday, 2020-06-04 at 16:52:36 -05, Eric Blake wrote:
> /* Minimum function that returns zero only iff both values are zero.
Not your change, but "only" is unnecessary here (or iff -> if).
dme.
--
But uh oh, I love her because, she moves in her own way.
next prev parent reply other threads:[~2020-06-05 8:25 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-04 21:52 [PATCH v4] osdep: Make MIN/MAX evaluate arguments only once Eric Blake
2020-06-04 21:55 ` Eric Blake
2020-06-04 22:28 ` Richard Henderson
2020-06-05 8:24 ` David Edmondson [this message]
2020-06-05 8:54 ` Philippe Mathieu-Daudé
2020-06-05 14:03 ` Eric Blake
2020-06-23 9:31 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2eeqtapix.fsf@dme.org \
--to=dme@dme.org \
--cc=crosthwaite.peter@gmail.com \
--cc=dgilbert@redhat.com \
--cc=dirty.ice.hu@gmail.com \
--cc=eblake@redhat.com \
--cc=f4bug@amsat.org \
--cc=kraxel@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.