From: khilman@baylibre.com (Kevin Hilman)
To: linus-amlogic@lists.infradead.org
Subject: [RFC PATCH 0/3] Amlogic: GXBB: Add reset controller
Date: Sat, 14 May 2016 17:11:20 +0200 [thread overview]
Message-ID: <m2eg941xpj.fsf@baylibre.com> (raw)
In-Reply-To: <1463148012-25988-1-git-send-email-narmstrong@baylibre.com> (Neil Armstrong's message of "Fri, 13 May 2016 16:00:09 +0200")
Hi Neil,
Neil Armstrong <narmstrong@baylibre.com> writes:
> Patchset to add and enable the reset controller driver on GXBB platforms.
Looking closer at the vendor BSP reset driver, I realized that that
kernel doesn't seem to be using this reset IP at all. Their reset
driver is actually just using clock gating in the HHI_GCLK_MPEGx
registers.
I'm not sure I understand why they made that choice (I've asked
off-list), but we'll need to keep in mind that any usage of the reset
driver in the vendor DTs corresponds do clock gating, and not this reset
IP.
In any case, other than the minor comments, this looks like a good
driver for the reset IP in the S905/GXBB.
Also, I gave this driver a quick test with the network driver support I
recently posted. When the network driver is loaded, it deasserts the
reset and when unloaded, it asserts the reset. Interestingly, the
assert cases a full system lockup. :(
I've asked some Amlogic folks off-list about this issue too, and hope to
get some more clarifcation (and ideally docs) about this reset IP soon.
Kevin
WARNING: multiple messages have this Message-ID (diff)
From: khilman@baylibre.com (Kevin Hilman)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC PATCH 0/3] Amlogic: GXBB: Add reset controller
Date: Sat, 14 May 2016 17:11:20 +0200 [thread overview]
Message-ID: <m2eg941xpj.fsf@baylibre.com> (raw)
In-Reply-To: <1463148012-25988-1-git-send-email-narmstrong@baylibre.com> (Neil Armstrong's message of "Fri, 13 May 2016 16:00:09 +0200")
Hi Neil,
Neil Armstrong <narmstrong@baylibre.com> writes:
> Patchset to add and enable the reset controller driver on GXBB platforms.
Looking closer at the vendor BSP reset driver, I realized that that
kernel doesn't seem to be using this reset IP at all. Their reset
driver is actually just using clock gating in the HHI_GCLK_MPEGx
registers.
I'm not sure I understand why they made that choice (I've asked
off-list), but we'll need to keep in mind that any usage of the reset
driver in the vendor DTs corresponds do clock gating, and not this reset
IP.
In any case, other than the minor comments, this looks like a good
driver for the reset IP in the S905/GXBB.
Also, I gave this driver a quick test with the network driver support I
recently posted. When the network driver is loaded, it deasserts the
reset and when unloaded, it asserts the reset. Interestingly, the
assert cases a full system lockup. :(
I've asked some Amlogic folks off-list about this issue too, and hope to
get some more clarifcation (and ideally docs) about this reset IP soon.
Kevin
WARNING: multiple messages have this Message-ID (diff)
From: Kevin Hilman <khilman@baylibre.com>
To: Neil Armstrong <narmstrong@baylibre.com>
Cc: linux-kernel@vger.kernel.org, p.zabel@pengutronix.de,
linux-arm-kernel@lists.infradead.org,
linux-amlogic@lists.infradead.org
Subject: Re: [RFC PATCH 0/3] Amlogic: GXBB: Add reset controller
Date: Sat, 14 May 2016 17:11:20 +0200 [thread overview]
Message-ID: <m2eg941xpj.fsf@baylibre.com> (raw)
In-Reply-To: <1463148012-25988-1-git-send-email-narmstrong@baylibre.com> (Neil Armstrong's message of "Fri, 13 May 2016 16:00:09 +0200")
Hi Neil,
Neil Armstrong <narmstrong@baylibre.com> writes:
> Patchset to add and enable the reset controller driver on GXBB platforms.
Looking closer at the vendor BSP reset driver, I realized that that
kernel doesn't seem to be using this reset IP at all. Their reset
driver is actually just using clock gating in the HHI_GCLK_MPEGx
registers.
I'm not sure I understand why they made that choice (I've asked
off-list), but we'll need to keep in mind that any usage of the reset
driver in the vendor DTs corresponds do clock gating, and not this reset
IP.
In any case, other than the minor comments, this looks like a good
driver for the reset IP in the S905/GXBB.
Also, I gave this driver a quick test with the network driver support I
recently posted. When the network driver is loaded, it deasserts the
reset and when unloaded, it asserts the reset. Interestingly, the
assert cases a full system lockup. :(
I've asked some Amlogic folks off-list about this issue too, and hope to
get some more clarifcation (and ideally docs) about this reset IP soon.
Kevin
next prev parent reply other threads:[~2016-05-14 15:11 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-13 14:00 [RFC PATCH 0/3] Amlogic: GXBB: Add reset controller Neil Armstrong
2016-05-13 14:00 ` Neil Armstrong
2016-05-13 14:00 ` Neil Armstrong
2016-05-13 14:00 ` [RFC PATCH 1/3] reset: Add support for the Amlogic Meson GXBB Reset Controller Neil Armstrong
2016-05-13 14:00 ` Neil Armstrong
2016-05-13 14:00 ` Neil Armstrong
2016-05-14 15:07 ` Kevin Hilman
2016-05-14 15:07 ` Kevin Hilman
2016-05-14 15:07 ` Kevin Hilman
2016-05-16 8:49 ` Neil Armstrong
2016-05-16 8:49 ` Neil Armstrong
2016-05-16 8:49 ` Neil Armstrong
2016-05-14 17:45 ` Kevin Hilman
2016-05-14 17:45 ` Kevin Hilman
2016-05-14 17:45 ` Kevin Hilman
2016-05-13 14:00 ` [RFC PATCH 2/3] dt-bindings: reset: Add bindings for the " Neil Armstrong
2016-05-13 14:00 ` Neil Armstrong
2016-05-13 14:00 ` Neil Armstrong
2016-05-14 14:45 ` Kevin Hilman
2016-05-14 14:45 ` Kevin Hilman
2016-05-14 14:45 ` Kevin Hilman
2016-05-13 14:00 ` [RFC PATCH 3/3] ARM64: dts: amlogic: Enable Reset Controller on GXBB-based platforms Neil Armstrong
2016-05-13 14:00 ` Neil Armstrong
2016-05-13 14:00 ` Neil Armstrong
2016-05-14 15:09 ` [RFC PATCH 0/3] Amlogic: GXBB: Add reset controller Kevin Hilman
2016-05-14 15:09 ` Kevin Hilman
2016-05-14 15:09 ` Kevin Hilman
2016-05-14 15:11 ` Kevin Hilman [this message]
2016-05-14 15:11 ` Kevin Hilman
2016-05-14 15:11 ` Kevin Hilman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2eg941xpj.fsf@baylibre.com \
--to=khilman@baylibre.com \
--cc=linus-amlogic@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.