All of lore.kernel.org
 help / color / mirror / Atom feed
From: Detlev Zundel <dzu@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] PATCH add rgb555 for at91
Date: Thu, 18 Jun 2009 16:07:22 +0200	[thread overview]
Message-ID: <m2eithvdnp.fsf@ohwell.denx.de> (raw)
In-Reply-To: <h1d6ej$esr$1@ger.gmane.org> (Giulio Benetti's message of "Thu, 18 Jun 2009 12:52:39 +0200")

Hi Giulio,

> Signed-off-by: giulio.benetti at micronovasrl.com

Can you please provide a somewhat more descriptive description?  It may
be obvious for you what this does (or what new features can now be
used), but it isn't for me.

>
> diff -urpN b/common/lcd.c a/common/lcd.c
> --- b/common/lcd.c      2009-06-14 21:30:39.000000000 +0200
> +++ a/common/lcd.c      2009-06-18 12:45:15.000000000 +0200
> @@ -1,4 +1,4 @@
> -/*
> +/*OC
>   * Common LCD routines for supported CPUs
>   *
>   * (C) Copyright 2001-2002
> @@ -575,6 +575,10 @@ void bitmap_plot (int x, int y)
>                         lut_entry = ((colreg & 0x000F) << 11) |
>                                     ((colreg & 0x00F0) <<  2) |
>                                     ((colreg & 0x0F00) >>  7);
> +#elif defined (CONFIG_ATMEL_LCD_RGB555)
> +                       lut_entry = ((colreg & 0x000F) << 1) |
> +                                   ((colreg & 0x00F0) <<  2) |
> +                                   ((colreg & 0x0F00) <<  3);
>  #else /* CONFIG_ATMEL_LCD_RGB565 */
>                         lut_entry = ((colreg & 0x000F) << 1) |
>                                     ((colreg & 0x00F0) << 3) |
> diff -urpN b/drivers/video/atmel_lcdfb.c a/drivers/video/atmel_lcdfb.c
> --- b/drivers/video/atmel_lcdfb.c       2009-06-14 21:30:39.000000000 +0200
> +++ a/drivers/video/atmel_lcdfb.c       2009-06-18 12:45:15.000000000 +0200
> @@ -57,6 +57,9 @@ void lcd_setcolreg(ushort regno, ushort
>  #if defined(CONFIG_ATMEL_LCD_BGR555)
                                ^^^
I know this line is not touched by you, but is BGR correct?

>         lcdc_writel(panel_info.mmio, ATMEL_LCDC_LUT(regno),
>                     (red >> 3) | ((green & 0xf8) << 2) | ((blue & 0xf8) << 7));
> +#elif defined(CONFIG_ATMEL_LCD_RGB555)
> +       lcdc_writel(panel_info.mmio, ATMEL_LCDC_LUT(regno),
> +                   (blue >> 3) | ((green & 0xf8) << 2) | ((red & 0xf8) << 7));
>  #else
>         lcdc_writel(panel_info.mmio, ATMEL_LCDC_LUT(regno),
>                     (blue >> 3) | ((green & 0xfc) << 3) | ((red & 0xf8) << 8));

Cheers
  Detlev

-- 
To you I'm an atheist; to God, I'm the Loyal Opposition.
                                        -- Woody Allen
--
DENX Software Engineering GmbH,      MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich,  Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-40 Fax: (+49)-8142-66989-80 Email: dzu@denx.de

  reply	other threads:[~2009-06-18 14:07 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-06-18 10:52 [U-Boot] PATCH add rgb555 for at91 Giulio Benetti
2009-06-18 14:07 ` Detlev Zundel [this message]
2009-06-18 14:23   ` Giulio Benetti
2009-06-19  8:26     ` Detlev Zundel
2009-06-19 10:17       ` Giulio Benetti
2009-06-23  9:32         ` Detlev Zundel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m2eithvdnp.fsf@ohwell.denx.de \
    --to=dzu@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.