From: Juan Quintela <quintela@mandrakesoft.com>
To: Ralf Baechle <ralf@linux-mips.org>, mipslist <linux-mips@linux-mips.org>
Subject: [PATCH]: you can't use p and p++ without a secuence point
Date: 19 Dec 2002 12:03:29 +0100 [thread overview]
Message-ID: <m2el8el18e.fsf@demo.mitica> (raw)
Hi
using p & p++ without a sequence point in the middle is
undefined behaviour. Once there fix the casts also.
and change == to = as normally == means identity, not
asignation :(
Later, Juan.
Index: arch/mips/lib/dump_tlb.c
===================================================================
RCS file: /home/cvs/linux/arch/mips/lib/dump_tlb.c,v
retrieving revision 1.8.2.6
diff -u -r1.8.2.6 dump_tlb.c
--- arch/mips/lib/dump_tlb.c 18 Dec 2002 22:47:37 -0000 1.8.2.6
+++ arch/mips/lib/dump_tlb.c 19 Dec 2002 10:38:02 -0000
@@ -225,9 +226,7 @@
for(i=0;i<8;i++)
{
- printk("*%08lx == %08lx, ",
- (unsigned long)p, (unsigned long)*p++);
- printk("*%08lx == %08lx\n",
- (unsigned long)p, (unsigned long)*p++);
+ printk("*%8p = %08lx, ", p, *p); p++;
+ printk("*%8p = %08lx\n", p, *p); p++;
}
}
--
In theory, practice and theory are the same, but in practice they
are different -- Larry McVoy
reply other threads:[~2002-12-19 10:57 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2el8el18e.fsf@demo.mitica \
--to=quintela@mandrakesoft.com \
--cc=linux-mips@linux-mips.org \
--cc=ralf@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.