Re: [PATCH ipsec-next v4 08/18] xfrm: iptfs: add new iptfs xfrm mode impl

[Christian Hopps <chopps@chopps.org>]

[-- Attachment #1: Type: text/plain, Size: 1804 bytes --]


Jeff Johnson <quic_jjohnson@quicinc.com> writes:

> On 6/17/24 13:53, Christian Hopps wrote:
>> From: Christian Hopps <chopps@labn.net>
>> Add a new xfrm mode implementing AggFrag/IP-TFS from RFC9347.
>> This utilizes the new xfrm_mode_cbs to implement demand-driven IP-TFS
>> functionality. This functionality can be used to increase bandwidth
>> utilization through small packet aggregation, as well as help solve PMTU
>> issues through it's efficient use of fragmentation.
>>    Link: https://www.rfc-editor.org/rfc/rfc9347.txt
>> Multiple commits follow to build the functionality into xfrm_iptfs.c
>> Signed-off-by: Christian Hopps <chopps@labn.net>
>> ---
>>   net/xfrm/Makefile     |   1 +
>>   net/xfrm/xfrm_iptfs.c | 225 ++++++++++++++++++++++++++++++++++++++++++
>>   2 files changed, 226 insertions(+)
>>   create mode 100644 net/xfrm/xfrm_iptfs.c
>> diff --git a/net/xfrm/Makefile b/net/xfrm/Makefile
>> index 547cec77ba03..cd6520d4d777 100644
>> --- a/net/xfrm/Makefile
>> +++ b/net/xfrm/Makefile
>> @@ -20,5 +20,6 @@ obj-$(CONFIG_XFRM_USER) += xfrm_user.o
>>   obj-$(CONFIG_XFRM_USER_COMPAT) += xfrm_compat.o
>>   obj-$(CONFIG_XFRM_IPCOMP) += xfrm_ipcomp.o
>>   obj-$(CONFIG_XFRM_INTERFACE) += xfrm_interface.o
>> +obj-$(CONFIG_XFRM_IPTFS) += xfrm_iptfs.o
>>   obj-$(CONFIG_XFRM_ESPINTCP) += espintcp.o
>>   obj-$(CONFIG_DEBUG_INFO_BTF) += xfrm_state_bpf.o
>> diff --git a/net/xfrm/xfrm_iptfs.c b/net/xfrm/xfrm_iptfs.c
>> new file mode 100644
>> index 000000000000..e7b5546e1f6a
>> --- /dev/null
>> +++ b/net/xfrm/xfrm_iptfs.c
>> @@ -0,0 +1,225 @@
>> +// SPDX-License-Identifier: GPL-2.0
> ...
>
>> +module_init(xfrm_iptfs_init);
>> +module_exit(xfrm_iptfs_fini);
>> +MODULE_LICENSE("GPL");
>
> missing MODULE_DESCRIPTION() which will cause a warning with make W=1

Added.

Thanks,
Chris.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 857 bytes --]