All of lore.kernel.org
 help / color / mirror / Atom feed
From: Hajime Tazaki <thehajime@gmail.com>
To: hideaki.yoshifuji@miraclelinux.com
Cc: davem@davemloft.net, netdev@vger.kernel.org, ek@google.com
Subject: Re: [PATCH] ipv6: Fix finding best source address in ipv6_dev_get_saddr().
Date: Tue, 14 Jul 2015 00:23:27 +0900	[thread overview]
Message-ID: <m2fv4s5bf4.wl@gmail.com> (raw)
In-Reply-To: <55A3CAFA.3060404@miraclelinux.com>


At Mon, 13 Jul 2015 23:28:10 +0900,
YOSHIFUJI Hideaki/吉藤英明 wrote:
> 
> Commit 9131f3de2 ("ipv6: Do not iterate over all interfaces when
> finding source address on specific interface.") did not properly
> update best source address available.  Plus, it introduced
> possible NULL pointer dereference.
> 
> Bug was reported by Erik Kline <ek@google.com>.
> Based on patch proposed by Hajime Tazaki <thehajime@gmail.com>.
> 
> Fixes: 9131f3de24db4dc12199aede7d931e6703e97f3b ("ipv6: Do not
> 	iterate over all interfaces when finding source address
> 	on specific interface.")
> Signed-off-by: YOSHIFUJI Hideaki <hideaki.yoshifuji@miraclelinux.com>

all of my tests passed with the patch on 14fe22e: Revert
"ipv4: use skb coalescing in defragmentation".

thanks for the prompt fix !

Acked-by: Hajime Tazaki <thehajime@gmail.com>

  reply	other threads:[~2015-07-13 15:23 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-13 14:28 [PATCH] ipv6: Fix finding best source address in ipv6_dev_get_saddr() YOSHIFUJI Hideaki/吉藤英明
2015-07-13 15:23 ` Hajime Tazaki [this message]
2015-07-13 15:31 ` Tom Herbert
2015-07-14 12:44   ` YOSHIFUJI Hideaki/吉藤英明
2015-07-14 15:22     ` Tom Herbert
2015-07-16  4:07   ` David Miller
2015-07-15  9:15 ` Erik Kline
2015-07-15 10:22   ` Erik Kline
2015-07-16  4:07 ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m2fv4s5bf4.wl@gmail.com \
    --to=thehajime@gmail.com \
    --cc=davem@davemloft.net \
    --cc=ek@google.com \
    --cc=hideaki.yoshifuji@miraclelinux.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.