From: Andi Kleen <andi@firstfloor.org>
To: Josef Bacik <josef@redhat.com>
Cc: linux-btrfs@vger.kernel.org, linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH 2/2] Btrfs: load the key from the dir item in readdir into a fake dentry
Date: Thu, 26 May 2011 11:50:18 -0700 [thread overview]
Message-ID: <m2fwo19tzp.fsf@firstfloor.org> (raw)
In-Reply-To: <1306421316-1504-2-git-send-email-josef@redhat.com> (Josef Bacik's message of "Thu, 26 May 2011 10:48:36 -0400")
Josef Bacik <josef@redhat.com> writes:
> +
> + newkey = kzalloc(sizeof(struct btrfs_key),
> + GFP_NOFS);
> + if (!newkey)
> + goto no_dentry;
> + tmp = d_alloc(filp->f_dentry, &q);
This doesn't seem to address the "find / fills all memory with dentries"
concerns brought up earlier at all.
d_alloc uses a normal GFP_KERNEL, which is quite in appropiate for this.
It should at least reclaim and probably more, but even then it's
risky.
-Andi
--
ak@linux.intel.com -- Speaking for myself only
next prev parent reply other threads:[~2011-05-26 18:50 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <adilger@dilger.ca, hch@lst.de>
2011-05-26 14:48 ` [PATCH 1/2] fs: add a DCACHE_NEED_LOOKUP flag for d_flags Josef Bacik
2011-05-26 14:48 ` [PATCH 2/2] Btrfs: load the key from the dir item in readdir into a fake dentry Josef Bacik
2011-05-26 18:50 ` Andi Kleen [this message]
2011-05-26 19:02 ` Josef Bacik
2011-05-26 20:03 ` Andi Kleen
2011-05-26 20:18 ` Josef Bacik
2011-05-26 20:45 ` Andreas Dilger
2011-05-19 17:58 [PATCH 1/2] fs: add a DCACHE_NEED_LOOKUP flag for d_flags Josef Bacik
2011-05-19 17:58 ` [PATCH 2/2] Btrfs: load the key from the dir item in readdir into a fake dentry Josef Bacik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2fwo19tzp.fsf@firstfloor.org \
--to=andi@firstfloor.org \
--cc=josef@redhat.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.