From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1oP3dD-00040q-7w for mharc-grub-devel@gnu.org; Fri, 19 Aug 2022 11:09:55 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:46970) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oP3dC-00040i-Ke for grub-devel@gnu.org; Fri, 19 Aug 2022 11:09:54 -0400 Received: from mx0a-00069f02.pphosted.com ([205.220.165.32]:22160) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oP3d8-0001C4-VZ for grub-devel@gnu.org; Fri, 19 Aug 2022 11:09:54 -0400 Received: from pps.filterd (m0246617.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 27JEdZjh030451 for ; Fri, 19 Aug 2022 15:09:41 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : cc : subject : in-reply-to : references : date : message-id : content-type : mime-version; s=corp-2022-7-12; bh=2fy31rwGjahZWNxQ/+19L7tFe/PZ4mhuyzTenIgRZHM=; b=qcmtaz/lsjRq9OJzZig44R3n0Welc1Lh9WLqpxnN4mckA2597nu/yQaoVE0OFlqlkcpL UqjWDj8+mFji7Yxf3WGnWmmetsJ+ThwOrpuja3q1QlZsqUE4ckn/7+fBaWh5swWpBVo7 MKnHLHAtuxK/p0GmrYQ5BZMWncxGDQv1BUQ65q92aZdZ3mkC6gJHzxQfgAtJZcEgaDfz lqg1WEB1D/e0JQI1+Xd7/fKyALBV2XEGQJhyNWAVkC1fQXIZe/hhA+oXORj2YfYgNs3I 9N0qZvq5MUHEOmwUnI77TaUs7K5k7lxORu2sSr3LVi23kz2Wp+DOtKBQfHnJiuveqdlN Tw== Received: from phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta03.appoci.oracle.com [138.1.37.129]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3j2cfrg3v8-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Fri, 19 Aug 2022 15:09:40 +0000 Received: from pps.filterd (phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com (8.17.1.5/8.17.1.5) with ESMTP id 27JDpp5o020800 for ; Fri, 19 Aug 2022 15:09:40 GMT Received: from nam12-mw2-obe.outbound.protection.outlook.com (mail-mw2nam12lp2041.outbound.protection.outlook.com [104.47.66.41]) by phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTPS id 3hx2d5jbvs-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Fri, 19 Aug 2022 15:09:40 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OT/5fD7aj+2YUQE/Lao4yNp4FVaR7qdyJmCUtUfBdiW+ml3pP++BSKequpg6kJf+gkeSIXmYllt/oAjHS8TWIOVx5QHig1StXqNcEaz5wrct5rTKoo5wDhrJnF5De4PicZ33o1SJ8282QKPC4J4I8uLT4t3DX558imaoFA0NY4DWU5SKPLtUtNsSUDxrxiqsWXISYHU5hmRfsHlU8EmX8pDL7sFkboDdVltibRY3/CRY2rDOz7gYgM5zNMk4c6lMovNjXkdQYSoeK2WjQH5qmVlUGZjbZDuPyp4Hv8i59hz59VaLVxsHIqHr1sOwMsHI05MtsO9/ymygBS5rEYxquA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=2fy31rwGjahZWNxQ/+19L7tFe/PZ4mhuyzTenIgRZHM=; b=BJha1pcJzWNGK1yz8A7sidgiV7KDJHq7XfO0vEtF12ii5dyUqoxO6nDNEbrgVR8aHIRgmQjDkR9Eg2XQy6v6z3W5FAP91QUJnqoZivxfPvhVgTB+HtKgmK4dMt2KFCdcQpdj7xrwF8wjKQmGiKnfut5w/1E6grZTIzSnTx2+pWpg+nJhOFLUHFbS9sljOXAyvYuV5V2ZhZ62myFDnAuIwxo/Htcz7Oj0rorJrOdva6beHlFfkmx23MUyPbMlFsvia4VbyjRRKy+3W14tvSGAK5Si+l9/VD1ue5/yagzaHvxNQ1Bbf9SIcV9v4HlBjeCgKeozv/i5CNqmJUOQ1UZCrw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2fy31rwGjahZWNxQ/+19L7tFe/PZ4mhuyzTenIgRZHM=; b=x6XxpjHbMCE+gtUSTJUEpgqhJLU8CGAMraCM38PMGo9vTElOW2awUzjIVTCZ+lfy0FhLombu5eXuSV0pjUsDO8LMBQ/EgSsEGehwtLbYEqkyQmvogcz0qHjE/5rJLJ0CYwwjk3zDjlAuVE8aimPHAfasDh24mhx72daoHLnCYD8= Received: from BLAPR10MB5138.namprd10.prod.outlook.com (2603:10b6:208:322::8) by DM6PR10MB2793.namprd10.prod.outlook.com (2603:10b6:5:62::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5546.16; Fri, 19 Aug 2022 15:09:38 +0000 Received: from BLAPR10MB5138.namprd10.prod.outlook.com ([fe80::89fe:338:779d:6bb0]) by BLAPR10MB5138.namprd10.prod.outlook.com ([fe80::89fe:338:779d:6bb0%8]) with mapi id 15.20.5546.016; Fri, 19 Aug 2022 15:09:38 +0000 From: Darren Kenny To: Jagannathan Raman , grub-devel@gnu.org Cc: daniel.kiper@oracle.com Subject: Re: [PATCH] fill_fs_info: pass pointer to dnode_end_t instead of value In-Reply-To: <20220819145722.31111-1-jag.raman@oracle.com> References: <20220819145722.31111-1-jag.raman@oracle.com> Date: Fri, 19 Aug 2022 16:09:34 +0100 Message-ID: Content-Type: text/plain X-ClientProxiedBy: DB6PR07CA0190.eurprd07.prod.outlook.com (2603:10a6:6:42::20) To BLAPR10MB5138.namprd10.prod.outlook.com (2603:10b6:208:322::8) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: e5089d8d-a3a5-4ab3-c84a-08da81f4d58e X-MS-TrafficTypeDiagnostic: DM6PR10MB2793:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: uFw+4RJUWky5KhsqoQuemVKKWcP9zv2wVfbUJhhm+CCMmueTVtq3FAqJCJv9ZVVB2/VTpWQrLP6Jo466js3nOOEkhDBx0K2rU5Sa4QnhQZ0XrTjdVMd6Oh3fHbsl4tDa8kb0sGnE2Ce65P/bSCWDVfSDsRv2vL0xWk3jDvA5wQWFl+fFIukwk9LzJFF72F1V21BIYQV29FrdZQ2Rd94MHm9eVjUHoC4adp0icZ1at9tMBgBhqkPH1cpeO/wiQsV7bb9guYr+5MKi9KfMrC15jpmwAay/hWm8QksEPSSwv8Mnx95eTdeWKZJojp/LCdmihS3kPqoF13P85ipefPn/p2nMgNPy5fcSG995Vo8qkWIo5//x8G9HGZEenr3Cm3alffrmb90/LGGZDBewbuLQ7OytWQBbFfggB4UtbtADhK+bm4N+Cud0iboWip86HvokgBXKy/aPMeMopqyr+Zl6ccKJmlYjp9kgMK9f/1fpaDY6DrSM0sWwB1Gqr3v+DgKEp+4zPFFsoNaeZxD252ZHm1dgYE0+rsmWQUqR9hNe4O4zj56HnVaKr5Kq9gvjMzEs8SZh9qaTU3TRRkKsBsAvrQ1sBjHG5RRO6mlX+DCN0UnS5Mc7ANeQq4zGUhaj1REbriiyQOVnlfxZvF6nec8rOYJWQwOroPpHY0OI7TuvclYrLUhQauEOaMexapg+WngtmarTpAFjbAvM7asofhFLcg== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BLAPR10MB5138.namprd10.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230016)(376002)(346002)(136003)(39860400002)(366004)(396003)(86362001)(2616005)(83380400001)(186003)(38100700002)(8936002)(5660300002)(478600001)(66556008)(66476007)(4326008)(36756003)(66946007)(107886003)(8676002)(44832011)(2906002)(41300700001)(6666004)(6512007)(26005)(6506007)(6486002)(316002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?dIzGbsO3cmKOPG3V2FPzMUwTyNUsxwOXk2svhubaWAxbJKXYZdBDGEa7djow?= =?us-ascii?Q?ywrCjwJKQbSy6v98tAGjLtAtvZmEcUTeiQG1BQ3VDdeyXaH1UWoOZvpvyWAT?= =?us-ascii?Q?6c9fOi5JShl666xg+UOYsSDVnS35nXuLZNG292L310fubvAcoW5JmIT9KfUM?= =?us-ascii?Q?LvYuG/mgTuhH0K+QmxTKBccaldPjHrGYFGQK2nTI7pRCY68VctMQYfsExMh8?= =?us-ascii?Q?bRIXpU3vsMQfbHId77VQrJwgBqzx4SqBGsqYCe+A2U61c5U7JfNtHpnhU53M?= =?us-ascii?Q?1Hlf3z1LDDXB5qiP4LlvqWkJW8DXeIP0FvLoGrPZ//f/NyA3yVHdHkxK1mOS?= =?us-ascii?Q?fGm05vhTkHWI5tQvZujbB+WZEzSF33XN3fOeIu0cnQVAi5h8u/v1o/rKHrPY?= =?us-ascii?Q?5m34qhp05urvHuquBjF01JNb1WmkpMKarxmpfxg8J/aaB/VvOhrEGAHZ5zu3?= =?us-ascii?Q?pbByVxrw3yNO/hhJsmHx/P1BgIeyf2oz1KHJzdve/ZR9oC8Jw1lG8IoSy1vJ?= =?us-ascii?Q?fbiu1eBvHtaR/VFlqJt7XISGQ6XiKeyndWG/ud1wyNXtkKBATIGxnOj7bG5d?= =?us-ascii?Q?DWrcnZx/H931/9FyZQOWglaxb4yDDwurqH0XNhACRVXYpGAwiaD0StrYqW7k?= =?us-ascii?Q?F558VoHMq8pt+KFMATVHPKteGYNt1SidN08yofiZkyNxzpx1Tho5PKxs50QC?= =?us-ascii?Q?4vasxn5hNjEtFk31qECm/F0YVh9oSBU5zQKoH3QrcfpdVn/PYS0dvH+xBN3Y?= =?us-ascii?Q?4ziqwdlm321+vNfjTlAYiDPLHtrCjn/hnsa6NpppyWjaKSQIY6H/tCfJ6cww?= =?us-ascii?Q?YKWMohuKUm6x0ixRa+mPSERaIkbVKjOjMbHqQTr/LqNEoEnXCHjXjxlbSlQY?= =?us-ascii?Q?Miv81JJPScNJ0TGT7jtSTZhenx2DpmCcEEOXWc0MRFNvoLVH0WejU2HJ4E/s?= =?us-ascii?Q?KhpBCy/aCuMWqhyZ9QdakAAJAYhywfyo+aARs4HluK9R301pH9v/9lWGS+hj?= =?us-ascii?Q?w7XIuPNirlJoe1Qz0SL8pPKMT+ZsxzAQGF2h8NvRze2g7a0ChCAU7qvAwz/c?= =?us-ascii?Q?P1/ufHmW1gQhhKrkasIQHxHaJXjSdeo8/7CiMXheuuNl7LweTHmwaQQ7aF/H?= =?us-ascii?Q?rfmf3nq/97udd8J5Ye2aqaJazR3davcyGYayDAY/XTzFxyvWAvNzWVd8VMCN?= =?us-ascii?Q?3vxwEtfiRrEBB+4Z8GUppVcZzj+J1kCHg/eWajzYnguxDSGWcT99Jz6IpPBj?= =?us-ascii?Q?kprxXR8AfFCEGfFn84Ds9tFThHRIV9mVwU55CjhLCtSXE3uoxwkcXcQNKn2w?= =?us-ascii?Q?rRXO9BACNGJTiEb1EPg80C31KVOTZlOlVWVMAXescCFKiRUD0kLA5GefQE2u?= =?us-ascii?Q?axzX+FsMHOWjuDRoihNqcfEJiMpQn7kc7EziZ+TrJmK1GbdtgX4aP0XTeOxr?= =?us-ascii?Q?C9LLMTUd0HJpRCOtNjEPgKkawaOTQIzjpW0FkaYuMee52Ctl/EJ0JVDhdQW9?= =?us-ascii?Q?eYy9Ik6jgQ0XXUMW4RDSCfXO5vKGZ+tieGMSOa++l68cUjZscspgsML2m7Op?= =?us-ascii?Q?6JUaW8vJSdK7CW5tmsB95u3/frueby7FnZm0an3kbDkadtshxtpU37Dv0PsC?= =?us-ascii?Q?PQ=3D=3D?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: Ovx8Ul7j+bUVRPQNB5lGF+Rigu3NlVUIllOj2j3s3wZFfZAoFAwtRVsNxoWzu/zAxLgiJplu3pELrzkiqTaeq/a77nkTpCPCD7Bx+Dlh67LPnVNYVg7OOne9Rl6E7nLTvbD35cAoKk2Iqn+UHuHvIp3FPoowqpkcQWUdQ1cK4/4/VdQ1CO+wfwlMJq+MZ5v2wyDGJCFjtq4hJRlGfYfpZjs1OCq+sJzo+rjnV+Q0E8kY+Grl/bv1x1QtJA0xxbQavZrWj/82f4ce4OPO7mplbPpF6tGACM8YgBhj9VRhav+Te6+VeNpos/q6uwFUUU4hQU1AcRInxaVScaeK6KvwzK/SjunKVmZIJeLNIPJ1ABg9eKV60PUL7mvy7I6c4vYdnOEIi7jyuCFAhcRtP7RluNNRITkFnynbDjE5gR3LuEhvwisCucxmPhjCPMzPW/Ljgrsz6iLLu+fCMYRh11LthtrY69MdOUYD2JVeYNtY1fUnxmgwEMSEf54Xr4G9uhC9bxzeP3j6wrW0VtoJDgd7NE88KVojtIiitxmXpCHa6ZD6NVj4m5us4pyoHB0vIQAAMzkq6b4sK6Q2+JkHlJ5JFe96GTalibOozZV88rG7D8oXDybTWj+iCcHQ3lZdpFiFWtukrJ7TKoDjlVxFhQt0S7dxh0Y2buO6LImdvFFnt914gdN4xBhHz6dk6ryp29+XjPFDRZUIHxv1WYZvg6NN0g== X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: e5089d8d-a3a5-4ab3-c84a-08da81f4d58e X-MS-Exchange-CrossTenant-AuthSource: BLAPR10MB5138.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Aug 2022 15:09:38.3753 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 7Dl47la1CN3zu1cD8GkuBRUtNI2fSCc4aK6h2HQ9VrdOzgXgftstXR30B9q76CQcJYiPgin5xAqrPcn1WDlcFg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR10MB2793 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.517,FMLib:17.11.122.1 definitions=2022-08-19_08,2022-08-18_01,2022-06-22_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 suspectscore=0 mlxscore=0 adultscore=0 mlxlogscore=999 bulkscore=0 phishscore=0 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2207270000 definitions=main-2208190055 X-Proofpoint-GUID: sZO7vsz2WMvPGWZ643rGkxsalwC6gLP2 X-Proofpoint-ORIG-GUID: sZO7vsz2WMvPGWZ643rGkxsalwC6gLP2 Received-SPF: pass client-ip=205.220.165.32; envelope-from=darren.kenny@oracle.com; helo=mx0a-00069f02.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 19 Aug 2022 15:09:54 -0000 Hi Jag, These changes look good to me. Just to confirm, you have run 'make check' and this has no negative impact on the zfs tests? Assuming that is the case... On Friday, 2022-08-19 at 10:57:22 -04, Jagannathan Raman wrote: > Coverity reports that dnode_end_t argument of fill_fs_info() is too > large to pass-by-value. Therefore, replace the argument with a pointer. > > Fixes: CID 73631 > > Signed-off-by: Jagannathan Raman > Reviewed-by: Darren Kenny Thanks, Darren. > --- > grub-core/fs/zfs/zfs.c | 17 +++++++++++++---- > 1 file changed, 13 insertions(+), 4 deletions(-) > > diff --git a/grub-core/fs/zfs/zfs.c b/grub-core/fs/zfs/zfs.c > index ffa0e5863..975c67242 100644 > --- a/grub-core/fs/zfs/zfs.c > +++ b/grub-core/fs/zfs/zfs.c > @@ -3983,14 +3983,23 @@ grub_zfs_getmdnobj (grub_device_t dev, const char *fsfilename, > return err; > } > > +/* > + * Note: fill_fs_info() uses functions such as make_mdn() that modify > + * the input dnode_end_t parameter. However, we should not allow it. > + * Therefore, we are making mdn_in constant - fill_fs_info() makes a > + * local copy of it. > + */ > static grub_err_t > fill_fs_info (struct grub_dirhook_info *info, > - dnode_end_t mdn, struct grub_zfs_data *data) > + const dnode_end_t *mdn_in, struct grub_zfs_data *data) > { > grub_err_t err; > dnode_end_t dn; > grub_uint64_t objnum; > grub_uint64_t headobj; > + dnode_end_t mdn; > + > + grub_memcpy (&mdn, mdn_in, sizeof (*mdn_in)); > > grub_memset (info, 0, sizeof (*info)); > > @@ -4148,7 +4157,7 @@ iterate_zap_fs (const char *name, grub_uint64_t val, > if (mdn.dn.dn_type != DMU_OT_DSL_DIR) > return 0; > > - err = fill_fs_info (&info, mdn, ctx->data); > + err = fill_fs_info (&info, &mdn, ctx->data); > if (err) > { > grub_errno = 0; > @@ -4179,7 +4188,7 @@ iterate_zap_snap (const char *name, grub_uint64_t val, > if (mdn.dn.dn_type != DMU_OT_DSL_DATASET) > return 0; > > - err = fill_fs_info (&info, mdn, ctx->data); > + err = fill_fs_info (&info, &mdn, ctx->data); > if (err) > { > grub_errno = 0; > @@ -4224,7 +4233,7 @@ grub_zfs_dir (grub_device_t device, const char *path, > dnode_end_t dn; > struct grub_dirhook_info info; > > - err = fill_fs_info (&info, data->dnode, data); > + err = fill_fs_info (&info, &data->dnode, data); > if (err) > { > zfs_unmount (data); > -- > 2.20.1