From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mm01.cs.columbia.edu (mm01.cs.columbia.edu [128.59.11.253]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5BF40C43334 for ; Wed, 6 Jul 2022 07:21:25 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id BF35A4C04F; Wed, 6 Jul 2022 03:21:24 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Authentication-Results: mm01.cs.columbia.edu (amavisd-new); dkim=softfail (fail, message has been altered) header.i=@gmail.com Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id hBFEEm50he8N; Wed, 6 Jul 2022 03:21:23 -0400 (EDT) Received: from mm01.cs.columbia.edu (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id B92EE4C05B; Wed, 6 Jul 2022 03:21:23 -0400 (EDT) Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id DB18F4B5AE for ; Fri, 1 Jul 2022 10:30:00 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 6PHJmxJvCi23 for ; Fri, 1 Jul 2022 10:29:59 -0400 (EDT) Received: from mail-io1-f48.google.com (mail-io1-f48.google.com [209.85.166.48]) by mm01.cs.columbia.edu (Postfix) with ESMTPS id CF6674B5AD for ; Fri, 1 Jul 2022 10:29:59 -0400 (EDT) Received: by mail-io1-f48.google.com with SMTP id d3so2403675ioi.9 for ; Fri, 01 Jul 2022 07:29:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=references:user-agent:from:to:cc:subject:date:in-reply-to :message-id:mime-version; bh=9cF5IqYxYj2InYMRmfggjddnYppc9EzlqbpJtswCFOc=; b=HODcUQLIo0DHm2SWxvgselcLa4dqArEO92qCD/gdLMJVimUVw0vou6BSTzhmjWwMYF 1E+buAnE4rtwp0FAJX85qZ+3o2LqSI6tChHU9pxyTtzYtmhBpSp7owpv82dDVMtUeoYZ sta4ytKhLwiQHRKRr4g0NyOUcuF6AebROFB/JemgbaMZ7IxhFV0eoXHhscnThyXgxm7u eWXLEO4OiZIpuOIFJxbs1xuVlE15lZ1DdPobHLI+vafxbu0XsqKQjOZLH7Nl5FIyDwD6 DvjVXFKvIJpLg/tYtsORHUsApO76DV7qn3AJuU1/7gtrOOQLACHhxYvOhUOXCKWBZtJn FOAg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:references:user-agent:from:to:cc:subject:date :in-reply-to:message-id:mime-version; bh=9cF5IqYxYj2InYMRmfggjddnYppc9EzlqbpJtswCFOc=; b=a1aZW5axzMTS2L/+LfWRyO7Aa6DL8OqFevYXPERWz4dLjxpgVcdUkX9sRKEDWEMEI0 CqesPvZVhV0wepdcBbAfjORSFDcMLxdskCBFkuY65OGRFJgeIP497ntGTAzRmV8LLCji TmFg3amLGUikAQ9TT+kCGs0WlVL2a3KmKVYlZnUcmhQvcaOiGeJM5GQwTbhCF5FvWvMC XGucwYa8XXs7UOj2D5u9yZhQjNMj/TF8J3a4coBVAIpNqVva3NMkYei4KZoS7VVbA4se t3O7z6w3hlw3tu7W0SdG1mE1wiDu6vnIs6H1KoKNZ0Fj1eL1uV2vscCHVimyx9rcelSp 0STA== X-Gm-Message-State: AJIora9Wp+s1GcNcjHQNbU+c0F+GmhD9rdZQYEkJakaNtvYqXRvEBQzh WcgohvzlLcvZP+YUUpixZVs= X-Google-Smtp-Source: AGRyM1sRv34EaaWYc7DQ/cybSSP4tt+pHpLB0OquCLm3mDR/BmnZSy7nB06i+Pl5+EtSLGZ2Xxh7qA== X-Received: by 2002:a05:6638:d86:b0:33c:cb7f:4ecc with SMTP id l6-20020a0566380d8600b0033ccb7f4eccmr8907108jaj.28.1656685799208; Fri, 01 Jul 2022 07:29:59 -0700 (PDT) Received: from ArchLinux ([240e:390:a20:ece0:3ad5:47ff:feb5:73b2]) by smtp.gmail.com with ESMTPSA id b15-20020a056602218f00b00669b2ffad32sm10288981iob.54.2022.07.01.07.29.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 Jul 2022 07:29:58 -0700 (PDT) References: <20220630161220.53449-1-schspa@gmail.com> <87mtdu15ok.wl-maz@kernel.org> <87letd0wqm.wl-maz@kernel.org> User-agent: mu4e 1.7.5; emacs 28.1 From: Schspa Shi To: Marc Zyngier Subject: Re: [PATCH] KVM: arm64: Fix 64 bit mmio handle Date: Fri, 01 Jul 2022 22:22:51 +0800 In-reply-to: <87letd0wqm.wl-maz@kernel.org> Message-ID: MIME-Version: 1.0 X-Mailman-Approved-At: Wed, 06 Jul 2022 03:21:23 -0400 Cc: will@kernel.org, catalin.marinas@arm.com, linux-kernel@vger.kernel.org, kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org X-BeenThere: kvmarm@lists.cs.columbia.edu X-Mailman-Version: 2.1.14 Precedence: list List-Id: Where KVM/ARM decisions are made List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: kvmarm-bounces@lists.cs.columbia.edu Sender: kvmarm-bounces@lists.cs.columbia.edu Marc Zyngier writes: >> >> I have running some static code analysis software upon Kernel >> code. >> Seeing there is possible overflow. >> >> maks << 1U << ((len * 8) -1); >> >> The AI don't know, len is only the value of 1, 2, 4, and make >> this >> a warnings >> >> I tring to analysis this, but didn't realize the real scenario >> of >> sign extension, and finally sent this problematic patch. >> >> I do see some uninitialized memory reads (the values are not >> used >> in the end, just as temporary space for API execution), >> do we need to fix these? > > You need to be more descriptive here. What uninitialised reads? > In > general, pointing at the code and providing a full description > of what > you think is incorrect would really help... > > M. One example is int vgic_v3_has_attr_regs(struct kvm_device *dev, struct kvm_device_attr *attr) { ... case KVM_DEV_ARM_VGIC_GRP_CPU_SYSREGS: { u64 reg, id; id = (attr->attr & KVM_DEV_ARM_VGIC_SYSREG_INSTR_MASK); return vgic_v3_has_cpu_sysregs_attr(vcpu, 0, id, ®); } } The funcion vgic_v3_has_cpu_sysregs_attr will read reg's value to params without initialization. There should have no problems, because the register value never used. -- BRs Schspa Shi _______________________________________________ kvmarm mailing list kvmarm@lists.cs.columbia.edu https://lists.cs.columbia.edu/mailman/listinfo/kvmarm From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 97DFECCA47B for ; Fri, 1 Jul 2022 14:31:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:Message-ID:In-reply-to:Date:Subject:Cc: To:From:References:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=yecwYSQrPmGkyNcUfJoyKLQ75QEzCKtgVgjtSGPFsxQ=; b=PLo6RZzTJ/nXReRG0/mMSkiDcC Cj4XQYF10BPVJxSuPqr3ljtEInuhyzI984YnoFL6k8C3W425U7nwCgCmMBnRYmB551VRujWK/sSl6 2v1Ry7ivjbGnnKGluXQmr3oV2Xu5tsgWUaj+HKBDef/gM8naHy2OSu2nt3uSsgc5TLyCQHh7K6r+Q bGgVuijQZdd3Br7ZgFaiI4w+AWOt8tRxDyvkWBYR9OCTUor5ryS1oO5bYAPRIaF8Qi9c8iOc4GyX5 lGlaOfWUxtqthlJRas44ykxxVWkLrd/Uo09f1B1eLp2S6Ctv8+EI6Iokrao4HvTRk2jIbLZeUOwi6 i4Gt3S6g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1o7Hel-005LV6-Ed; Fri, 01 Jul 2022 14:30:03 +0000 Received: from mail-io1-xd35.google.com ([2607:f8b0:4864:20::d35]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1o7Hej-005LTu-1c for linux-arm-kernel@lists.infradead.org; Fri, 01 Jul 2022 14:30:02 +0000 Received: by mail-io1-xd35.google.com with SMTP id k15so2424892iok.5 for ; Fri, 01 Jul 2022 07:29:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=references:user-agent:from:to:cc:subject:date:in-reply-to :message-id:mime-version; bh=9cF5IqYxYj2InYMRmfggjddnYppc9EzlqbpJtswCFOc=; b=HODcUQLIo0DHm2SWxvgselcLa4dqArEO92qCD/gdLMJVimUVw0vou6BSTzhmjWwMYF 1E+buAnE4rtwp0FAJX85qZ+3o2LqSI6tChHU9pxyTtzYtmhBpSp7owpv82dDVMtUeoYZ sta4ytKhLwiQHRKRr4g0NyOUcuF6AebROFB/JemgbaMZ7IxhFV0eoXHhscnThyXgxm7u eWXLEO4OiZIpuOIFJxbs1xuVlE15lZ1DdPobHLI+vafxbu0XsqKQjOZLH7Nl5FIyDwD6 DvjVXFKvIJpLg/tYtsORHUsApO76DV7qn3AJuU1/7gtrOOQLACHhxYvOhUOXCKWBZtJn FOAg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:references:user-agent:from:to:cc:subject:date :in-reply-to:message-id:mime-version; bh=9cF5IqYxYj2InYMRmfggjddnYppc9EzlqbpJtswCFOc=; b=LY61GxlldHyyOn+9hFtLAu0yb4fAXEncIU3mcBdu0r98KwNZcS7O88AbxrwL+7zMzw MONRgC6HJhD+usL8LwSOt1rLedst9/dW1TYmgwC0i5OMixek0NctOPijzTqbCSfMUqAM EOzAJZLIejcoytOiF6micc1BGmD3hRVTlTcUmeu9WCtlqxDSA4iO5X7IQGTGydk7qLMK hfCT4LwjSrvnCL2ksWIM/IONz/zFLmtXNj+lSEc98/j6kb/2T5LVkvw/mnC6E5w+MbzZ By+2ZLgD0TzUpPl05aAhQhE/KK71IQW51jOaLbmle5RH1PFiXy5f9kICtUk0yvuWzV9H NfQw== X-Gm-Message-State: AJIora8oA0FU5/jiU66d6nDDRejcF6t3dRJqnf7R6/G8Sr1a1f09i3f0 SOYbLngqu7zJQEqubTMdmynUNGCLQK88YQ== X-Google-Smtp-Source: AGRyM1sRv34EaaWYc7DQ/cybSSP4tt+pHpLB0OquCLm3mDR/BmnZSy7nB06i+Pl5+EtSLGZ2Xxh7qA== X-Received: by 2002:a05:6638:d86:b0:33c:cb7f:4ecc with SMTP id l6-20020a0566380d8600b0033ccb7f4eccmr8907108jaj.28.1656685799208; Fri, 01 Jul 2022 07:29:59 -0700 (PDT) Received: from ArchLinux ([240e:390:a20:ece0:3ad5:47ff:feb5:73b2]) by smtp.gmail.com with ESMTPSA id b15-20020a056602218f00b00669b2ffad32sm10288981iob.54.2022.07.01.07.29.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 Jul 2022 07:29:58 -0700 (PDT) References: <20220630161220.53449-1-schspa@gmail.com> <87mtdu15ok.wl-maz@kernel.org> <87letd0wqm.wl-maz@kernel.org> User-agent: mu4e 1.7.5; emacs 28.1 From: Schspa Shi To: Marc Zyngier Cc: james.morse@arm.com, alexandru.elisei@arm.com, suzuki.poulose@arm.com, catalin.marinas@arm.com, will@kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, linux-kernel@vger.kernel.org Subject: Re: [PATCH] KVM: arm64: Fix 64 bit mmio handle Date: Fri, 01 Jul 2022 22:22:51 +0800 In-reply-to: <87letd0wqm.wl-maz@kernel.org> Message-ID: MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220701_073001_141099_9115096B X-CRM114-Status: GOOD ( 14.56 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Marc Zyngier writes: >> >> I have running some static code analysis software upon Kernel >> code. >> Seeing there is possible overflow. >> >> maks << 1U << ((len * 8) -1); >> >> The AI don't know, len is only the value of 1, 2, 4, and make >> this >> a warnings >> >> I tring to analysis this, but didn't realize the real scenario >> of >> sign extension, and finally sent this problematic patch. >> >> I do see some uninitialized memory reads (the values are not >> used >> in the end, just as temporary space for API execution), >> do we need to fix these? > > You need to be more descriptive here. What uninitialised reads? > In > general, pointing at the code and providing a full description > of what > you think is incorrect would really help... > > M. One example is int vgic_v3_has_attr_regs(struct kvm_device *dev, struct kvm_device_attr *attr) { ... case KVM_DEV_ARM_VGIC_GRP_CPU_SYSREGS: { u64 reg, id; id = (attr->attr & KVM_DEV_ARM_VGIC_SYSREG_INSTR_MASK); return vgic_v3_has_cpu_sysregs_attr(vcpu, 0, id, ®); } } The funcion vgic_v3_has_cpu_sysregs_attr will read reg's value to params without initialization. There should have no problems, because the register value never used. -- BRs Schspa Shi _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 99D31C43334 for ; Fri, 1 Jul 2022 14:34:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232748AbiGAOew (ORCPT ); Fri, 1 Jul 2022 10:34:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56274 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229673AbiGAOed (ORCPT ); Fri, 1 Jul 2022 10:34:33 -0400 Received: from mail-io1-xd35.google.com (mail-io1-xd35.google.com [IPv6:2607:f8b0:4864:20::d35]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 231E4904C8 for ; Fri, 1 Jul 2022 07:30:00 -0700 (PDT) Received: by mail-io1-xd35.google.com with SMTP id p128so2452908iof.1 for ; Fri, 01 Jul 2022 07:30:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=references:user-agent:from:to:cc:subject:date:in-reply-to :message-id:mime-version; bh=9cF5IqYxYj2InYMRmfggjddnYppc9EzlqbpJtswCFOc=; b=HODcUQLIo0DHm2SWxvgselcLa4dqArEO92qCD/gdLMJVimUVw0vou6BSTzhmjWwMYF 1E+buAnE4rtwp0FAJX85qZ+3o2LqSI6tChHU9pxyTtzYtmhBpSp7owpv82dDVMtUeoYZ sta4ytKhLwiQHRKRr4g0NyOUcuF6AebROFB/JemgbaMZ7IxhFV0eoXHhscnThyXgxm7u eWXLEO4OiZIpuOIFJxbs1xuVlE15lZ1DdPobHLI+vafxbu0XsqKQjOZLH7Nl5FIyDwD6 DvjVXFKvIJpLg/tYtsORHUsApO76DV7qn3AJuU1/7gtrOOQLACHhxYvOhUOXCKWBZtJn FOAg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:references:user-agent:from:to:cc:subject:date :in-reply-to:message-id:mime-version; bh=9cF5IqYxYj2InYMRmfggjddnYppc9EzlqbpJtswCFOc=; b=QqqbKIlqPxvkWQgEj0Xr6Z9NTHye9xt6GKgLrAjxq6wp9orWMvGQhOITKtPOh7htPu L/eyW4mtPkpd0U5Ryc5pg3J4ZB3mwx8g69OTP7y/asT1xdxGT6gYpb7bjujUXSw5a1UG BfxMxHaSbDTU6kXi74o1GWQjekg6XTT3KiV2QPq5KGXvqniEZM0qqPtB5xzCUKYvvxkd ZXctoIl/NvirX3d5URXHPWvwlVI63YJblCHslghNVbUWtVyZvSMTlsF/B4TYFQECIpG3 5BSb9Xcf1HkjWd/FRtm3e1G6PPmTjpUyKCotDlzm8DlH9pk3ZzOmN50jqq+aYb6drTsg Jknw== X-Gm-Message-State: AJIora+4aDH2sAZ4Tgfe1GoSLIxEpGgkY/czEYm0JN1mb6fp1IO7QbsA aCybxAlLpDlin4GhpJ2r0Dq5PYwPXJSaPg== X-Google-Smtp-Source: AGRyM1sRv34EaaWYc7DQ/cybSSP4tt+pHpLB0OquCLm3mDR/BmnZSy7nB06i+Pl5+EtSLGZ2Xxh7qA== X-Received: by 2002:a05:6638:d86:b0:33c:cb7f:4ecc with SMTP id l6-20020a0566380d8600b0033ccb7f4eccmr8907108jaj.28.1656685799208; Fri, 01 Jul 2022 07:29:59 -0700 (PDT) Received: from ArchLinux ([240e:390:a20:ece0:3ad5:47ff:feb5:73b2]) by smtp.gmail.com with ESMTPSA id b15-20020a056602218f00b00669b2ffad32sm10288981iob.54.2022.07.01.07.29.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 Jul 2022 07:29:58 -0700 (PDT) References: <20220630161220.53449-1-schspa@gmail.com> <87mtdu15ok.wl-maz@kernel.org> <87letd0wqm.wl-maz@kernel.org> User-agent: mu4e 1.7.5; emacs 28.1 From: Schspa Shi To: Marc Zyngier Cc: james.morse@arm.com, alexandru.elisei@arm.com, suzuki.poulose@arm.com, catalin.marinas@arm.com, will@kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, linux-kernel@vger.kernel.org Subject: Re: [PATCH] KVM: arm64: Fix 64 bit mmio handle Date: Fri, 01 Jul 2022 22:22:51 +0800 In-reply-to: <87letd0wqm.wl-maz@kernel.org> Message-ID: MIME-Version: 1.0 Content-Type: text/plain; format=flowed Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Marc Zyngier writes: >> >> I have running some static code analysis software upon Kernel >> code. >> Seeing there is possible overflow. >> >> maks << 1U << ((len * 8) -1); >> >> The AI don't know, len is only the value of 1, 2, 4, and make >> this >> a warnings >> >> I tring to analysis this, but didn't realize the real scenario >> of >> sign extension, and finally sent this problematic patch. >> >> I do see some uninitialized memory reads (the values are not >> used >> in the end, just as temporary space for API execution), >> do we need to fix these? > > You need to be more descriptive here. What uninitialised reads? > In > general, pointing at the code and providing a full description > of what > you think is incorrect would really help... > > M. One example is int vgic_v3_has_attr_regs(struct kvm_device *dev, struct kvm_device_attr *attr) { ... case KVM_DEV_ARM_VGIC_GRP_CPU_SYSREGS: { u64 reg, id; id = (attr->attr & KVM_DEV_ARM_VGIC_SYSREG_INSTR_MASK); return vgic_v3_has_cpu_sysregs_attr(vcpu, 0, id, ®); } } The funcion vgic_v3_has_cpu_sysregs_attr will read reg's value to params without initialization. There should have no problems, because the register value never used. -- BRs Schspa Shi