From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1nWGzw-0007tL-1I for mharc-grub-devel@gnu.org; Mon, 21 Mar 2022 08:18:57 -0400 Received: from eggs.gnu.org ([209.51.188.92]:41336) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nWGzs-0007k9-HA for grub-devel@gnu.org; Mon, 21 Mar 2022 08:18:53 -0400 Received: from mx0b-00069f02.pphosted.com ([205.220.177.32]:55650) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nWGzp-0000y5-LV for grub-devel@gnu.org; Mon, 21 Mar 2022 08:18:51 -0400 Received: from pps.filterd (m0246632.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 22L9Wd5Q014720 for ; Mon, 21 Mar 2022 12:18:43 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : cc : subject : in-reply-to : references : date : message-id : content-type : mime-version; s=corp-2021-07-09; bh=Jk5B8zFMEESZGnUlLXAk5qJxAIhtvbioxj3ps8LTciM=; b=aum70Yhw9sJg2F9D80jPxOIGlCzhaXNYlABYi1YdRCSczVJwCed1YRd54GTHJYZ9D2lf rvguEq3abcgprNusW7IG6qtIGX03mD9nNHEnaESZOyI/oWG/lgIYC8VFeYuFFtkDmp4c 0g7CC7RgscXJw5+eo4jZ4q+v8msq8mk9bKQCEUjgGFy78Ul85Zo64HEPVWMTJtkvfJTQ cJ/rM5AdFNoemTv5MJ7L48E7VvfwwWqYaORk4em2wCG9iio3F5uev5THMhErF4iNLyws wek3S83jlfL19C/jyB9GmO14LxxzZYMfZHRH7HYwoLsl4P9Wd8bvdiBBHmHjaBEbwETS 6A== Received: from userp3030.oracle.com (userp3030.oracle.com [156.151.31.80] (may be forged)) by mx0b-00069f02.pphosted.com with ESMTP id 3ew6ss32b8-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Mon, 21 Mar 2022 12:18:42 +0000 Received: from pps.filterd (userp3030.oracle.com [127.0.0.1]) by userp3030.oracle.com (8.16.1.2/8.16.1.2) with SMTP id 22LCBV0S106410 for ; Mon, 21 Mar 2022 12:18:41 GMT Received: from nam11-co1-obe.outbound.protection.outlook.com (mail-co1nam11lp2173.outbound.protection.outlook.com [104.47.56.173]) by userp3030.oracle.com with ESMTP id 3ew49r39r2-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Mon, 21 Mar 2022 12:18:41 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hkZJ0piA44gQ8gueY1/BYiHz80idS/yOZ9f7iQQHDs+XyfzHagLPFBGq3YLtefepzK25DnvOZIzuJleeYXWeeaGl2Sa2LiQlM1ksGtlpUSB4yHodzVPmdRYlVxjhWSrhUsu22hDNngHFxR7v8pK5OSeIo8+e6qevHwQfBXFvY1f12Wi3Wk+tgW1rpXE0tnDli09Dn5ec89MJfGF7p/pBhfbaUt8BEjCiYk1njHnUVdXWQrBgRSRG+0TkmJ/r+qTU87ceV6X8UCdubfCamPBdhCVmUzPak0krVClwZydw9gOz2lxpbV/cwGv50YRHlzgYikFJR2I01K/m1AmVGExiYw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Jk5B8zFMEESZGnUlLXAk5qJxAIhtvbioxj3ps8LTciM=; b=k6nsp6xxoC8dXkUeDF/hp0cMNlQFv+FKUd1r5tABbTQlJyX0ILad+D3T/wq823kjm92mJWtq2sCbTnqyMCBngMv176aNz71lKABzssXhgR4rFguAq8VeLiBw5SWqwY9NkJZOAsLPkNSBcNhTVOxmj4XoOadSOAc/db0e5RGX9KaEPqs9xX9h77Eonor950O8I0LjjOtLbPB2ruoBc/SZw4ZW+lRHK14kExIOqFl1L9jT3KhSoh+gvHC42ccJpClUlPsIzTKNMZuASrh09/1DfSObh5/QJE86dgTqjlQ/QlP5HeY9kbb7/kHon70E+8gJsgtUYJ+VfMSBiueNjX/0Mg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Jk5B8zFMEESZGnUlLXAk5qJxAIhtvbioxj3ps8LTciM=; b=rfy/NGUyiba1lEYoX7uUWINNMT4G7ZFOIXsXZWPiFIT24/zeHlutJPlZm3ZMuVUebjxe4PVZHofADwiKbEGAWQPLpkdZEMauMt7vAiMJOOjqU1+547gXLqNBIJIzxF4QWg6jIHo8Hi9KJuL86lVOpWWFQScfwT4WWxV8hXrBfjc= Received: from BLAPR10MB5138.namprd10.prod.outlook.com (2603:10b6:208:322::8) by SJ0PR10MB4687.namprd10.prod.outlook.com (2603:10b6:a03:2d8::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5081.14; Mon, 21 Mar 2022 12:18:39 +0000 Received: from BLAPR10MB5138.namprd10.prod.outlook.com ([fe80::dd67:ca23:16c:36c3]) by BLAPR10MB5138.namprd10.prod.outlook.com ([fe80::dd67:ca23:16c:36c3%5]) with mapi id 15.20.5081.023; Mon, 21 Mar 2022 12:18:38 +0000 From: Darren Kenny To: Alec Brown , grub-devel@gnu.org Cc: daniel.kiper@oracle.com, alec.r.brown@oracle.com Subject: Re: [PATCH v2 0/7] Fix coverity uninitialized scalar variable bugs in grub-core In-Reply-To: <1647844142-20619-1-git-send-email-alec.r.brown@oracle.com> References: <1647844142-20619-1-git-send-email-alec.r.brown@oracle.com> Date: Mon, 21 Mar 2022 12:18:33 +0000 Message-ID: Content-Type: text/plain X-ClientProxiedBy: DU2PR04CA0334.eurprd04.prod.outlook.com (2603:10a6:10:2b4::24) To BLAPR10MB5138.namprd10.prod.outlook.com (2603:10b6:208:322::8) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: d9c22cbc-1b70-4314-2541-08da0b34ee0b X-MS-TrafficTypeDiagnostic: SJ0PR10MB4687:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: u4fKxExdzK+LkFzVxPqoeFQyyP50srhzGoM61VlIlE/0r8/8tKPaoWdZZ9qg3sc+0ZadHHRTA+AfcoTKfGuGgH4otREDNRZVIPzvsbSuk0Lf8B+mZ4Jc1qEtRK1F2MC9mOhVIDZeTTp+9N/bRt3HBsahRoWzVZ95SjQsUo+u37g5jQzMcJEzoeFbtJ7kNRBn9fhRGoFL4B+Cti2RK6oa5WTrjfORVQ7fM79p6bupD+MMvnXB8AnESMNBp5aC7Y/Xxf7jFVWg6+b5NGe+B5zMtUQZe/ripHhlWgubl0lnoLtEsGzZNUEr1gPRXVZXzmNfyiwMBXXKZE3/a/0WNeOgyew2kDR3vao/p/bBCFydkijt3AcQSXYpkDIZcvLlYUkQtV8IbUEjNP4uT7AndMLWG0QqlNsuqbmgFtQtpusi3EE6kSyN5YSN5nxjExzrPRO7Lez9rLir7cHe/7c75AnNPaTX9L3C7YSzJ1/nuOl8ZMI/5+/aVP8BWLRHCziRhS2LzSCjQGL6a4SGqV7sangS5NtzrQq+23tUMfnSk5ZLYReEVLnDYN77NAeOsnit6ejTJ3u2xh2y/+PLMWrByt3eZ0C6va0Ufn/c5QbV6OjB0nxeVuyN4orgpPSczTjLWbH2csSzFPJEcbMW78aS9cWo/Jq+Jj9kt51DWtaPFIME6UuWCcBi0T3JOJVcdHAkYJLVN/ekl8LRvO4uLQdV04VS3w== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BLAPR10MB5138.namprd10.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(66476007)(6486002)(83380400001)(8676002)(4326008)(44832011)(508600001)(5660300002)(66556008)(36756003)(38100700002)(38350700002)(316002)(107886003)(6506007)(52116002)(6512007)(86362001)(2616005)(186003)(26005)(8936002)(66946007)(2906002)(6666004); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?Y7SnOk704iOEGcLxQj5z3e9gBPcGmtl0PBaDiuZxYnP7+4WUZMBUWW398+4w?= =?us-ascii?Q?tIOcH3YrKOB9xEpmbAdbiPlTX74GNP2nVquaOU+OinZ026GRzTvYixdRyLvQ?= =?us-ascii?Q?Keb97h8YqXxkBChV3xK6d6ycfqycNcXeVdI6sKR8Efk11mCSPXBTh0USWiSF?= =?us-ascii?Q?m3eLEAZEh7nwViWhqq+5xf5kJdv+4ABBonEss5934GRuZoGLpiupRSznIbSG?= =?us-ascii?Q?sQSMgKHGzlwT94+kWjbBrOXcsWCv6NNyivK3bG+/G1fjm0BNE686N/9q/eq+?= =?us-ascii?Q?/ERId2dBUvm8l3YPB69nK2ACAGek83Tgsx17vj18ELTLh/gIF3e/6imgwYpS?= =?us-ascii?Q?sMerilJEUp+ggkAOEjAqw4OSHG2MnnBbE/QFi5AgNbXOhwxFmBJ8aXgn8A5s?= =?us-ascii?Q?g9igLdKZpeTb9qG+jZo3mRw13R4wkXI5JCOpM0uBcU2Ukq7/qOaLQahAOeim?= =?us-ascii?Q?ZI8Kxfl4noUf0YKwmFDcMOpD8l+GJkIIHT1v7+UXhrdt0DpV8gP1yTMMC/I6?= =?us-ascii?Q?v8/xhaLMnyXfWnA/qSJZJS9hI7LSXe96d2X3GQ3EN6oTIp9W3ThOtzTtP9mL?= =?us-ascii?Q?6pzCBOTj58aKYbnAacLECSLVW3Ltyp8z8BHBxtnoMxzMVaseB85JjAf4KjVv?= =?us-ascii?Q?yNVuANA7JCNyotKOYgsO2f8gswV1xxF31Okr+KpmvzzrP3/Iwt5dwndZJkQ7?= =?us-ascii?Q?KUud3L2XwdV7pTKujRHplJVNAiRs4iYWXli1KDXwR1Q/MZXbFH5NKq86AlbJ?= =?us-ascii?Q?SsOlugY/SstIAvOnqL2L8snJGNrtzeRWMWIKlLJw4UZqmkRjAjTzqf21kG8F?= =?us-ascii?Q?UXiVHCIPNeILAKBI2vkazOdCQIn012Yv3QDjqUYPrDfA5jl/aesz0S2W9NQc?= =?us-ascii?Q?t3AKeeTO46YSRqdII08jvxwtZFq5GapAp1W0xHxT9QcBsj/8TbT2acGcaT4Y?= =?us-ascii?Q?kJ4WpqRVCC2uEjTLMbpBHPyD35Cmc9swbAaxknnkhWKiwksG4lMWKKS5uyaC?= =?us-ascii?Q?0k8DWkYxsvej8SFwbMUpqpATNZVUEyXFHj+/rlZauiOCcNhBYodJumR+bmDr?= =?us-ascii?Q?oZeelnaVgUvQP/vq/cy7gwi24jg6F6SwT4zoCeqHUSBLonB0HF6vfV5lMtNW?= =?us-ascii?Q?PqiH8bMMiXv8BxHrYHpSI58aHyXAHi+wskt2SlmS4xLgx0Ve5Gs0qXSQ3hZt?= =?us-ascii?Q?tKiqEx1m29oXy3G8PKimQ7ELoOoDWWdt81Bk6n7IOdjOu5d6PYWpVjBeNdzd?= =?us-ascii?Q?hz38zhPzDTbjRcXL2POQSpqGfUa5fqCHmdHx76qE7PTWGTS6SYN5MZ0nJCBU?= =?us-ascii?Q?X8/FNSjy4fqEdMcX+/ZKw0fl+zsYH21IDWNo9FkQkFCEVtLgZSKjINFI8RZd?= =?us-ascii?Q?JgoIN1lyR2mm+bixiP4kn4TH8izuM8fkkJVQOFEGUL5jTP6aW7RQw2PhAY0F?= =?us-ascii?Q?14UIzXiALY8jA06PVs2XPKIBq6dkhkZjZAUag55h8y1dV+2aHUOjNw=3D=3D?= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: d9c22cbc-1b70-4314-2541-08da0b34ee0b X-MS-Exchange-CrossTenant-AuthSource: BLAPR10MB5138.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Mar 2022 12:18:38.8446 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: zwTYgg5VzJG9L82kJz3DhlXuAIR1DwqtPXVAf7eOfs9bvkH5kDUBt2/Txo3kBCBJ4UJTZQHjBNt2xhdmMvFagA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR10MB4687 X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10292 signatures=694221 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 malwarescore=0 mlxscore=0 bulkscore=0 phishscore=0 spamscore=0 mlxlogscore=999 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2202240000 definitions=main-2203210079 X-Proofpoint-ORIG-GUID: Ky_09cylF_3SF2LjwLP_iAM9fG1_6-7w X-Proofpoint-GUID: Ky_09cylF_3SF2LjwLP_iAM9fG1_6-7w Received-SPF: pass client-ip=205.220.177.32; envelope-from=darren.kenny@oracle.com; helo=mx0b-00069f02.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 21 Mar 2022 12:18:53 -0000 Hi Alec, These changes look good. For the series: Reviewed-by: Darren Kenny Thanks, Darren. On Monday, 2022-03-21 at 02:28:55 -04, Alec Brown wrote: > v2: Set structs with multiple uninitialized members to {0} and set single > uninitialized members to 0. > > Coverity identified multiple uninitialized scalar variable bugs in multiple > components of the grub-core. These patches address these issues. > > The Coverity bugs being addressed are: > CID 375026 > CID 375028 > CID 375030 > CID 375031 > CID 375033 > CID 375035 > CID 375036 > > Alec Brown (7): > grub-core/loader/i386/bsd.c: Fix uninitialized scalar variable > grub-core/loader/i386/pc/linux.c: Fix uninitialized scalar variable > grub-core/net/arp.c: Fix uninitialized scalar variable > grub-core/loader/i386/xnu.c: Fix uninitialized scalar variable > grub-core/net/net.c: Fix uninitialized scalar variable > grub-core/loader/i386/xnu.c: Fix uninitialized scalar variable > grub-core/net/bootp.c: Fix uninitialized scalar variable > > grub-core/loader/i386/bsd.c | 2 +- > grub-core/loader/i386/pc/linux.c | 2 +- > grub-core/loader/i386/xnu.c | 4 ++-- > grub-core/net/arp.c | 2 ++ > grub-core/net/bootp.c | 1 + > grub-core/net/net.c | 1 + > 6 files changed, 8 insertions(+), 4 deletions(-)